Replies: 1 comment 1 reply
|
Hey thank you for taking a look at the code, I appreciate it Right now the model stuff is a bit intentionally in flux, as eventually everything in model.rs will be deprecated and removed. So it's not worth spending time there. Moving forward I think we will mostly be using the catalog.json file. How to best handle translations I'm not sure, but I believe they should probably be done in this file itself. If you're interested in adding translations here I would be appreciative of a PR For everything in model.rs let's leave it be |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi!
While looking through the codebase, I noticed that there is currently some duplication regarding how model descriptions are managed:
There is a detailed description of models inside translations.json.
However, these don't seem to be used actively right now, as the model data is hardcoded and loaded directly from src-tauri/src/managers/model.rs.
To keep the repository clean and maintainable, what would be your preferred approach for handling this?
Option A: Keep the model descriptions in translations.json (making them easily translatable) and refactor model.rs to load the data dynamically from the JSON file?
Option B: Keep the data strictly in model.rs and completely remove the unused model descriptions from translations.json to avoid confusion?
Let me know what you think is the best path forward, and I'd be happy to help open a PR for it!
All reactions