offer to refactor the react app #525
joshribakoff
started this conversation in
General
Replies: 1 comment 1 reply
|
Happy to review at the very least and decide from there. If you can do each in a separate PR where it makes sense it would be great so I can review |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I see some places I can improve the react app.
as one example, using sets & maps is intuitive for programmers used to systems programming but can be an anti-pattern in react, which expects immutability. Normally, we stick to arrays and objects -- and if we really need sets and maps there are libraries like ImmerJS
I can make a PR, I can add tests (playwright + vitest) too.
All reactions