Non-blocking Review Request
Commit: 6524fe8
Author: Claes Adamsson
Message: feat(sync): add pre-flight CI status check to sync command
In Trunk-Based Development, this code is already in the trunk.
Your goal is Course Correction and Knowledge Sharing, not gatekeeping.
What to Look For
| Focus |
Question |
| Design & Intent |
Does the implementation align with our architectural patterns? |
| Logic & Edge Cases |
Are there logical flaws or unhappy paths that tests might miss? |
| Readability |
Are names descriptive? (Code as Documentation) |
| Simplification |
Can this be done with less code or lower complexity? |
How to Comment
- Questions > Commands: "Could we use the existing helper here?" instead of "Change this."
- Praise: If you see something clever or clean, say so! NBR boosts team morale.
- Nitpicking: Label minor style issues as
(nit) so the author knows they're optional.
Concerns
No concerns raised yet.
To approve via CLI:
tbdflow review --approve 6524fe8
To raise a concern:
tbdflow review --concern 6524fe8 -m "Your concern here"
Non-blocking Review Request
Commit:
6524fe8Author: Claes Adamsson
Message: feat(sync): add pre-flight CI status check to sync command
What to Look For
How to Comment
(nit)so the author knows they're optional.Concerns
No concerns raised yet.
To approve via CLI:
To raise a concern: