Skip to content

chore: update test for serializing Blob#146

Open
ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/blog-serializable
Open

chore: update test for serializing Blob#146
ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/blog-serializable

Conversation

@ryanking13

Copy link
Copy Markdown
Contributor

Blob is now serializable (cloudflare/workerd@51d957f)

Since this is a workerd-side change, we don't need any release but we need to update our test

@ask-bonk

ask-bonk Bot commented Jul 3, 2026

Copy link
Copy Markdown

The changes are straightforward:

  1. A new positive test is added for Blob serialization via RPC (lines 296-298), verifying that a Blob can be sent through identity() and comes back as a Blob with the correct content.
  2. The negative test that expected Blob to throw a DataCloneError is removed, since Blob is now serializable in workerd.

The test logic is clean, consistent with the existing test patterns in the file, and the PR description clearly explains the motivation (workerd commit 51d957f made Blob serializable).

No actionable issues found.

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant