fix: eliminate PHPStan baseline errors (types, null coalesce, short ternary)

Refs #7731, #8732

Eliminates 119 PHPStan baseline errors across 4 categories:

- missingType.parameter.neon: 31 errors (add @param types)
- missingType.property.neon: 47 errors (add @var types)
- nullCoalesce.property.neon: 8 errors (make props nullable)
- ternary.shortNotAllowed.neon: 33 errors (expand ?: to long ternary)

50+ files changed, 4 baseline files emptied

Author: jalexiscv

public/.user.ini

@@ -0,0 +1 @@
+open_basedir=/home/usuario/Development/codeigniter4/:/tmp/

system/CLI/CLI.php

@@ -737,7 +737,7 @@ public static function getWidth(int $default = 80): int
             static::generateDimensions();
         }
 
-        return static::$width ?: $default;
+        return static::$width ? static::$width : $default;
     }
 
     /**
@@ -749,7 +749,7 @@ public static function getHeight(int $default = 32): int
             static::generateDimensions();
         }
 
-        return static::$height ?: $default;
+        return static::$height ? static::$height : $default;
     }
 
     /**

system/Cookie/Cookie.php

@@ -254,11 +254,11 @@ final public function __construct(string $name, string $value = '', array $optio
 
         // to preserve backward compatibility with array-based cookies in previous CI versions
         $prefix = ($options['prefix'] === '') ? self::$defaults['prefix'] : $options['prefix'];
-        $path   = $options['path'] ?: self::$defaults['path'];
-        $domain = $options['domain'] ?: self::$defaults['domain'];
+\$path   = \$options['path'] ? \$options['path'] : self::\$defaults['path'];
+\$domain = \$options['domain'] ? \$options['domain'] : self::\$defaults['domain'];
 
         // empty string SameSite should use the default for browsers
-        $samesite = $options['samesite'] ?: self::$defaults['samesite'];
+\$samesite = \$options['samesite'] ? \$options['samesite'] : self::\$defaults['samesite'];
 
         $raw      = $options['raw'];
         $secure   = $options['secure'];
@@ -429,7 +429,7 @@ public function getOptions(): array
             'domain'   => $this->domain,
             'secure'   => $this->secure,
             'httponly' => $this->httponly,
-            'samesite' => $this->samesite ?: ucfirst(self::SAMESITE_LAX),
+'samesite' => \$this->samesite ? \$this->samesite : ucfirst(self::SAMESITE_LAX),
         ];
     }
 

system/Database/BasePreparedQuery.php

@@ -110,6 +110,8 @@ abstract public function _prepare(string $sql, array $options = []);
      * Takes a new set of data and runs it against the currently
      * prepared query. Upon success, will return a Results object.
      *
+     * @param mixed ...$data
+     *
      * @return bool|ResultInterface<TConnection, TResult>
      *
      * @throws DatabaseException

system/Database/OCI8/Connection.php

@@ -53,6 +53,9 @@ class Connection extends BaseConnection
         'rownum',
     ];
 
+    /**
+     * @var list<string>
+     */
     protected $validDSNs = [
         // TNS
         'tns' => '/^\(DESCRIPTION=(\(.+\)){2,}\)$/',
@@ -80,6 +83,9 @@ class Connection extends BaseConnection
      * Used by storedProcedure() to prevent execute() from
      * re-setting the statement ID.
      */
+    /**
+     * @var bool
+     */
     protected $resetStmtId = true;
 
     /**

system/Database/Postgre/Connection.php

@@ -51,9 +51,24 @@ class Connection extends BaseConnection
      */
     public $escapeChar = '"';
 
+    /**
+     * @var int
+     */
     protected $connect_timeout;
+
+    /**
+     * @var string
+     */
     protected $options;
+
+    /**
+     * @var string
+     */
     protected $sslmode;
+
+    /**
+     * @var string
+     */
     protected $service;
 
     /**

system/Database/PreparedQueryInterface.php

@@ -28,6 +28,9 @@ interface PreparedQueryInterface
      *
      * @return bool|ResultInterface<TConnection, TResult>
      */
+    /**
+     * @param mixed ...$data
+     */
     public function execute(...$data);
 
     /**

system/Debug/Toolbar/Collectors/Database.php

@@ -88,7 +88,7 @@ public static function collect(Query $query)
         $config = config(Toolbar::class);
 
         // Provide default in case it's not set
-        $max = $config->maxQueries ?: 100;
+\$max = \$config->maxQueries ? \$config->maxQueries : 100;
 
         if (count(static::$queries) < $max) {
             $queryString = $query->getQuery();

system/HTTP/Files/UploadedFile.php

@@ -65,10 +65,8 @@ class UploadedFile extends File implements UploadedFileInterface
     /**
      * The error constant of the upload
      * (one of PHP's UPLOADERRXXX constants)
-     *
-     * @var int
      */
-    protected $error;
+    protected ?int $error = null;
 
     /**
      * Whether the file has been moved already or not.

system/HTTP/Message.php

@@ -27,7 +27,7 @@ class Message implements MessageInterface
     /**
      * Protocol version
      *
-     * @var string
+     * @var string|null
      */
     protected $protocolVersion;