[search] Test using web workers in node.

See: nodejs/node#43583 (comment)

Author: lgarron

src/cubing/search/instantiator.ts

@@ -1,5 +1,4 @@
-import type { Worker as NodeWorker } from "node:worker_threads";
-import { PortableWorker, wrap } from "@cubing/comlink-everywhere";
+import { wrap } from "@cubing/comlink-everywhere";
 import type { WorkerAPI } from "./inside/api";
 import { searchOutsideDebugGlobals } from "./outside";
 import {
@@ -8,7 +7,7 @@ import {
   searchWorkerURLNewURLImportMetaURL,
 } from "./worker-workarounds";
 
-function wrapAPI(worker: Worker | NodeWorker): WorkerAPI {
+function wrapAPI(worker: Worker): WorkerAPI {
   return wrap<WorkerAPI>(worker);
 }
 
@@ -18,7 +17,7 @@ async function instantiateModuleWorker(
   // biome-ignore lint/suspicious/noAsyncPromiseExecutor: TODO
   return new Promise<WorkerAPI>(async (resolve, reject) => {
     try {
-      const worker = new PortableWorker(workerEntryFileURL);
+      const worker = new Worker(workerEntryFileURL, { type: "module" });
 
       // TODO: Remove this once we can remove the workarounds for lack of `import.meta.resolve(…)` support.
       const onFirstMessage = (messageData: string) => {
@@ -36,21 +35,17 @@ async function instantiateModuleWorker(
         reject(e);
       };
 
-      if ("once" in worker /* hack to detect `node` */) {
-        // We have to use `once` so the `unref()` from `comlink-everywhere` allows the process to quit as expected.
-        worker.once("message", onFirstMessage);
-      } else {
-        worker.addEventListener("error", onError, {
+      console.log({ worker });
+      worker.addEventListener("error", onError, {
+        once: true,
+      });
+      worker.addEventListener(
+        "message",
+        (e: MessageEvent) => onFirstMessage(e.data),
+        {
           once: true,
-        });
-        worker.addEventListener(
-          "message",
-          (e: MessageEvent) => onFirstMessage(e.data),
-          {
-            once: true,
-          },
-        );
-      }
+        },
+      );
     } catch (e) {
       reject(e);
     }

src/cubing/search/worker-workarounds/search-worker-entry.js

@@ -2,14 +2,7 @@ import { exposeAPI } from "./worker-guard";
 
 if (exposeAPI.expose) {
   void import("../inside").then(() => {
-    // Workaround for `node`'
-    if (globalThis.postMessage) {
-      globalThis.postMessage("comlink-exposed"); // TODO: remove this
-    } else {
-      globalThis.process
-        .getBuiltinModule("node:worker_threads")
-        .parentPort?.postMessage("comlink-exposed");
-    }
+    globalThis.postMessage("comlink-exposed"); // TODO: remove this
   });
 }
 

tsconfig.lib.no-dom.jsonc

@@ -2,16 +2,7 @@
   "schema": "https://json.schemastore.org/tsconfig",
   "extends": "./tsconfig.lib.jsonc",
   "compilerOptions": {
-    "skipLibCheck": true,
-    "types": [
-      // Specifying a deeply nested type file like this is bad practice, but the
-      // `@types/node` types are constructed well and including this one file
-      // does a great job of preventing much more complicated workarounds.
-      //
-      // Hopefully some day this won't be necessary:
-      // https://github.com/nodejs/node/issues/43583
-      "./node_modules/@types/node/worker_threads.d.ts"
-    ]
+    "skipLibCheck": true
   },
   "exclude": [
     "./**/*.test.dom.ts",