Skip to content

Commit aebca14

Browse files
authored
acc: always run acceptance tests locally (#6196)
## Changes Drop the `Local` `test.toml` knob. Every acceptance test already runs against the testserver, so local runs include all tests by default; `Cloud` / `CloudSlow` still opt into real-workspace runs. `DATABRICKS_TEST_SKIPLOCAL` keeps skipping acceptance tests on cloud PR/integration runs (with `withchanged` re-enabling touched tests). Most of the diff is mechanical `Local = true` removals from `test.toml` / `out.test.toml`. After this merges, any `test.toml` that still sets `Local` will fail config loading with an undecoded-key error. Drop the `Local` line (tests always run locally now). ## Why There are now no remaining `Local = false` tests. Keeping an opt-out that nobody uses invites new cloud-only gaps and forces every `test.toml` / `out.test.toml` to repeat `Local = true`.
1 parent b664bb6 commit aebca14

1,344 files changed

Lines changed: 11 additions & 1394 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

acceptance/acceptance_test.go

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -659,14 +659,10 @@ func validateTestPhase(phase int) error {
659659
func getSkipReason(config *internal.TestConfig, configPath, dir, skipLocalMode string, changedTests map[string][]string) string {
660660
switch skipLocalMode {
661661
case SkipLocalAll:
662-
if isTruePtr(config.Local) {
663-
return "Disabled via DATABRICKS_TEST_SKIPLOCAL=" + SkipLocalAll + " in " + configPath
664-
}
662+
return "Disabled via DATABRICKS_TEST_SKIPLOCAL=" + SkipLocalAll + " in " + configPath
665663
case SkipLocalWithChanged:
666-
if isTruePtr(config.Local) {
667-
if _, ok := changedTests[dir]; !ok {
668-
return "Disabled via DATABRICKS_TEST_SKIPLOCAL=" + SkipLocalWithChanged + " in " + configPath
669-
}
664+
if _, ok := changedTests[dir]; !ok {
665+
return "Disabled via DATABRICKS_TEST_SKIPLOCAL=" + SkipLocalWithChanged + " in " + configPath
670666
}
671667
}
672668

@@ -721,11 +717,6 @@ func getSkipReason(config *internal.TestConfig, configPath, dir, skipLocalMode s
721717
return fmt.Sprintf("Disabled via RequiresCluster setting in %s (TEST_DEFAULT_CLUSTER_ID is empty)", configPath)
722718
}
723719

724-
} else {
725-
// Local run
726-
if !isTruePtr(config.Local) {
727-
return fmt.Sprintf("Disabled via Local setting in %s (CLOUD_ENV=%s)", configPath, cloudEnv)
728-
}
729720
}
730721

731722
return ""

acceptance/apps/deploy/bundle-no-args-with-flags/out.test.toml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

acceptance/apps/deploy/bundle-no-args-with-flags/test.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Local = true
21
Cloud = false
32

43
Ignore = [

acceptance/apps/deploy/bundle-no-args/out.test.toml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

acceptance/apps/deploy/bundle-no-args/test.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Local = true
21
Cloud = false
32

43
Ignore = [

acceptance/apps/deploy/bundle-with-appname/out.test.toml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

acceptance/apps/deploy/bundle-with-appname/test.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Local = true
21
Cloud = false
32
RecordRequests = true
43

acceptance/apps/deploy/no-bundle-no-args/out.test.toml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

acceptance/apps/deploy/no-bundle-no-args/test.toml

Lines changed: 0 additions & 2 deletions
This file was deleted.

acceptance/apps/deploy/no-bundle-with-appname/out.test.toml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)