Commit 31356fb
feat(136): align MAESTRO layer names with canonical CSA taxonomy (#146)
* chore(136): feature planning and governance artifacts
Add PRD, spec, plan, tasks, research, discovery report, agent assignments,
and checklists for Feature 136 (MAESTRO canonical layer correctness fix).
All Triad sign-offs complete:
- spec.md: PM APPROVED
- plan.md: PM APPROVED + Architect APPROVED_WITH_CONCERNS
- tasks.md: PM + Architect + Team-Lead APPROVED_WITH_CONCERNS
Discovery report documents pre-edit grep sweep of 35 affected files
across schemas, shared references, Typst templates, examples, and tests.
Closes #136 planning phase.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* feat(136): align MAESTRO layer names with canonical CSA taxonomy
BREAKING: Renames schema_version 1.2 -> 1.3 enum values for maestro_layer.
Downstream consumers must update tooling to match canonical names.
Migration mapping:
L5 - Security -> L5 - Evaluation and Observability
L6 - Agent Ecosystem -> L6 - Security and Compliance
L7 - User Interface -> L7 - Agent Ecosystem
L6 - Integration Services -> L6 - Security and Compliance (bug fix)
Changes across 15 foundation files:
Schema and shared references:
- schemas/finding.yaml: schema_version 1.2 -> 1.3, canonical enum values
- .claude/skills/tachi-shared/references/maestro-layers-shared.md:
canonical acronym expansion (Multi-Agent Environment, Security, Threat,
Risk, and Outcome), seven-layer taxonomy table, new L5 observability
keyword set (audit log, monitoring, SIEM, telemetry, anomaly detection,
etc.), updated L6/L7 keyword reassignment, load-bearing ordering
rationale updated
- .claude/skills/tachi-shared/references/finding-format-shared.md:
enum list updated
Pipeline references:
- .claude/skills/tachi-orchestration/references/dispatch-rules.md:
example row updated
- .claude/skills/tachi-orchestration/references/output-schemas.md:
schema_version bumped
PDF security report templates:
- templates/tachi/security-report/maestro-findings.typ: fallback
dictionary corrected, fixes pre-existing "Integration Services" bug
- templates/tachi/security-report/main.typ: narrative updated
- templates/tachi/security-report/full-bleed.typ: infographic-page()
function constrained to 7.5in height to handle portrait-aspect images
(e.g., threat-executive-architecture.jpg) without wrapping across
multiple pages. Fixes Feature 128 latent layout bug discovered during
Feature 136 human QA
Schema examples and infographic templates:
- templates/tachi/output-schemas/threats.md: schema_version + layer names
- templates/tachi/infographics/infographic-maestro-stack.md: layer labels
- templates/tachi/infographics/infographic-maestro-heatmap.md: layer labels
Documentation:
- docs/architecture/02_ADRs/ADR-020-maestro-layer-classification.md:
acronym, schema version, new Revision History section documenting the
enum-value-only-breaking-change minor-bump rule
- docs/architecture/00_Tech_Stack/README.md: acronym and schema ref
- README.md: MAESTRO overview table rows
- CHANGELOG.md: migration guide under Unreleased with old->new mapping,
acronym correction, Typst bug fix, regenerated examples inventory,
downstream migration 4-step checklist
Refs #136.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(136): regenerate example outputs with canonical layer names
Wave 2 regeneration of all six example architectures with canonical
MAESTRO L5/L6/L7 taxonomy, schema_version 1.3, and byte-deterministic
PDF baselines under SOURCE_DATE_EPOCH=1700000000 per ADR-021.
Five byte-compat-tested examples (threats.md + security-report.pdf.baseline):
- examples/web-app/
- examples/microservices/
- examples/ascii-web-api/
- examples/free-text-microservice/
- examples/mermaid-agentic-app/
Agentic-app showcase (full pipeline regeneration):
- examples/agentic-app/threats.md (top-level)
- examples/agentic-app/sample-report/ — 28 files:
* threats.md, threats.sarif (inherited unchanged)
* risk-scores.md, risk-scores.sarif
* compensating-controls.md, compensating-controls.sarif
* threat-report.md (narrative)
* threat-baseball-card-spec.md, threat-system-architecture-spec.md,
threat-executive-architecture-spec.md, threat-risk-funnel-spec.md,
threat-maestro-stack-spec.md (new), threat-maestro-heatmap-spec.md (new)
* attack-trees/ — 13 PNG files (new, per Feature 112)
* security-report.pdf (rebuilt with canonical layers and Typst layout fix)
* architecture.md (frontmatter sync per Feature 120)
Downstream layer classification corrections (code review T041a findings):
- examples/agentic-app/threats.md: Guardrails Service L5 -> L6
(keyword `guardrail` matches L6 Security and Compliance)
- examples/agentic-app/sample-report/threats.md: same correction
- examples/free-text-microservice/threats.md: External Clients and
External Payment Provider L6 -> L7 (keywords `client` and `REST API`
match L7 Agent Ecosystem, no L6 match)
- Downstream propagated in agentic-app sample-report risk-scores.md +
.sarif and compensating-controls.md + .sarif
Verification:
- test_backward_compatibility.py: 5/5 PASS (byte-deterministic)
- pytest tests/: 39/39 PASS
- grep for old layer names in examples/: zero matches
Refs #136.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* chore(136): regenerate backlog after Feature 136 build phase
Auto-regeneration of BACKLOG.md from GitHub Issues following the
completion of Feature 136 build phase. Issue #136 moved to stage:build.
Refs #136.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* chore(136): backlog regen after stage transition to deliver
Auto-regeneration reflects #136 move from stage:build to stage:deliver
on the project board.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 1095dbb commit 31356fb
File tree
63 files changed
+8882
-6434
lines changed- .claude/skills
- tachi-orchestration/references
- docs
- architecture
- 00_Tech_Stack
- 02_ADRs
- product
- 02_PRD
- _backlog
- examples
- agentic-app
- sample-report
- attack-trees
- ascii-web-api
- free-text-microservice
- mermaid-agentic-app
- microservices
- web-app
- schemas
- specs/136-maestro-canonical-layer
- checklists
- templates/tachi
- infographics
- output-schemas
- security-report
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
63 files changed
+8882
-6434
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
149 | | - | |
| 149 | + | |
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
Lines changed: 31 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
41 | 45 | | |
42 | | - | |
| 46 | + | |
43 | 47 | | |
44 | 48 | | |
45 | 49 | | |
| |||
51 | 55 | | |
52 | 56 | | |
53 | 57 | | |
54 | | - | |
55 | | - | |
56 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
57 | 61 | | |
58 | 62 | | |
59 | 63 | | |
| |||
129 | 133 | | |
130 | 134 | | |
131 | 135 | | |
132 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
133 | 153 | | |
134 | 154 | | |
135 | 155 | | |
136 | 156 | | |
137 | 157 | | |
138 | 158 | | |
139 | 159 | | |
140 | | - | |
141 | 160 | | |
142 | 161 | | |
143 | 162 | | |
| |||
147 | 166 | | |
148 | 167 | | |
149 | 168 | | |
150 | | - | |
| 169 | + | |
151 | 170 | | |
152 | 171 | | |
153 | 172 | | |
| |||
160 | 179 | | |
161 | 180 | | |
162 | 181 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | 182 | | |
169 | 183 | | |
170 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
10 | 82 | | |
11 | 83 | | |
12 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
260 | | - | |
261 | | - | |
262 | | - | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
| |||
0 commit comments