Skip to content

Commit 70896b9

Browse files
committed
fix(ampup): remove references to defunct amp-private repository
The amp-private repository no longer exists. Remove all references to prevent 404 errors and restore default build functionality. - Remove `DEFAULT_REPO_PRIVATE` constant from `lib.rs` - Replace `DEFAULT_REPO_PRIVATE` with `DEFAULT_REPO` in build command - Point default builds to public `edgeandnode/amp` repository - Fix 404 errors when building without explicit `--repo` flag Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
1 parent e923004 commit 70896b9

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

ampup/src/commands/build.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use std::path::PathBuf;
33
use anyhow::Result;
44

55
use crate::{
6-
DEFAULT_REPO_PRIVATE,
6+
DEFAULT_REPO,
77
builder::{BuildOptions, BuildSource, Builder},
88
config::Config,
99
ui,
@@ -30,19 +30,19 @@ pub async fn run(
3030
(None, Some(repo), None, None, Some(number)) => BuildSource::Pr { repo, number },
3131
(None, Some(repo), None, None, None) => BuildSource::Main { repo },
3232
(None, None, Some(branch), None, None) => BuildSource::Branch {
33-
repo: DEFAULT_REPO_PRIVATE.to_string(),
33+
repo: DEFAULT_REPO.to_string(),
3434
branch,
3535
},
3636
(None, None, None, Some(commit), None) => BuildSource::Commit {
37-
repo: DEFAULT_REPO_PRIVATE.to_string(),
37+
repo: DEFAULT_REPO.to_string(),
3838
commit,
3939
},
4040
(None, None, None, None, Some(number)) => BuildSource::Pr {
41-
repo: DEFAULT_REPO_PRIVATE.to_string(),
41+
repo: DEFAULT_REPO.to_string(),
4242
number,
4343
},
4444
(None, None, None, None, None) => BuildSource::Main {
45-
repo: DEFAULT_REPO_PRIVATE.to_string(),
45+
repo: DEFAULT_REPO.to_string(),
4646
},
4747
_ => unreachable!("Clap should prevent conflicting options"),
4848
};

ampup/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,5 @@ pub mod ui;
1414
/// Default GitHub repository for amp releases
1515
pub const DEFAULT_REPO: &str = "edgeandnode/amp";
1616

17-
/// Default GitHub repository for amp development
18-
pub const DEFAULT_REPO_PRIVATE: &str = "edgeandnode/amp-private";
19-
2017
#[cfg(test)]
2118
mod tests;

0 commit comments

Comments
 (0)