Skip to content

Commit 495d889

Browse files
committed
Require node v26 for GROWABLE_ARRAYBUFFERS feature
Follow up #27103
1 parent 5b42d65 commit 495d889

3 files changed

Lines changed: 7 additions & 12 deletions

File tree

.circleci/config.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -971,6 +971,8 @@ jobs:
971971
other.test_js_optimizer_verbose
972972
other.test_file_packager_separate_metadata
973973
other.test_full_js_library*
974+
other.test_exceptions_stack_trace*
975+
other.test_exceptions_rethrow_stack_trace*
974976
core2.test_hello_world
975977
core2.test_fcntl_open_nodefs
976978
core2.test_fcntl_open_rawfs
@@ -1034,8 +1036,6 @@ jobs:
10341036
other.test_js_optimizer_verbose
10351037
other.test_min_node_version
10361038
other.test_node_emscripten_num_logical_cores
1037-
other.test_exceptions_stack_trace*
1038-
other.test_exceptions_rethrow_stack_trace*
10391039
core2.test_pthread_create
10401040
core2.test_i64_invoke_bigint
10411041
core2.test_sse2
@@ -1075,6 +1075,7 @@ jobs:
10751075
core0.test_pthread_wait_suspending*
10761076
core0.test_poll_blocking_asyncify_jspi
10771077
core0.test_promise_await*
1078+
core0.test_*exception*_wasm
10781079
"
10791080
- upload-test-results
10801081
test-other:

test/common.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -585,15 +585,14 @@ def require_wasm_legacy_eh(self):
585585

586586
def require_wasm_eh(self):
587587
if 'EMTEST_SKIP_WASM_EH' in os.environ:
588-
self.skipTest('test requires node v24 or d8 (and EMTEST_SKIP_WASM_EH is set)')
588+
self.skipTest('test requires node v26 or d8 (and EMTEST_SKIP_WASM_EH is set)')
589589
self.set_setting('WASM_LEGACY_EXCEPTIONS', 0)
590590

591591
if self.is_browser_test():
592592
self.check_browser_feature('EMTEST_SKIP_WASM_EH', Feature.WASM_EXCEPTIONS, 'test requires Wasm EH')
593593
return
594594

595-
if self.try_require_node_version(22):
596-
self.node_args.append('--experimental-wasm-exnref')
595+
if self.try_require_node_version(26):
597596
return
598597

599598
deno = get_deno()
@@ -610,10 +609,9 @@ def require_wasm_eh(self):
610609
if v8:
611610
self.cflags.append('-sENVIRONMENT=shell')
612611
self.require_engine(v8)
613-
self.v8_args.append('--experimental-wasm-exnref')
614612
return
615613

616-
self.fail('either d8, deno, bun or node v24 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip')
614+
self.fail('either d8, deno, bun or node v26 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip')
617615

618616
def require_jspi(self):
619617
if 'EMTEST_SKIP_JSPI' in os.environ:

tools/feature_matrix.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,7 @@ class Feature(IntEnum):
129129
'chrome': 137,
130130
'firefox': 131,
131131
'safari': 180400,
132-
# Supported with flag --experimental-wasm-exnref (TODO: Change this to
133-
# unflagged version of Node.js 260000 that ships Wasm EH enabled, after
134-
# Emscripten unit testing has migrated to Node.js 26, and Emsdk ships
135-
# Node.js 26)
136-
'node': 220000,
132+
'node': 260000,
137133
},
138134
# Growable SharedArrayBuffers improves memory growth feature in multithreaded
139135
# builds by avoiding need to poll resizes to ArrayBuffer views in Workers.

0 commit comments

Comments
 (0)