CI-168 accept deterministic transfer add items

Author: Threepwood-7

scripts/deterministic-two-client-transfer.py

@@ -920,8 +920,15 @@ def add_transfer(base_url: str, api_key: str, link: str, transfer_hash: str) ->
         json_body={"link": link, "paused": False, "categoryId": 0},
         request_timeout_seconds=30.0,
     )
-    item = rest_smoke.require_transfer_add_result(result, transfer_hash)
-    return {"response": rest_smoke.compact_http_result(result), "item": item}
+    summary = rest_smoke.compact_http_result(result)
+    payload = response_payload(result, 200)
+    rows = (payload.get("items") or payload.get("results")) if isinstance(payload, dict) else None
+    if not isinstance(rows, list) or not rows:
+        raise AssertionError(summary)
+    item = rows[0]
+    if not isinstance(item, dict) or item.get("ok") is not True or str(item.get("hash") or "").lower() != transfer_hash.lower():
+        raise AssertionError(summary)
+    return {"response": summary, "item": item}
 
 
 def read_preferences_snapshot(config_dir: Path) -> dict[str, object]:

tests/python/test_deterministic_two_client_transfer.py

@@ -1221,6 +1221,37 @@ def fake_wait_for(resolve, *_args):
     assert calls.count(("GET", "/api/v1/status")) == 2
 
 
+def test_add_transfer_accepts_bulk_items_response_without_contract_gate(monkeypatch) -> None:
+    module = load_suite_module()
+    expected_hash = "9eced47df2edfbd72f29f93447d60b7b"
+    item = {"hash": expected_hash.upper(), "name": "deterministic-two-client-transfer.bin", "ok": True}
+    response = {
+        "status": 200,
+        "content_type": "application/json; charset=utf-8",
+        "json": {"items": [item]},
+        "raw_json": {"data": {"items": [item]}, "meta": {"apiVersion": "v1"}},
+    }
+    calls: list[tuple[str, str, dict[str, object]]] = []
+
+    def fake_http_request(_base_url, path, *, method="GET", json_body=None, **_kwargs):
+        calls.append((method, path, dict(json_body or {})))
+        return response
+
+    monkeypatch.setattr(module.rest_smoke, "http_request", fake_http_request)
+    monkeypatch.setattr(module.rest_smoke, "compact_http_result", lambda result: {"status": result["status"], "json": result["json"]})
+
+    result = module.add_transfer("http://127.0.0.1:4711", "key", "ed2k://|file|a|1|9ECED47DF2EDFBD72F29F93447D60B7B|/", expected_hash)
+
+    assert result["item"] == item
+    assert calls == [
+        (
+            "POST",
+            "/api/v1/transfers",
+            {"link": "ed2k://|file|a|1|9ECED47DF2EDFBD72F29F93447D60B7B|/", "paused": False, "categoryId": 0},
+        )
+    ]
+
+
 def test_wait_for_completed_file_timeout_carries_diagnostic_observations(tmp_path: Path) -> None:
     module = load_suite_module()
     snapshots = [{"transfer": {"status": 200, "json": {"state": "downloading"}}}]