Skip to content

Commit a86b9ab

Browse files
committed
regression: scheduled task should not need approval
introduced in 9b2152d
1 parent 481fc2e commit a86b9ab

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/_photon-deploy-fanout.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ on:
2121
description: 'dev only | dev → tst → prd | tst → prd'
2222
required: true
2323
type: string
24+
require_approval:
25+
description: 'Require manual approval before tst and prd. Dev never requires approval.'
26+
required: false
27+
type: boolean
28+
default: true
2429
run_tests:
2530
required: false
2631
type: boolean
@@ -59,6 +64,7 @@ jobs:
5964
release_name: geocoder-photon${{ inputs.suffix }}
6065
values: values-kub-ent-tst${{ inputs.suffix }}.yaml
6166
photon_data_prefix: photon-data${{ inputs.suffix }}
67+
require_approval: ${{ inputs.require_approval }}
6268
run_tests: ${{ inputs.run_tests }}
6369
secrets: inherit
6470

@@ -77,5 +83,6 @@ jobs:
7783
release_name: geocoder-photon${{ inputs.suffix }}
7884
values: values-kub-ent-prd${{ inputs.suffix }}.yaml
7985
photon_data_prefix: photon-data${{ inputs.suffix }}
86+
require_approval: ${{ inputs.require_approval }}
8087
run_tests: ${{ inputs.run_tests }}
8188
secrets: inherit

.github/workflows/photon-scheduled.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ jobs:
8484
with:
8585
image: "geocoder-photon:${{ needs.photon.outputs.image_tag }}"
8686
target: 'tst → prd'
87+
require_approval: false
8788
secrets: inherit
8889

8990
notify-slack:

0 commit comments

Comments
 (0)