Don't handle server errors in Sinatra and remove prod testing

Author: epistrephein

app.rb

@@ -13,13 +13,6 @@ class Rubies < Sinatra::Base
     set :protection, except: [:json_csrf]
   end
 
-  configure :production do
-    set :raise_errors,    false
-    set :show_exceptions, false
-
-    set :static_cache_control, [:public, :must_revalidate, { max_age: 30672000 }]
-  end
-
   set :app_file,      __FILE__
   set :root,          File.dirname(settings.app_file)
   set :public_folder, File.join(settings.root, 'public')
@@ -57,11 +50,4 @@ class Rubies < Sinatra::Base
     @title = 'Rubies | 404'
     erb :not_found
   end
-
-  error do
-    halt if request.path_info =~ %r{^/api/}
-
-    @title = 'Rubies | Error'
-    erb :error
-  end
 end

spec/app_spec.rb

@@ -36,19 +36,6 @@
         expect(html).to include("The page you're looking for doesn't exist")
       end
     end
-
-    describe 'server error' do
-      let(:endpoint) { '/' }
-
-      it 'returns an error page' do
-        allow(REDIS).to receive(:lrange).and_raise(StandardError)
-
-        get endpoint
-
-        expect(last_response.status).to eq(500)
-        expect(html).to include('Something went wrong on our end.')
-      end
-    end
   end
 
   context 'JSON API' do
@@ -141,17 +128,5 @@
         expect(last_response.status).to eq(404)
       end
     end
-
-    describe 'server error' do
-      let(:endpoint) { '/api/normal' }
-
-      it 'returns status 500' do
-        allow(REDIS).to receive(:exists?).and_raise(StandardError)
-
-        get endpoint
-
-        expect(last_response.status).to eq(500)
-      end
-    end
   end
 end

spec/spec_helper.rb

@@ -2,15 +2,14 @@
 
 require 'bundler/setup'
 
-# Set RACK_ENV to production to test error handling in production mode
-ENV['RACK_ENV'] = 'production'
+ENV['RACK_ENV'] ||= 'test'
 
-require 'simplecov'
-SimpleCov.start
-
-require 'mock_redis'
 require 'rack/test'
+require 'mock_redis'
 require 'webmock/rspec'
+require 'simplecov'
+
+SimpleCov.start
 
 MOCKREDIS = MockRedis.new