clippy

Author: estk

benches/rotation.rs

@@ -141,8 +141,8 @@ impl Stats {
         let mut anomalies = vec![];
         let thresh = self.mean_nanos + ((self.stddev_nanos * 50.0).round() as u128);
         for dur in measurements {
-            if dur.as_nanos() as u128 > thresh {
-                anomalies.push(dur.clone());
+            if dur.as_nanos() > thresh {
+                anomalies.push(*dur);
             }
         }
         anomalies

src/append/file.rs

@@ -327,7 +327,7 @@ mod test {
             .unwrap();
 
         // Only MAX_REPLACEMENTS should be replaced, the rest should remain as $TIME{...}
-        let mut expected_path = format!("foo/bar/logs/log");
+        let mut expected_path = "foo/bar/logs/log".to_string();
         for i in 0..10 {
             if i < MAX_REPLACEMENTS {
                 expected_path.push_str(&format!("-{}", current_time));

src/append/rolling_file/policy/compound/roll/fixed_window.rs

@@ -471,7 +471,7 @@ mod test {
         wait_for_roller(&roller);
         assert!(!file.exists());
         contents.clear();
-        File::open(dir.path().join(&format!("{}.{}", fname, base + 1)))
+        File::open(dir.path().join(format!("{}.{}", fname, base + 1)))
             .unwrap()
             .read_to_end(&mut contents)
             .unwrap();

src/append/rolling_file/policy/compound/trigger/time.rs

@@ -444,7 +444,7 @@ mod test {
     #[test]
     #[cfg(feature = "yaml_format")]
     fn test_serde() {
-        let test_error = vec![
+        let test_error = [
             "abc",   // // str none none
             "",      // none
             "5 das", // bad unit
@@ -453,7 +453,7 @@ mod test {
         ];
 
         for interval in test_error.iter() {
-            let error = ::serde_yaml::from_str::<TimeTriggerInterval>(&interval);
+            let error = ::serde_yaml::from_str::<TimeTriggerInterval>(interval);
             assert!(error.is_err());
         }
 
@@ -483,7 +483,7 @@ mod test {
             ("1 years", TimeTriggerInterval::Year(1)),
         ];
         for (interval, expected) in test_ok.iter() {
-            let interval = format!("{}", interval);
+            let interval = interval.to_string();
             let interval = ::serde_yaml::from_str::<TimeTriggerInterval>(&interval).unwrap();
             assert_eq!(interval, *expected);
         }

src/encode/mod.rs

@@ -147,7 +147,7 @@ pub trait Write: io::Write {
     }
 }
 
-impl<'a, W: Write + ?Sized> Write for &'a mut W {
+impl<W: Write + ?Sized> Write for &mut W {
     fn set_style(&mut self, style: &Style) -> io::Result<()> {
         <W as Write>::set_style(*self, style)
     }

src/encode/pattern/mod.rs

@@ -41,50 +41,50 @@
 //! a formatter does not accept any argument.
 //!
 //! * `d`, `date` - The current time. By default, the ISO 8601 format is used.
-//!     A custom format may be provided in the syntax accepted by `chrono`.
-//!     The timezone defaults to local, but can be specified explicitly by
-//!     passing a second argument of `utc` for UTC or `local` for local time.
-//!     * `{d}` - `2016-03-20T14:22:20.644420340-08:00`
-//!     * `{d(%Y-%m-%d %H:%M:%S)}` - `2016-03-20 14:22:20`
-//!     * `{d(%Y-%m-%d %H:%M:%S %Z)(utc)}` - `2016-03-20 22:22:20 UTC`
+//!   A custom format may be provided in the syntax accepted by `chrono`.
+//!   The timezone defaults to local, but can be specified explicitly by
+//!   passing a second argument of `utc` for UTC or `local` for local time.
+//!   * `{d}` - `2016-03-20T14:22:20.644420340-08:00`
+//!   * `{d(%Y-%m-%d %H:%M:%S)}` - `2016-03-20 14:22:20`
+//!   * `{d(%Y-%m-%d %H:%M:%S %Z)(utc)}` - `2016-03-20 22:22:20 UTC`
 //! * `f`, `file` - The source file that the log message came from, or `???` if
-//!     not provided.
+//!   not provided.
 //! * `h`, `highlight` - Styles its argument according to the log level. The
-//!     style is intense red for errors, red for warnings, blue for info, and
-//!     the default style for all other levels.
-//!     * `{h(the level is {l})}` -
-//!         <code style="color: red; font-weight: bold">the level is ERROR</code>
+//!   style is intense red for errors, red for warnings, blue for info, and
+//!   the default style for all other levels.
+//!   * `{h(the level is {l})}` -
+//!     <code style="color: red; font-weight: bold">the level is ERROR</code>
 //! * `D`, `debug` - Outputs its arguments ONLY in debug build.
 //! * `R`, `release` - Outputs its arguments ONLY in release build.
 //! * `l`, `level` - The log level.
 //! * `L`, `line` - The line that the log message came from, or `???` if not
-//!     provided.
+//!   provided.
 //! * `m`, `message` - The log message.
 //! * `M`, `module` - The module that the log message came from, or `???` if not
-//!     provided.
+//!   provided.
 //! * `P`, `pid` - The current process id.
 //! * `i`, `tid` - The current system-wide unique thread ID.
 //! * `n` - A platform-specific newline.
 //! * `t`, `target` - The target of the log message.
 //! * `T`, `thread` - The name of the current thread.
 //! * `I`, `thread_id` - The pthread ID of the current thread.
 //! * `X`, `mdc` - A value from the [MDC][MDC]. The first argument specifies
-//!     the key, and the second argument specifies the default value if the
-//!     key is not present in the MDC. The second argument is optional, and
-//!     defaults to the empty string.
+//!   the key, and the second argument specifies the default value if the
+//!   key is not present in the MDC. The second argument is optional, and
+//!   defaults to the empty string.
 //!     * `{X(user_id)}` - `123e4567-e89b-12d3-a456-426655440000`
 //!     * `{X(nonexistent_key)(no mapping)}` - `no mapping`
 //! * `K`, `key_value` - A value from a [log::kv][log_kv] structured logging
-//!     record attributes. The first argument specifies the key, and the second
-//!     argument specifies the default value if the key is not present in the
-//!     log record's attributes. The second argument is optional, and defaults
-//!     to the empty string. This formatter requires the `log_kv` feature to be
-//!     enabled.
-//!     * `{K(user_id)}` - `123e4567-e89b-12d3-a456-426655440000`
-//!     * `{K(nonexistent_key)(no mapping)}` - `no mapping`
+//!   record attributes. The first argument specifies the key, and the second
+//!   argument specifies the default value if the key is not present in the
+//!   log record's attributes. The second argument is optional, and defaults
+//!   to the empty string. This formatter requires the `log_kv` feature to be
+//!   enabled.
+//!   * `{K(user_id)}` - `123e4567-e89b-12d3-a456-426655440000`
+//!   * `{K(nonexistent_key)(no mapping)}` - `no mapping`
 //! * An "unnamed" formatter simply formats its argument, applying the format
-//!     specification.
-//!     * `{({l} {m})}` - `INFO hello`
+//!   specification.
+//!   * `{({l} {m})}` - `INFO hello`
 //!
 //! # Format Specification
 //!
@@ -101,7 +101,7 @@
 //!
 //! * `<` - Left align by appending the fill character to the formatter output
 //! * `>` - Right align by prepending the fill character to the formatter
-//!     output.
+//!   output.
 //!
 //! ## Width
 //!
@@ -183,7 +183,7 @@ enum Chunk {
 }
 
 impl Chunk {
-    fn encode(&self, w: &mut dyn encode::Write, record: &Record<'_> ) -> io::Result<()> {
+    fn encode(&self, w: &mut dyn encode::Write, record: &Record<'_>) -> io::Result<()> {
         match *self {
             Chunk::Text(ref s) => w.write_all(s.as_bytes()),
             Chunk::Formatted {
@@ -546,7 +546,7 @@ fn no_args(arg: &[Vec<Piece<'_>>], params: Parameters, chunk: FormattedChunk) ->
     }
 }
 
-fn kv_parsing<'a>(formatter: &'a Formatter<'_> ) -> Result<(String, String), &'a str> {
+fn kv_parsing<'a>(formatter: &'a Formatter<'_>) -> Result<(String, String), &'a str> {
     if formatter.args.len() > 2 {
         return Err("expected at most two arguments");
     }
@@ -613,7 +613,7 @@ enum FormattedChunk {
 }
 
 impl FormattedChunk {
-    fn encode(&self, w: &mut dyn encode::Write, record: &Record<'_> ) -> io::Result<()> {
+    fn encode(&self, w: &mut dyn encode::Write, record: &Record<'_>) -> io::Result<()> {
         match *self {
             FormattedChunk::Time(ref fmt, Timezone::Utc) => write!(w, "{}", Utc::now().format(fmt)),
             FormattedChunk::Time(ref fmt, Timezone::Local) => {
@@ -718,7 +718,7 @@ impl Default for PatternEncoder {
 }
 
 impl Encode for PatternEncoder {
-    fn encode(&self, w: &mut dyn encode::Write, record: &Record<'_> ) -> anyhow::Result<()> {
+    fn encode(&self, w: &mut dyn encode::Write, record: &Record<'_>) -> anyhow::Result<()> {
         for chunk in &self.chunks {
             chunk.encode(w, record)?;
         }
@@ -790,10 +790,10 @@ mod tests {
     use crate::encode::Encode;
 
     fn error_free(encoder: &PatternEncoder) -> bool {
-        encoder.chunks.iter().all(|c| match *c {
-            Chunk::Error(_) => false,
-            _ => true,
-        })
+        encoder
+            .chunks
+            .iter()
+            .all(|c| !matches!(*c, Chunk::Error(_)))
     }
 
     #[test]

tests/color_control.rs

@@ -2,7 +2,7 @@ use std::process::Command;
 
 fn execute_test(env_key: &str, env_val: &str) {
     let mut child_proc = Command::new("cargo")
-        .args(&["run", "--example", "compile_time_config"])
+        .args(["run", "--example", "compile_time_config"])
         .env(env_key, env_val)
         .spawn()
         .expect("Cargo command failed to start");