Skip to content

Commit 7ca6796

Browse files
claudesebastianst
andcommitted
merge: claude/lokahi-22544-supernode-rpc at b18fa0b (CrossUnsafeL2 test fix)
Develop's #22555 removed CrossUnsafeL2 from eth.SyncStatus; the updated query branch drops the zero-assertion on it, and this line already carries that test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co> Claude-Session: https://claude.ai/code/session_01WEDeDWcHt2X1mZYhvHmnZ5
2 parents 39137dc + b18fa0b commit 7ca6796

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

op-devstack/sysgo/lokahi_supernode_query_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ func TestLokahiSyncStatusDecodesIntoGoTypes(t *testing.T) {
6868
require.Equal(t, uint64(3), a.LocalSafeL2.SequenceNumber, "l2 refs carry their seq number")
6969
require.Equal(t, uint64(898), a.LocalSafeL2.L1Origin.Number, "l1origin decodes")
7070

71-
// Two fields of eth.SyncStatus have no counterpart in kona's, so they decode as zero. That
71+
// One field of eth.SyncStatus has no counterpart in kona's, so it decodes as zero. That
7272
// is the same thing a Go consumer sees reading a kona-node's own optimism_syncStatus, and it
73-
// is recorded here so a future consumer that starts depending on them finds this test rather
74-
// than a silent zero.
73+
// is recorded here so a future consumer that starts depending on it finds this test rather
74+
// than a silent zero. (CrossUnsafeL2 used to be asserted the same way, until #22555 removed
75+
// the cross-unsafe chain-head notion from eth.SyncStatus itself.)
7576
require.Zero(t, a.PendingSafeL2.Number, "kona tracks no pending-safe head")
76-
require.Zero(t, a.CrossUnsafeL2.Number, "kona tracks no cross-unsafe head")
7777
}
7878

7979
// TestLokahiSuperRootDecodesIntoGoTypes checks the superroot_atTimestamp response, and

0 commit comments

Comments
 (0)