Skip to content

Commit b6232d7

Browse files
claudesebastianst
andcommitted
merge: claude/lokahi-22546-acceptance-matrix at c1c5ae2 (stack-bottom develop merge)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co> Claude-Session: https://claude.ai/code/session_01WEDeDWcHt2X1mZYhvHmnZ5
2 parents 72ffe3e + c1c5ae2 commit b6232d7

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

rust/kona/crates/node/service/src/actors/chain_controller/controller_test.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ use crate::{
77
use alloy_eips::BlockNumHash;
88
use alloy_primitives::B256;
99
use kona_engine::{
10-
Engine, EngineState, EngineSyncStateUpdate, LocalSafeHead, test_utils::MockEngineClient,
10+
Engine, EngineState, EngineSyncStateUpdate, LocalSafeHead, NoopBlockSink,
11+
test_utils::MockEngineClient,
1112
};
1213
use kona_genesis::RollupConfig;
1314
use kona_protocol::{BlockInfo, L2BlockInfo};
@@ -80,7 +81,7 @@ async fn lockstep_confirmation_carries_local_safe_not_cross_safe() {
8081
None,
8182
request_rx,
8283
Arc::new(DisabledDatabase),
83-
Arc::new(kona_engine::NoopBlockSink),
84+
Arc::new(NoopBlockSink),
8485
);
8586

8687
// The actor drains, pushes the confirmation, then waits for a request; closing the channel

rust/kona/crates/protocol/interop/src/rules.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,16 @@ impl<'a> MessageRules<'a> {
105105

106106
/// Message expiry invariant: the initiating message must be no more than the configured
107107
/// message expiry window (in seconds) in the past, relative to the executing message.
108+
///
109+
/// Stated as the subtraction develop's #22609 restated it as: message ordering has already
110+
/// guaranteed `executing >= initiating`, so the gap itself is checked against the window, and
111+
/// a message executed exactly at the window boundary is still valid.
108112
pub fn check_message_expiry<E: Debug>(
109113
&self,
110114
initiating_timestamp: u64,
111115
executing_timestamp: u64,
112116
) -> Result<(), MessageGraphError<E>> {
113-
(initiating_timestamp >= executing_timestamp.saturating_sub(self.message_expiry_window))
117+
(executing_timestamp - initiating_timestamp <= self.message_expiry_window)
114118
.then_some(())
115119
.ok_or(MessageGraphError::MessageExpired { initiating_timestamp, executing_timestamp })
116120
}

0 commit comments

Comments
 (0)