make overlap respect order or argument

Author: brianz98

forte/helpers/math_structures.h

@@ -284,11 +284,16 @@ class VectorSpace {
     /// @brief Calculate the dot product of two vectors
     F dot(const Derived& other) const {
         F result{0};
+        bool self_smaller = size() < other.size();
         const auto& smaller = size() < other.size() ? elements() : other.elements();
         const auto& larger = size() < other.size() ? other.elements() : elements();
         for (const auto& [e, c] : smaller) {
             if (const auto it = larger.find(e); it != larger.end()) {
-                result += conjugate(c) * it->second;
+                if (self_smaller) {
+                    result += conjugate(c) * it->second;
+                } else {
+                    result += c * conjugate(it->second);
+                }
             }
         }
         return result;