Does not build on Fedora 42

[derfsubterfuge]

TL;DR
ModuleNotFoundError: No module named 'pipes' on ./getdeps.sh

Full log:

derfsubterfuge@castorina:/tmp/tmp.8JtzjwLTPC$ git clone https://github.com/facebook/mvfst.git
Cloning into 'mvfst'...
remote: Enumerating objects: 78750, done.
remote: Counting objects: 100% (2142/2142), done.
remote: Compressing objects: 100% (395/395), done.
remote: Total 78750 (delta 1804), reused 1931 (delta 1689), pack-reused 76608 (from 3)
Receiving objects: 100% (78750/78750), 21.97 MiB | 20.46 MiB/s, done.
Resolving deltas: 100% (37496/37496), done.
derfsubterfuge@castorina:/tmp/tmp.8JtzjwLTPC$ cd mvfst
derfsubterfuge@castorina:/tmp/tmp.8JtzjwLTPC/mvfst$ sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive --install-prefix=$(pwd)/_build mvfst
---
+ sudo \
+      dnf \
+      install \
+      -y \
+      --skip-broken \
+      autoconf \
+      automake \
+      binutils \
+      binutils-devel \
+      boost-devel \
+      boost-static \
+      cmake \
+      double-conversion \
+      double-conversion-devel \
+      fast_float-devel \
+      fmt-devel \
+      gflags-devel \
+      glog-devel \
+      gmock-devel \
+      gtest-devel \
+      libdwarf \
+      libdwarf-devel \
+      libevent-devel \
+      libsodium-devel \
+      libsodium-static \
+      libtool \
+      libunwind \
+      libunwind-devel \
+      libzstd \
+      libzstd-devel \
+      lz4-devel \
+      lz4-static \
+      ninja-build \
+      openssl \
+      openssl-devel \
+      openssl-libs \
+      snappy-devel \
+      xz-devel \
+      zlib-ng-compat-devel \
+      zlib-ng-compat-static
Updating and loading repositories:
Repositories loaded.
Package "autoconf-2.72-5.fc42.noarch" is already installed.
Package "automake-1.17-2.fc42.noarch" is already installed.
Package "binutils-2.44-3.fc42.x86_64" is already installed.
Package "binutils-devel-2.44-3.fc42.x86_64" is already installed.
Package "boost-devel-1.83.0-12.fc42.x86_64" is already installed.
Package "boost-static-1.83.0-12.fc42.x86_64" is already installed.
Package "cmake-3.31.6-2.fc42.x86_64" is already installed.
Package "double-conversion-3.3.1-1.fc42.x86_64" is already installed.
Package "double-conversion-devel-3.3.1-1.fc42.x86_64" is already installed.
Package "fast_float-devel-8.0.1-1.fc42.noarch" is already installed.
Package "fmt-devel-11.1.4-1.fc42.x86_64" is already installed.
Package "gflags-devel-2.2.2-17.fc42.x86_64" is already installed.
Package "glog-devel-0.3.5-23.fc42.x86_64" is already installed.
Package "gmock-devel-1.15.2-3.fc42.x86_64" is already installed.
Package "gtest-devel-1.15.2-3.fc42.x86_64" is already installed.
Package "libdwarf-1:0.11.1-3.fc42.x86_64" is already installed.
Package "libdwarf-devel-1:0.11.1-3.fc42.x86_64" is already installed.
Package "libevent-devel-2.1.12-15.fc42.x86_64" is already installed.
Package "libsodium-devel-1.0.20-4.fc42.x86_64" is already installed.
Package "libsodium-static-1.0.20-4.fc42.x86_64" is already installed.
Package "libtool-2.5.4-4.fc42.x86_64" is already installed.
Package "libunwind-1.8.1-2.fc42.x86_64" is already installed.
Package "libunwind-devel-1.8.1-2.fc42.x86_64" is already installed.
Package "libzstd-1.5.7-1.fc42.x86_64" is already installed.
Package "libzstd-1.5.7-1.fc42.i686" is already installed.
Package "libzstd-devel-1.5.7-1.fc42.x86_64" is already installed.
Package "lz4-devel-1.10.0-2.fc42.x86_64" is already installed.
Package "lz4-static-1.10.0-2.fc42.x86_64" is already installed.
Package "ninja-build-1.12.1-4.fc42.x86_64" is already installed.
Package "openssl-1:3.2.4-3.fc42.x86_64" is already installed.
Package "openssl-devel-1:3.2.4-3.fc42.x86_64" is already installed.
Package "openssl-libs-1:3.2.4-3.fc42.x86_64" is already installed.
Package "snappy-devel-1.2.1-4.fc42.x86_64" is already installed.
Package "xz-devel-1:5.8.1-2.fc42.x86_64" is already installed.
Package "zlib-ng-compat-devel-2.2.4-3.fc42.x86_64" is already installed.
Package "zlib-ng-compat-static-2.2.4-3.fc42.x86_64" is already installed.

Nothing to do.
derfsubterfuge@castorina:/tmp/tmp.8JtzjwLTPC/mvfst$ ./getdeps.sh
+ TOOLCHAIN_DIR=/opt/rh/devtoolset-8/root/usr/bin
+ [[ -d /opt/rh/devtoolset-8/root/usr/bin ]]
++ dirname ./getdeps.sh
+ PROJECT_DIR=.
+ GETDEPS_PATHS=("$PROJECT_DIR/build/fbcode_builder/getdeps.py" "$PROJECT_DIR/../../opensource/fbcode_builder/getdeps.py")
++ pwd
+ ROOT_DIR=/tmp/tmp.8JtzjwLTPC/mvfst
+ STAGE=/tmp/tmp.8JtzjwLTPC/mvfst/_build/
+ mkdir -p /tmp/tmp.8JtzjwLTPC/mvfst/_build/
+ for getdeps in "${GETDEPS_PATHS[@]}"
+ [[ -x ./build/fbcode_builder/getdeps.py ]]
+ ./build/fbcode_builder/getdeps.py build mvfst --current-project mvfst --install-prefix=/tmp/tmp.8JtzjwLTPC/mvfst/_build/
Building on {distro=fedora, distro_vers=42, fb=off, fbsource=off, os=linux, shared_libs=off, test=on}
Assessing ninja...
Building ninja...
---
+ cd /tmp/fbcode_builder_getdeps-ZtmpZtmp.8JtzjwLTPCZmvfstZbuildZfbcode_builder/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \
+ /usr/bin/python3 \
+      configure.py \
+      --bootstrap
Traceback (most recent call last):
  File "/tmp/fbcode_builder_getdeps-ZtmpZtmp.8JtzjwLTPCZmvfstZbuildZfbcode_builder/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module>
    import pipes
ModuleNotFoundError: No module named 'pipes'
Command '['/usr/bin/python3', 'configure.py', '--bootstrap']' returned non-zero exit status 1.
!! Failed

[mszabo-wikia]

The error seems to be from ninja's configure.py, so this should probably go away if you run getdeps.py with --allow-system-packages.

[derfsubterfuge]

Running ./getdeps.sh --allow-system-packages gets farther, but still fails:

...
[5/350] Building CXX object quic/codec/CMakeFiles/mvfst_codec_types.dir/QuicConnectionId.cpp.o
FAILED: quic/codec/CMakeFiles/mvfst_codec_types.dir/QuicConnectionId.cpp.o 
/usr/bin/c++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -I/tmp/tmp.ZpoKi16kLg/mvfst -isystem /usr/include/libdwarf-0 -isystem /tmp/tmp.ZpoKi16kLg/mvfst/_build/folly/include -isystem /tmp/tmp.ZpoKi16kLg/mvfst/_build/fizz/include -O2 -g -DNDEBUG -std=c++17 -Wall -Wextra -Woverloaded-virtual -Wnon-virtual-dtor -Wtype-limits -Wunused-value -MD -MT quic/codec/CMakeFiles/mvfst_codec_types.dir/QuicConnectionId.cpp.o -MF quic/codec/CMakeFiles/mvfst_codec_types.dir/QuicConnectionId.cpp.o.d -o quic/codec/CMakeFiles/mvfst_codec_types.dir/QuicConnectionId.cpp.o -c /tmp/tmp.ZpoKi16kLg/mvfst/quic/codec/QuicConnectionId.cpp
In file included from /tmp/tmp.ZpoKi16kLg/mvfst/quic/common/Optional.h:12,
                 from /tmp/tmp.ZpoKi16kLg/mvfst/quic/codec/QuicConnectionId.h:10,
                 from /tmp/tmp.ZpoKi16kLg/mvfst/quic/codec/QuicConnectionId.cpp:8:
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h: In member function ‘quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() &’:
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h:1591:14: error: ‘abort’ is not a member of ‘std’ [-Wtemplate-body]
 1591 |         std::abort();
      |              ^~~~~
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h: In member function ‘const quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() const &’:
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h:1600:14: error: ‘abort’ is not a member of ‘std’ [-Wtemplate-body]
 1600 |         std::abort();
      |              ^~~~~
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h: In member function ‘quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType&& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() &&’:
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h:1609:14: error: ‘abort’ is not a member of ‘std’ [-Wtemplate-body]
 1609 |         std::abort();
      |              ^~~~~
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h: In member function ‘const quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType&& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() const &&’:
/tmp/tmp.ZpoKi16kLg/mvfst/quic/common/third-party/optional.h:1618:14: error: ‘abort’ is not a member of ‘std’ [-Wtemplate-body]
 1618 |         std::abort();
      |              ^~~~~
[24/350] Building CXX object quic/codec/CMakeFiles/mvfst_codec_decode.dir/Decode.cpp.o
ninja: build stopped: subcommand failed.
Command '['/usr/bin/cmake', '--build', '/tmp/fbcode_builder_getdeps-ZtmpZtmp.zZpoKi16kLgZmvfstZbuildZfbcode_builder/build/mvfst', '--target', 'install', '--config', 'RelWithDebInfo', '-j', '20']' returned non-zero exit status 1.
!! Failed

[mszabo-wikia]

That one needs the patch from #394 if building with gcc / libstdc++.