feat: add ennobling conjured items

Author: fhuitelec

src/gilded_rose/inn.py

@@ -19,23 +19,23 @@ class Item:  # pylint: disable=too-few-public-methods
     @property
     def _ennobling(self):
         """Returns whether the item ennobles over time."""
-        return self.name == AGED_BRIE
+        return self.name.endswith(AGED_BRIE)
 
     @property
     def _legendary(self):
         """Returns whether the item is legendary or not."""
-        return self.name == SULFURAS
+        return self.name.endswith(SULFURAS)
+
+    @property
+    def _backstage_passes(self):
+        """Returns whether the item is a backstage pass or not."""
+        return self.name.endswith(BACKSTAGE_PASSES)
 
     @property
     def _conjured(self):
         """Returns whether the item is a conjured item or not."""
         return self.name.startswith(CONJURED_PREFIX)
 
-    @property
-    def _backstage_passes(self):
-        """Returns whether the item is a backstage pass or not."""
-        return self.name == BACKSTAGE_PASSES
-
     def compute_after_a_day(self) -> "Item":
         """Compute the state of the item after a day."""
         quality_variation = 1 if self.sell_in > 0 else 2
@@ -45,7 +45,7 @@ def compute_after_a_day(self) -> "Item":
         sell_in = self.sell_in - 1
 
         if self._ennobling:
-            quality = min(50, self.quality + quality_variation)
+            quality = min(50, self.quality + quality_variation * quality_multiplier)
 
         if self._legendary:
             quality = 80

tests/builder.py

@@ -3,7 +3,7 @@
 from dataclasses import dataclass
 from typing import Self
 
-from gilded_rose.inn import AGED_BRIE, BACKSTAGE_PASSES, SULFURAS, Item
+from gilded_rose.inn import AGED_BRIE, BACKSTAGE_PASSES, CONJURED_PREFIX, SULFURAS, Item
 
 
 @dataclass
@@ -15,22 +15,29 @@ class ItemBuilder:
     _is_backstage_passes: bool = False
     _sell_in_date: int = 4
     _quality: int = 5
+    _conjured: bool = False
 
     def _name(self) -> str:
         """Compute the item's name depending on its characteristics."""
+        prefix = CONJURED_PREFIX if self._conjured else ""
         if self._ennobles:
-            return AGED_BRIE
+            return prefix + AGED_BRIE
         if self._is_legendary:
-            return SULFURAS
+            return prefix + SULFURAS
         if self._is_backstage_passes:
-            return BACKSTAGE_PASSES
-        return "foo"
+            return prefix + BACKSTAGE_PASSES
+        return prefix + "foo"
 
     def with_quality(self, quality: int) -> Self:
         """Add a specific quality to the item to build."""
         self._quality = quality
         return self
 
+    def conjured(self) -> Self:
+        """Mark the item to build as a conjured item."""
+        self._conjured = True
+        return self
+
     def expired(self) -> Self:
         """Mark the item as expired."""
         self._sell_in_date = 0

tests/test_inn.py

@@ -3,8 +3,6 @@
 from gilded_rose.inn import GildedRose, Item
 from tests.builder import an_item
 
-AGED_BRIE = "Aged Brie"
-
 
 def test_quality_degrades_over_time():
     """Test that the quality of an item decreases over time."""
@@ -60,7 +58,7 @@ def test_quality_cannot_get_negative():
 def test_aged_brie_ennobles_quality_over_time():
     """Test that the quality of Aged Brie increases over time."""
     # Arrange
-    items = [Item(AGED_BRIE, sell_in=10, quality=20)]
+    items = [an_item().ennobling().sell_in(10).with_quality(20).build()]
     gilded_rose = GildedRose(items)
 
     # Act
@@ -178,11 +176,37 @@ def test_conjured_items_degrade_twice_as_fast():
 def test_conjured_items_degrade_4_times_as_fast_after_sell_in_date_is_passed():
     """Test that the quality of conjured items degrades four times as fast after the sell-in date."""
     # Arrange
-    items = [Item("Conjured Mana Cake", sell_in=0, quality=6)]
+    items = [an_item().conjured().expired().with_quality(6).build()]
     gilded_rose = GildedRose(items)
 
     # Act
     gilded_rose.update_quality()
 
     # Assert
     assert gilded_rose.items[0].quality == 2
+
+
+def test_conjured_ennobling_items_ennobles_twice_as_fast():
+    """Test that conjured ennobling items increase quality twice as fast."""
+    # Arrange
+    items = [an_item().conjured().ennobling().sell_in(10).with_quality(20).build()]
+    gilded_rose = GildedRose(items)
+
+    # Act
+    gilded_rose.update_quality()
+
+    # Assert
+    assert gilded_rose.items[0].quality == 22
+
+
+def test_conjured_ennobling_items_ennobles_four_times_as_fast_after_sell_in_date_is_passed():
+    """Test that conjured ennobling items increase quality four times as fast after the sell-in date."""
+    # Arrange
+    items = [an_item().conjured().ennobling().expired().with_quality(20).build()]
+    gilded_rose = GildedRose(items)
+
+    # Act
+    gilded_rose.update_quality()
+
+    # Assert
+    assert gilded_rose.items[0].quality == 24