Merge pull request #14 from progamernoob/main

Added ability to use custom user attributes and macros, made the log less noisy

Author: filipnet

README.md

@@ -16,6 +16,7 @@ Telegram has long been one of my real-time communication media. It is obvious to
         - [ACTIVATE CHANGES](#activate-changes)
         - [PRIVACY ANONYMIZATION / MASQUERADING](#privacy-anonymization--masquerading)
     - [PAGER ADDRESS CHAT-ID INSTEAD OF TELEGRAM GROUP-ID](#pager-address-chat-id-instead-of-telegram-group-id)
+        - [Custom user attribute](#custom-user-attribute)
     - [TROUBLESHOOTING](#troubleshooting)
     - [CONTRIBUTIONS](#contributions)
     - [LICENSE](#license)
@@ -151,6 +152,27 @@ else
 fi
 ```
 
+### Custom user attribute
+You can add a custom user attribute and use it in your script.
+Go TO `Setup>UsersCustom>user attributes` and create a custom attribute named `TELEGRAMCHAT`, do not change the name, you can change the Title and Help Text.
+<img src="images/create_custom_user_attribute.PNG" alt="Custom User attribute creation" width="100%"/>
+
+#### Optional custom macro
+Go To `Setup>Events>Notification configuration>` and edit your notifcation. Add a custom macro.
+
+Regex : ```\d{5,}```
+
+The Macro checks for an at least 5 digit long number, if your Chatid differs, you can adjust that, this also ensures that only those with a chatid set up will get notified. (could work also as a whitelist)
+
+<img src="images/notification_custom_macro.PNG" alt="Custom macro for notification" width="100%"/>
+
+
+Edit your user and enter your Group/Chat-ID
+
+
+<img src="images/user_add_chat_id.PNG" alt="Custom macro for notification" width="100%"/>
+
+
 ## TROUBLESHOOTING
 For more details and troubleshooting with parameters please check:
 * Check_MK notification logfile: /omd/sites/{sitename}/var/log/notify.log

check_mk_telegram-notify.sh

@@ -6,7 +6,6 @@
 # Author        : https://github.com/filipnet/checkmk-telegram-notify
 # License       : BSD 3-Clause "New" or "Revised" License
 # ======================================================================================
-
 # Telegram API Token
 # Find telegram bot named "@botfather", type /mybots, select your bot and select "API Token" to see your current token
 if [ -z ${NOTIFY_PARAMETER_1} ]; then
@@ -19,8 +18,12 @@ fi
 # Telegram Chat-ID or Group-ID
 # Open "https://api.telegram.org/bot<YOUR_TOKEN>/getUpdates" inside your Browser and send a HELLO to your bot, refresh side
 if [ -z ${NOTIFY_PARAMETER_2} ]; then
-        echo "No Telegram Chat-ID or Group-ID provided. Exiting" >&2
-        exit 2
+        if [ -z ${NOTIFY_CONTACT_TELEGRAMCHAT} ]; then
+                echo "No Telegram Chat-ID or Group-ID provided. Exiting" >&2
+                exit 2
+        else
+                CHAT_ID="${NOTIFY_CONTACT_TELEGRAMCHAT}"
+        fi
 else
         CHAT_ID="${NOTIFY_PARAMETER_2}"
 fi
@@ -55,7 +58,9 @@ if [[ ${NOTIFY_PARAMETER_3} == "privacy" ]]; then
                 NOTIFY_HOST_ADDRESS_6="${sec1}:${sec2}:${sec3}:${sec4}:ffff:ffff:ffff:${sec8}"
         fi
 else
-        echo "Invalid privacy parameter, check your Check_MK settings." >&2
+        if [ ! -z ${NOTIFY_PARAMETER_3} ]; then
+                echo "Invalid privacy parameter, check your Check_MK settings." >&2
+        fi
 fi
 
 # Set an appropriate emoji for the current state
@@ -97,10 +102,11 @@ MESSAGE+="%0AIPv4: ${NOTIFY_HOST_ADDRESS_4} %0AIPv6: ${NOTIFY_HOST_ADDRESS_6}%0A
 MESSAGE+="${NOTIFY_SHORTDATETIME} | ${OMD_SITE}"
 
 # Send message to Telegram bot
-curl -S -X POST "https://api.telegram.org/bot${TOKEN}/sendMessage" -d chat_id="${CHAT_ID}" -d text="${MESSAGE}"
+response=$(curl -S -s -q -X POST "https://api.telegram.org/bot${TOKEN}/sendMessage" -d chat_id="${CHAT_ID}" -d text="${MESSAGE}")
 if [ $? -ne 0 ]; then
         echo "Not able to send Telegram message" >&2
+        echo $response >&2
         exit 2
 else
         exit 0
-fi
+fi