feat(fctl): lateral law improvements (#10607)

* fix(a380/hyd): aileron and spoiler to MSFS computation

* feat(a380x/fctl): roll/yaw law improvements, update lat. flight model

---------

Co-authored-by: donstim <70166617+donstim@users.noreply.github.com>
Co-authored-by: Chaoz <5833783+Maximilian-Reuter@users.noreply.github.com>

Author: 3 people

fbw-a380x/src/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/flight_model.cfg

@@ -534,11 +534,11 @@ Trigger.46 = Name:OuterTankRightEmpty#Condition:Manual#EffectTrue:StopPump.Right
 ;Trigger.46 = NameOuterTankRightEmpty#Target:RightOuter#Threshold:0.1#Condition:TankQuantityBelow
 ;
 ; Notes:
-; Inner and middle tank transfers to the feed tanks are done through the forward gallery via the forward inner and mid tank pumps, 
-; feed tank 1 and 4 forward transfer valve 2 and feed tank 2 and 3 forward transfer valves 2_1 using forward gallery junction 
+; Inner and middle tank transfers to the feed tanks are done through the forward gallery via the forward inner and mid tank pumps,
+; feed tank 1 and 4 forward transfer valve 2 and feed tank 2 and 3 forward transfer valves 2_1 using forward gallery junction
 ; option 2 and FeedTanks2_3 Junction 2 option 1 unless the combined left and right mid tanks have less than 8000 kg of fuel. Feed tanks 1 and 4
 ; transfers start and end at a lower feed tank fuel level than for 2 and 3 until the combined left and right mid tanks have less than 8000 kg of fuel.
-; Fuel levels for the symmetric pairs of feed tanks 1/4 and 2/3 are kept in balance by: the tank with less fuel will trigger a transfer first. When 
+; Fuel levels for the symmetric pairs of feed tanks 1/4 and 2/3 are kept in balance by: the tank with less fuel will trigger a transfer first. When
 ; the fuel levels for the two tanks are equal (the level for the higher tank will be decreasing because a transfer has not been triggered yet, while
 ; the level for the lower tank will be increasing due to the transfer), the transfer to the other tank (formerly higher) will begin. The transfers to
 ; feed tanks 1 and 4 end when either feed tank reaches the target end threshold, and the transfers to feed tanks 2 and 3 end when either of those
@@ -567,7 +567,7 @@ Trigger.46 = Name:OuterTankRightEmpty#Condition:Manual#EffectTrue:StopPump.Right
 ;
 ; Outer tank transfers are done through the forward gallery via the via the feed tank 1 and 4 forward transfer valve 1 and feed tanks 2 and 3
 ; forward transfer valves 1_1 using forward gallery junction option 1 and FeedTanks2_3 Junction 1 option 1. The transfers start for symmetric pairs
-; of the feed tanks (1/4 and 2/3) when one of the pair reaches the transfer start threshold. A transfer ends for each feed tank when it reaches the 
+; of the feed tanks (1/4 and 2/3) when one of the pair reaches the transfer start threshold. A transfer ends for each feed tank when it reaches the
 ; target end threshold. (The FCOM states that the transfers should end when both of the tanks in a symmetric pair reaches the threshold.)
 ;
 ; Feed tanks 2 and 3 forward transfer valves 1_2 and their corresponding lines are no longer used.
@@ -610,7 +610,7 @@ rudder_area = 416.6 ; Elevator area (SQUARE FEET)
 elevator_up_limit = 30 ; Elevator max deflection up angle (DEGREES)
 elevator_down_limit = 20 ; Elevator max deflection down angle (absolute value) (DEGREES)
 aileron_up_limit = 30; Aileron max deflection  angle (DEGREES)
-aileron_down_limit = 20; Aileron max deflection down angle (absolute value) (DEGREES)
+aileron_down_limit = 30; Aileron max deflection down angle (absolute value) (DEGREES)
 rudder_limit = 30; Rudder max deflection angle (absolute value) (DEGREES)
 rudder_trim_limit = 25.5 ; Rudder trim max deflection angle (absolute value) (DEGREES)
 elevator_trim_up_limit = 10 ; Elevator trim max angle (absolute value) (DEGREES)
@@ -751,14 +751,14 @@ induced_drag_scalar = 0.853
 flap_induced_drag_scalar = 0.35
 elevator_effectiveness = 1.3
 elevator_maxangle_scalar = 1
-aileron_effectiveness = 1
+aileron_effectiveness = 1.8
 rudder_effectiveness = 0.2
 rudder_maxangle_scalar = 1
 pitch_stability = 4
-roll_stability = 1
+roll_stability = 0.4
 yaw_stability = 1
 pitch_gyro_stability = 6
-roll_gyro_stability = 4.5
+roll_gyro_stability = 2.5
 yaw_gyro_stability = 1
 elevator_trim_effectiveness = 1.05
 aileron_trim_effectiveness = 1

fbw-a380x/src/wasm/fbw_a380/src/model/A380LateralDirectLaw.cpp

@@ -16,8 +16,6 @@ A380LateralDirectLaw::Parameters_A380LateralDirectLaw_T A380LateralDirectLaw::A3
 
   50.0,
 
-  0.0,
-
   -30.0,
 
   -30.0
@@ -47,22 +45,16 @@ void A380LateralDirectLaw::reset(void)
 }
 
 void A380LateralDirectLaw::step(const real_T *rtu_In_time_dt, const real_T *rtu_In_delta_xi_pos, const real_T
-  *rtu_In_delta_zeta_pos, real_T *rty_Out_xi_inboard_deg, real_T *rty_Out_xi_midboard_deg, real_T
-  *rty_Out_xi_outboard_deg, real_T *rty_Out_xi_spoiler_deg, real_T *rty_Out_zeta_upper_deg, real_T
-  *rty_Out_zeta_lower_deg)
+  *rtu_In_delta_zeta_pos, real_T *rty_Out_xi_deg, real_T *rty_Out_zeta_deg)
 {
-  *rty_Out_xi_spoiler_deg = A380LateralDirectLaw_rtP.Constant_Value;
   A380LateralDirectLaw_RateLimiter(A380LateralDirectLaw_rtP.Gain1_Gain * *rtu_In_delta_xi_pos,
     A380LateralDirectLaw_rtP.RateLimiterVariableTs_up, A380LateralDirectLaw_rtP.RateLimiterVariableTs_lo, rtu_In_time_dt,
-    A380LateralDirectLaw_rtP.RateLimiterVariableTs_InitialCondition, rty_Out_xi_outboard_deg,
+    A380LateralDirectLaw_rtP.RateLimiterVariableTs_InitialCondition, rty_Out_xi_deg,
     &A380LateralDirectLaw_DWork.sf_RateLimiter);
-  *rty_Out_xi_inboard_deg = *rty_Out_xi_outboard_deg;
-  *rty_Out_xi_midboard_deg = *rty_Out_xi_outboard_deg;
   A380LateralDirectLaw_RateLimiter(A380LateralDirectLaw_rtP.Gain2_Gain * *rtu_In_delta_zeta_pos,
     A380LateralDirectLaw_rtP.RateLimiterVariableTs1_up, A380LateralDirectLaw_rtP.RateLimiterVariableTs1_lo,
-    rtu_In_time_dt, A380LateralDirectLaw_rtP.RateLimiterVariableTs1_InitialCondition, rty_Out_zeta_lower_deg,
+    rtu_In_time_dt, A380LateralDirectLaw_rtP.RateLimiterVariableTs1_InitialCondition, rty_Out_zeta_deg,
     &A380LateralDirectLaw_DWork.sf_RateLimiter_n);
-  *rty_Out_zeta_upper_deg = *rty_Out_zeta_lower_deg;
 }
 
 A380LateralDirectLaw::A380LateralDirectLaw():

fbw-a380x/src/wasm/fbw_a380/src/model/A380LateralDirectLaw.h

@@ -24,7 +24,6 @@ class A380LateralDirectLaw final
     real_T RateLimiterVariableTs1_lo;
     real_T RateLimiterVariableTs_up;
     real_T RateLimiterVariableTs1_up;
-    real_T Constant_Value;
     real_T Gain1_Gain;
     real_T Gain2_Gain;
   };
@@ -34,8 +33,7 @@ class A380LateralDirectLaw final
   A380LateralDirectLaw(A380LateralDirectLaw &&) = delete;
   A380LateralDirectLaw& operator= (A380LateralDirectLaw &&) = delete;
   void step(const real_T *rtu_In_time_dt, const real_T *rtu_In_delta_xi_pos, const real_T *rtu_In_delta_zeta_pos, real_T
-            *rty_Out_xi_inboard_deg, real_T *rty_Out_xi_midboard_deg, real_T *rty_Out_xi_outboard_deg, real_T
-            *rty_Out_xi_spoiler_deg, real_T *rty_Out_zeta_upper_deg, real_T *rty_Out_zeta_lower_deg);
+            *rty_Out_xi_deg, real_T *rty_Out_zeta_deg);
   void reset();
   A380LateralDirectLaw();
   ~A380LateralDirectLaw();