Fix self-lint suggestions

Author: Numpsy

src/FSharpLint.Core/Framework/Ast.fs

@@ -322,16 +322,16 @@ module Ast =
         | SynExpr.Downcast(expression, synType, _) ->
             addMany [Type synType; Expression expression]
         // regular let or use
-        | SynExpr.LetOrUse letOrUse when letOrUse.IsBang = false ->
-            add <| Expression letOrUse.Body
-            List.revIter (Binding >> add) letOrUse.Bindings
+        | ExpressionUtilities.LetOrUse({Bindings = bindings; Body = body}, false, _) ->
+            add <| Expression body
+            List.revIter (Binding >> add) bindings
         // let! or use!
-        | SynExpr.LetOrUse  letOrUse when letOrUse.IsBang = true ->    //(_, _, _, true, bindings, leftHandSide, _, _) ->
-            match letOrUse.Bindings with
+        | ExpressionUtilities.LetOrUse({Bindings = bindings; Body = body}, true, _) ->
+            match bindings with
             | firstBinding :: andBangs ->
                 match firstBinding with
                 | SynBinding(headPat = pattern; expr = rightHandSide) ->
-                    addMany [Expression rightHandSide; Expression letOrUse.Body]
+                    addMany [Expression rightHandSide; Expression body]
                     List.iter (fun (SynBinding(headPat = pattern; expr = body)) ->
                         addMany [Expression body; Pattern pattern]
                     ) andBangs

src/FSharpLint.Core/Rules/Conventions/FavourNonMutablePropertyInitialization.fs

@@ -64,7 +64,7 @@ let rec private processLetBinding (instanceNames: Set<string>) (body: SynExpr) (
 and [<TailCall>] processExpression (expression: SynExpr) (continuation: unit -> array<WarningDetails>) : array<WarningDetails> =
     Array.append
         (match expression with
-        | SynExpr.LetOrUse letOrUse when letOrUse.IsBang = false ->
+        | SynExpr.LetOrUse letOrUse when not letOrUse.IsBang ->
             let instanceNames = extraFromBindings letOrUse.Bindings List.Empty |> Set.ofList
             processLetBinding instanceNames letOrUse.Body returnEmptyArray
         | SynExpr.Sequential(_, _, expr1, expr2, _, _) ->

src/FSharpLint.Core/Rules/Smells/AsyncExceptionWithoutReturn.fs

@@ -55,8 +55,8 @@ let rec checkExpression (expression: SynExpr) (range: range) (continuation: unit
                 }
         | SynExpr.App (_, _, funcExpr, _, innerRange) ->
             checkExpression funcExpr innerRange returnEmptyArray
-        | SynExpr.LetOrUse letOrUse when letOrUse.IsBang = false ->
-            checkExpression letOrUse.Body letOrUse.Range returnEmptyArray
+        | ExpressionUtilities.LetOrUse({Body = body; Range = innerRange}, false, _) ->
+            checkExpression body innerRange returnEmptyArray
         | _ -> Array.empty)
         (continuation ())
 and [<TailCall>] checkMultipleExpressions (expressions: list<SynExpr * range>) (continuation: unit -> array<WarningDetails>) =