Skip to content

Commit 2bfe27f

Browse files
authored
feature(sidebar): add icons to the sidebar (#16)
1 parent d7a47f0 commit 2bfe27f

5 files changed

Lines changed: 16 additions & 6 deletions

File tree

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "chrome-github-icons",
33
"description": "Cross-browser extension that replaces GitHub file icons with Material Design icons.",
44
"private": true,
5-
"version": "0.4.3",
5+
"version": "0.5.0",
66
"type": "module",
77
"scripts": {
88
"sync:assets": "tsx scripts/copy-icons.ts",

src/adapters/github/index.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,15 @@ export class GitHubAdapter implements SiteAdapter {
7777
return;
7878
}
7979

80+
// Remove orphaned replacement images in the same parent.
81+
// In the sidebar, React swaps between closed/open folder SVGs — the old
82+
// SVG is removed but our <img> replacement stays behind.
83+
const parent = originalIcon.parentElement;
84+
if (parent) {
85+
parent.querySelectorAll<HTMLImageElement>(`img[${REPLACEMENT_ATTR}="true"]`)
86+
.forEach((orphan) => orphan.remove());
87+
}
88+
8089
const replacement = this.createReplacementImage(originalIcon, iconUrl);
8190
originalIcon.insertAdjacentElement('afterend', replacement);
8291
}

src/adapters/github/selectors.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const GITHUB_NAME_SELECTOR_LIST = [
1717
'[data-testid="tree-view-item-name"]',
1818
'[aria-label$=", (Directory)"]',
1919
'[aria-label$=", (File)"]',
20+
'.PRIVATE_TreeView-item-content',
2021
'.react-directory-filename-column a',
2122
'a[data-testid="view-all-files-file-link"]',
2223
'.react-directory-filename-cell a',
@@ -29,9 +30,9 @@ export const GITHUB_ICON_SELECTOR = 'svg[class*="octicon-file"]';
2930

3031
const GITHUB_ENTRY_CONTAINER_SELECTOR = [
3132
'.react-directory-row',
32-
'[role="treeitem"]',
33+
'.PRIVATE_TreeView-item-container',
3334
'[data-testid="tree-view-item"]',
34-
'.PRIVATE_TreeView-item-content',
35+
'[role="treeitem"]',
3536
'tr.js-navigation-item',
3637
'li.js-navigation-item',
3738
'div[role="row"]',

ssmver.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version = "0.4.3"
1+
version = "0.5.0"
22

33
[settings]
44
mode = "branch"

0 commit comments

Comments
 (0)