handle varied crs gef when generating GeoJSON geometry

Author: tomkralidis

pygeometa/schemas/ogcapi_records/__init__.py

@@ -51,7 +51,7 @@
 from pygeometa.core import get_charstring
 from pygeometa.helpers import generate_datetime, json_dumps
 from pygeometa.schemas.base import BaseOutputSchema
-from pygeometa.schemas.util import generate_geometry
+from pygeometa.schemas.util import generate_geojson_geometry
 
 THISDIR = os.path.dirname(os.path.realpath(__file__))
 
@@ -87,7 +87,7 @@ def write(self, mcf: dict, stringify: str = True) -> Union[dict, str]:
         self.lang1 = mcf['metadata'].get('language')
         self.lang2 = mcf['metadata'].get('language_alternate')
 
-        geometry = generate_geometry(
+        geometry = generate_geojson_geometry(
             mcf['identification']['extents']['spatial'])
 
         title = get_charstring(mcf['identification'].get('title'),

pygeometa/schemas/stac/__init__.py

@@ -49,7 +49,7 @@
 from pygeometa.core import get_charstring
 from pygeometa.helpers import json_dumps
 from pygeometa.schemas.base import BaseOutputSchema
-from pygeometa.schemas.util import generate_geometry
+from pygeometa.schemas.util import generate_geojson_geometry
 
 THISDIR = os.path.dirname(os.path.realpath(__file__))
 
@@ -82,7 +82,7 @@ def write(self, mcf: dict, stringify: str = True) -> Union[dict, str]:
         lang1 = mcf['metadata'].get('language')
         lang2 = mcf['metadata'].get('language_alternate')
 
-        geometry = generate_geometry(
+        geometry = generate_geojson_geometry(
             mcf['identification']['extents']['spatial'])
 
         bbox = mcf['identification']['extents']['spatial'][0]['bbox']

pygeometa/schemas/util.py

@@ -48,7 +48,7 @@
 LOGGER = logging.getLogger(__name__)
 
 
-def generate_geometry(spatial: list) -> dict:
+def generate_geojson_geometry(spatial: list) -> dict:
     """
     Helper function to generate GeoJSON geometry from an
     MCF spatial extent
@@ -60,10 +60,15 @@ def generate_geometry(spatial: list) -> dict:
 
     geometry = None
 
-    if len(spatial) == 1:
-        LOGGER.debug('spatial extent is a default bbox')
+    crs_list = [s.get('crs') for s in spatial]
+
+    if len(crs_list) == len(spatial):
+        single_crs = len(set(crs_list)) == 1
+
+    if not single_crs:
+        LOGGER.debug('spatial extent has multiple CRS; using first bbox')
         try:
-            minx, miny, maxx, maxy = (spatial[0]['bbox'])
+            minx, miny, maxx, maxy = spatial[0]['bbox']
             geometry = {
                 'type': 'Polygon',
                 'coordinates': [[
@@ -76,8 +81,8 @@ def generate_geometry(spatial: list) -> dict:
             }
         except TypeError:
             geometry = None
-    elif len(spatial) > 1:
-        LOGGER.debug('spatial extent is a multiple bbox')
+    else:
+        LOGGER.debug('spatial extent is a multiple bbox with same CRS')
         bboxes = []
         for s in spatial:
             try:
@@ -96,8 +101,5 @@ def generate_geometry(spatial: list) -> dict:
             'type': 'MultiPolygon',
             'coordinates': bboxes
         }
-    else:
-        LOGGER.debug('Invalid spatial extent')
-        geometry = None
 
     return geometry

tests/run_tests.py

@@ -65,6 +65,7 @@
 from pygeometa.schemas.iso19139 import ISO19139OutputSchema
 from pygeometa.schemas.ogcapi_records import OGCAPIRecordOutputSchema
 from pygeometa.schemas.schema_org import _get_box_from_coords
+from pygeometa.schemas.util import generate_geojson_geometry
 
 from sample_schema import SampleOutputSchema
 
@@ -569,6 +570,44 @@ def test_generate_datetime(self):
         self.assertEqual(len(generate_datetime(None)), 20)
         self.assertEqual(len(generate_datetime('None')), 20)
 
+    def test_get_geojson_geometry(self):
+        """Test pygeometa.schemas.util.get_geojson_geometry"""
+
+        spatials = [{
+            'def': [{
+                'bbox': [164.1, -53.8, 180, -27.8],
+                'crs': 4326
+                }, {
+                'bbox': [-180, -53.8, -174.1, -27.8],
+                'crs': 4326
+            }],
+            'type': 'MultiPolygon'
+            }, {
+            'def': [{
+                'bbox': [-152, 42, -52, 84],
+                'crs': 4326
+                }, {
+                'bbox': [-180, -53.8, -174.1, -27.8],
+                'crs': 4269
+            }],
+            'type': 'Polygon'
+            }, {
+            'def': [{
+                'bbox': [-180, 28.896, 180, 90],
+                'crs': 4326
+                }, {
+                'bbox': [-2500.000, -2500.000, 8847500.000, 8047500.000],
+                'proj4': '+proj=stere +lat_0=90 +lon_0=-100 +k=0.93301243 +x_0=4245000 +y_0=5295000 +R=6371229 +units=m +no_defs',  # noqa
+            }],
+            'type': 'Polygon'
+        }]
+
+        for spatial in spatials:
+            geometry = generate_geojson_geometry(spatial['def'])
+            print(json.dumps(geometry, indent=4))
+            self.assertEqual(geometry['type'], spatial['type'],
+                             f"Expected geometry type {spatial['type']}")
+
 
 def get_abspath(filepath):
     """helper function absolute file access"""