feat: Adopt bindTracingChannelToSpan across runtimes (#21642)

This PR adopts `bindTracingChannelToSpan` utility across our packages,
and drops the `tracingChannel` helper we had.

The `tracingChannel` drop isn't a breaking change imo, its an internal
export used by us exclusively.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: logaretm

packages/deno/src/integrations/redis.ts

@@ -2,14 +2,9 @@
 // lacking `tracingChannel` (added in Deno 1.44.3).
 // On older runtimes the integration becomes a no-op.
 import * as dc from 'node:diagnostics_channel';
-import type {
-  RedisDiagnosticChannelResponseHook,
-  RedisTracingChannel,
-  RedisTracingChannelFactory,
-  RedisTracingChannelSubscribers,
-} from '@sentry/server-utils';
+import type { RedisDiagnosticChannelResponseHook, RedisTracingChannelFactory } from '@sentry/server-utils';
 import { subscribeRedisDiagnosticChannels } from '@sentry/server-utils';
-import type { Integration, IntegrationFn, Span } from '@sentry/core';
+import type { Integration, IntegrationFn } from '@sentry/core';
 import { defineIntegration } from '@sentry/core';
 import { setAsyncLocalStorageAsyncContextStrategy } from '../async';
 
@@ -23,49 +18,17 @@ export interface DenoRedisIntegrationOptions {
   responseHook?: RedisDiagnosticChannelResponseHook;
 }
 
-/**
- * Portable tracing-channel factory: wraps `node:diagnostics_channel.tracingChannel`
- * and stamps `data._sentrySpan` from `transformStart` in the `start` subscriber.
- *
- * Unlike `@sentry/opentelemetry/tracing-channel`, this does not call `bindStore`
- */
-type DataWithSpan<T> = T & { _sentrySpan?: Span };
-type SubscriberFn<T> = (data: DataWithSpan<T>) => void;
-
-const portableTracingChannel: RedisTracingChannelFactory = <T extends object>(
-  name: string,
-  transformStart: (data: T) => Span,
-): RedisTracingChannel<T> => {
-  const channel = dc.tracingChannel<DataWithSpan<T>>(name);
-  return {
-    subscribe(subs: Partial<RedisTracingChannelSubscribers<T>>): void {
-      const userStart = subs.start as SubscriberFn<T> | undefined;
-      const composed: Record<string, SubscriberFn<T>> = {
-        start(data) {
-          data._sentrySpan = transformStart(data);
-          userStart?.(data);
-        },
-      };
-      for (const event of ['asyncStart', 'asyncEnd', 'end', 'error'] as const) {
-        const fn = subs[event] as SubscriberFn<T> | undefined;
-        if (fn) composed[event] = fn;
-      }
-      // Native subscribe is typed for the full subscriber set, but only the
-      // handlers actually present are invoked at runtime.
-      channel.subscribe(composed as unknown as Parameters<typeof channel.subscribe>[0]);
-    },
-  };
-};
-
 const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
   return {
     name: INTEGRATION_NAME,
     setupOnce() {
       if (!dc.tracingChannel) {
         return;
       }
+      // The span is bound into Deno's AsyncLocalStorage context via the async-context
+      // strategy's `getTracingChannelBinding`, so the native channel can be passed directly.
       setAsyncLocalStorageAsyncContextStrategy();
-      subscribeRedisDiagnosticChannels(portableTracingChannel, options.responseHook);
+      subscribeRedisDiagnosticChannels(dc.tracingChannel as RedisTracingChannelFactory, options.responseHook);
     },
   };
 }) satisfies IntegrationFn;

packages/nitro/package.json

@@ -38,7 +38,7 @@
     "@sentry/bundler-plugin-core": "^5.3.0",
     "@sentry/core": "10.60.0",
     "@sentry/node": "10.60.0",
-    "@sentry/opentelemetry": "10.60.0"
+    "@sentry/server-utils": "10.60.0"
   },
   "devDependencies": {
     "nitro": "^3.0.260415-beta",

packages/nitro/src/runtime/hooks/captureStorageEvents.ts

@@ -1,16 +1,14 @@
+import { tracingChannel } from 'node:diagnostics_channel';
 import {
-  captureException,
   flushIfServerless,
   GLOBAL_OBJ,
   SEMANTIC_ATTRIBUTE_CACHE_HIT,
   SEMANTIC_ATTRIBUTE_CACHE_KEY,
   SEMANTIC_ATTRIBUTE_SENTRY_OP,
   SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
-  SPAN_STATUS_ERROR,
-  SPAN_STATUS_OK,
-  startSpanManual,
+  startInactiveSpan,
 } from '@sentry/core';
-import { tracingChannel, type TracingChannelContextWithSpan } from '@sentry/opentelemetry/tracing-channel';
+import { bindTracingChannelToSpan } from '@sentry/server-utils';
 import type { TraceContext } from 'unstorage/tracing';
 
 const ORIGIN = 'auto.cache.nitro';
@@ -57,11 +55,12 @@ function setupStorageTracingChannel(operation: TracedOperation): void {
   const keys = (data: TraceContext): string[] => data.keys ?? [];
   const mountBase = (data: TraceContext): string => (data.base ?? '').replace(/:$/, '');
 
-  const channel = tracingChannel<TraceContext>(`unstorage.${operation}`, data => {
-    const cacheKeys = keys(data);
+  bindTracingChannelToSpan(
+    tracingChannel<TraceContext>(`unstorage.${operation}`),
+    data => {
+      const cacheKeys = keys(data);
 
-    return startSpanManual(
-      {
+      return startInactiveSpan({
         name: cacheKeys.join(', ') || operation,
         attributes: {
           [SEMANTIC_ATTRIBUTE_SENTRY_OP]: `cache.${normalizeMethodName(operation)}`,
@@ -71,34 +70,24 @@ function setupStorageTracingChannel(operation: TracedOperation): void {
           'db.collection.name': mountBase(data),
           'db.system.name': data.driver?.name ?? 'unknown',
         },
-      },
-      span => span,
-    );
-  });
-
-  channel.subscribe({
-    asyncEnd(data: TracingChannelContextWithSpan<TraceContext & { result?: unknown }>) {
-      if (data._sentrySpan && CACHE_HIT_OPERATIONS.has(operation)) {
-        const hit = operation === 'hasItem' ? Boolean(data.result) : isCacheHit(data.keys?.[0], data.result);
-        data._sentrySpan.setAttribute(SEMANTIC_ATTRIBUTE_CACHE_HIT, hit);
-      }
-
-      data._sentrySpan?.setStatus({ code: SPAN_STATUS_OK });
-      data._sentrySpan?.end();
-
-      void flushIfServerless();
-    },
-    error(data: TracingChannelContextWithSpan<TraceContext & { error?: unknown }>) {
-      captureException(data.error, {
-        mechanism: { handled: false, type: ORIGIN },
       });
-
-      data._sentrySpan?.setStatus({ code: SPAN_STATUS_ERROR, message: 'internal_error' });
-      data._sentrySpan?.end();
-
-      void flushIfServerless();
     },
-  });
+    {
+      beforeSpanEnd(span, data) {
+        // Error status is set by the binding; the error itself is captured at the request boundary,
+        // not here (cache ops aren't an error boundary). Only enrich the success path.
+        if (!('error' in data)) {
+          const result = (data as { result?: unknown }).result;
+          if (CACHE_HIT_OPERATIONS.has(operation)) {
+            const hit = operation === 'hasItem' ? Boolean(result) : isCacheHit(data.keys?.[0], result);
+            span.setAttribute(SEMANTIC_ATTRIBUTE_CACHE_HIT, hit);
+          }
+        }
+
+        void flushIfServerless();
+      },
+    },
+  );
 }
 
 function normalizeMethodName(methodName: string): string {