Commit 0aeb61a
authored
fix(performance): exclude db.cursor spans from N+1 DB detection (#118031)
Cursor iteration in asyncpg (and other DB drivers that support
server-side cursors) produces N spans that share the original SQL as
their description. Each `cursor.fetch()` and `cursor.__anext__` calls
trigger a `BaseCursor._exec` invocation, which the SDK wraps as a `db`
span — so the detector sees a source span followed by N identical
repeating spans and fires a false-positive N+1 alert.
These are sequential calls draining a **pre-existing server-side cursor
result set**, not N independently issued queries. They should be
excluded from N+1 detection the same way `db.redis` and `db.connection`
already are.1 parent f1d0af2 commit 0aeb61a
2 files changed
Lines changed: 71 additions & 0 deletions
File tree
- src/sentry/issue_detection/detectors
- tests/sentry/issue_detection
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| |||
Lines changed: 70 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
430 | 500 | | |
431 | 501 | | |
432 | 502 | | |
| |||
0 commit comments