avoid clashes in error codes

Author: gggeek

NEWS.md

@@ -8,6 +8,9 @@
 
 * improved: prepare the debugger for json-rpc 2.0 support, which will be in a pending release of the PhpJsonRpc library
 
+* improved: changes some error numbers to avoid conflicts - now errors related to http compression use the range 153-157,
+  while the range 103-107 is reserved for xml parsing errors
+
 * fixed: the `vm.sh` script would not expose the http ports of the test container to the host
 
 

src/PhpXmlRpc.php

@@ -43,12 +43,11 @@ class PhpXmlRpc
         'xml_not_compliant' => 2, // client
         'xml_parsing_error' => 2, // client
 
-        /// @todo fix: those do all conflict with $xmlrpcerrxml+X (with X being an `xml_get_error_code` error). Start at 150?
-        'cannot_decompress' => 103,
-        'decompress_fail' => 104,
-        'dechunk_fail' => 105,
-        'server_cannot_decompress' => 106,
-        'server_decompress_fail' => 107,
+        'cannot_decompress' => 153,
+        'decompress_fail' => 154,
+        'dechunk_fail' => 155,
+        'server_cannot_decompress' => 156,
+        'server_decompress_fail' => 157,
     );
 
     /**
@@ -129,7 +128,8 @@ class PhpXmlRpc
     /**
      * @var int
      * Let XML parse errors start at 100.
-     * The final code will be 100 + X, with X coming from https://www.php.net/manual/en/xml.error-codes.php
+     * The final code will be 100 + X, with X coming from https://www.php.net/manual/en/xml.error-codes.php.
+     * Values are known to go from 1 (XML_ERROR_NO_MEMORY) to 21 (XML_ERROR_EXTERNAL_ENTITY_HANDLING)
      */
     public static $xmlrpcerrxml = 100;