fix: close HTTP response bodies during check runs fallbacks

Author: root

pkg/github/check_runs.go

@@ -44,19 +44,23 @@ func GetPullRequestCheckRuns(ctx context.Context, client *github.Client, owner,
 	if !isAccessDenied(resp) {
 		return ghErrors.NewGitHubAPIErrorResponse(ctx, "failed to get check runs", resp, err), nil
 	}
+	closeResponse(resp)
 
 	// Checks API is unavailable (common on hosted MCP without checks:read). Try fallbacks.
-	if fallback, fbResp, fbErr := fetchCheckRunsFromWorkflowRuns(ctx, client, owner, repo, headSHA, pagination); fbErr == nil {
-		return marshalCheckRunsResult(fallback)
-	} else if fbResp != nil && !isAccessDenied(fbResp) {
-		_ = fbResp.Body.Close()
+	workflowFallback, workflowResp, workflowErr := fetchCheckRunsFromWorkflowRuns(ctx, client, owner, repo, headSHA, pagination)
+	if workflowErr == nil {
+		return marshalCheckRunsResult(workflowFallback)
 	}
+	if !isAccessDenied(workflowResp) {
+		return ghErrors.NewGitHubAPIErrorResponse(ctx, "failed to get check runs", workflowResp, workflowErr), nil
+	}
+	closeResponse(workflowResp)
 
-	if fallback, fbResp, fbErr := fetchCheckRunsFromCommitStatuses(ctx, client, owner, repo, headSHA, pagination); fbErr == nil {
-		return marshalCheckRunsResult(fallback)
-	} else if fbResp != nil {
-		_ = fbResp.Body.Close()
+	statusFallback, statusResp, statusErr := fetchCheckRunsFromCommitStatuses(ctx, client, owner, repo, headSHA, pagination)
+	if statusErr == nil {
+		return marshalCheckRunsResult(statusFallback)
 	}
+	closeResponse(statusResp)
 
 	return ghErrors.NewGitHubAPIErrorResponse(ctx,
 		checkRunsAccessErrMsg("failed to get check runs", owner, repo),
@@ -192,6 +196,12 @@ func marshalCheckRunsResult(result MinimalCheckRunsResult) (*mcp.CallToolResult,
 	return utils.NewToolResultText(string(r)), nil
 }
 
+func closeResponse(resp *github.Response) {
+	if resp != nil && resp.Body != nil {
+		_ = resp.Body.Close()
+	}
+}
+
 func readResponseBody(resp *github.Response) ([]byte, error) {
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {