Skip to content

Commit 4462f59

Browse files
committed
fix(ci): improve ubuntu version sync workflow
- Renames the workflow for clarity in pull requests. - Restricts Dockerfile checks to the 'infra' directory. - Fixes bash syntax for array iteration.
1 parent 32eb917 commit 4462f59

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

.github/workflows/ubuntu_version_sync.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#
1515
################################################################################
1616

17-
name: 'Ubuntu Version Sync'
17+
name: 'Ubuntu Version Sync Check'
1818

1919
on:
2020
pull_request:
@@ -63,27 +63,27 @@ jobs:
6363
VERSIONS=("ubuntu-20-04" "ubuntu-24-04")
6464
6565
# Check Dockerfiles
66-
for legacy_file in "${{!LEGACY_DOCKERFILES[@]}}"; do
67-
if echo "$MODIFIED_FILES" | grep -q "^${legacy_file}$"; then
66+
for legacy_file in "${!LEGACY_DOCKERFILES[@]}"; do
67+
if [[ "${legacy_file}" == infra/* ]] && echo "$MODIFIED_FILES" | grep -q "^${legacy_file}$"; then
6868
echo "Legacy file changed: $legacy_file. Verifying counterparts..."
69-
for version in "${{VERSIONS[@]}}"; do
70-
pattern=${{LEGACY_DOCKERFILES[$legacy_file]}}
71-
versioned_file="${{pattern/{{version}}/$version}}"
72-
if ! echo "$MODIFIED_FILES" | grep -q "^${{versioned_file}}$"; then
69+
for version in "${VERSIONS[@]}"; do
70+
pattern="${LEGACY_DOCKERFILES[$legacy_file]}"
71+
versioned_file="${pattern/\{version\}/$version}"
72+
if ! echo "$MODIFIED_FILES" | grep -q "^${versioned_file}$"; then
7373
ERRORS+="\n- Legacy file '${legacy_file}' was changed, but its counterpart '${versioned_file}' was not."
7474
fi
7575
done
7676
fi
7777
done
7878
7979
# Check Scripts
80-
for legacy_file in "${{!LEGACY_SCRIPTS[@]}}"; do
80+
for legacy_file in "${!LEGACY_SCRIPTS[@]}"; do
8181
if echo "$MODIFIED_FILES" | grep -q "^${legacy_file}$"; then
8282
echo "Legacy script changed: $legacy_file. Verifying counterparts..."
83-
for version in "${{VERSIONS[@]}}"; do
84-
pattern=${{LEGACY_SCRIPTS[$legacy_file]}}
85-
versioned_file="${{pattern/{{version}}/$version}}"
86-
if ! echo "$MODIFIED_FILES" | grep -q "^${{versioned_file}}$"; then
83+
for version in "${VERSIONS[@]}"; do
84+
pattern="${LEGACY_SCRIPTS[$legacy_file]}"
85+
versioned_file="${pattern/\{version\}/$version}"
86+
if ! echo "$MODIFIED_FILES" | grep -q "^${versioned_file}$"; then
8787
ERRORS+="\n- Legacy script '${legacy_file}' was changed, but its counterpart '${versioned_file}' was not."
8888
fi
8989
done

0 commit comments

Comments
 (0)