pcapplusplus: add run_tests.sh (#13621)

vitaliset · web-flow · commit 679389449faf · 2025-07-22T12:59:10.000+10:00
Adds `run_tests.sh` to the pcapplusplus project. `run_tests.sh` is used as part of Chronos with cached builds: https://github.com/google/oss-fuzz/tree/master/infra/experimental/chronos#check-tests Output of ./infra/experimental/chronos/check_tests.sh pcapplusplus c++: ``` === Packet++Test === PcapPlusPlus version: v25.05+ (non-official release) Built: Jul 17 2025 06:03:15 Built from: Git branch 'master', commit '824ea14' Disabling memory leak check in MSVC Release builds due to caching logic in stream objects that looks like a memory leak: cpputest/cpputest#786 (comment) Skipping memory leak check for all test cases Start running tests... OUILookup : PASSED EthPacketCreation : PASSED EthPacketPointerCreation : PASSED EthAndArpPacketParsing : PASSED ArpPacketCreation : PASSED EthDot3LayerParsingTest : PASSED EthDot3LayerCreateEditTest : PASSED VlanParseAndCreation : PASSED QinQ802_1adParse : PASSED MplsLayerTest : PASSED VxlanParsingAndCreationTest : PASSED IPv4PacketCreation : PASSED IPv4PacketParsing : PASSED IPv4FragmentationTest : PASSED IPv4OptionsParsingTest : PASSED IPv4OptionsEditTest : PASSED IPv4UdpChecksum : PASSED IPv6UdpPacketParseAndCreate : PASSED IPv6FragmentationTest : PASSED IPv6ExtensionsTest : PASSED TcpPacketNoOptionsParsing : PASSED TcpPacketWithOptionsParsing : PASSED TcpPacketWithOptionsParsing2 : PASSED TcpPacketCreation : PASSED TcpPacketCreation2 : PASSED TcpMalformedPacketParsing : PASSED TcpChecksumInvalidRead : PASSED TcpChecksumMultiBuffer : PASSED PacketUtilsHash5TupleUdp : PASSED PacketUtilsHash5TupleTcp : PASSED PacketUtilsHash5TupleIPv6 : PASSED InsertDataToPacket : PASSED CreatePacketFromBuffer : PASSED InsertVlanToPacket : PASSED RemoveLayerTest : PASSED CopyLayerAndPacketTest : PASSED PacketLayerLookupTest : PASSED RawPacketTimeStampSetterTest : PASSED ParsePartialPacketTest : PASSED PacketTrailerTest : PASSED ResizeLayerTest : PASSED PrintPacketAndLayersTest : PASSED ProtocolFamilyMembershipTest : PASSED PacketParseLayerLimitTest : PASSED HttpRequestParseMethodTest : PASSED HttpRequestLayerParsingTest : PASSED HttpRequestLayerCreationTest : PASSED HttpRequestLayerEditTest : PASSED HttpResponseParseStatusCodeTest : PASSED HttpResponseParseVersionTest : PASSED HttpResponseLayerParsingTest : PASSED HttpResponseLayerCreationTest : PASSED HttpResponseLayerEditTest : PASSED HttpMalformedResponseTest : PASSED PPPoESessionLayerParsingTest : PASSED PPPoESessionLayerCreationTest : PASSED PPPoEDiscoveryLayerParsingTest : PASSED PPPoEDiscoveryLayerCreateTest : PASSED DnsLayerParsingTest : PASSED DnsLayerQueryCreationTest : PASSED DnsLayerResourceCreationTest : PASSED DnsLayerEditTest : PASSED DnsLayerRemoveResourceTest : PASSED DnsOverTcpParsingTest : PASSED DnsOverTcpCreationTest : PASSED DnsLayerAddDnsKeyTest : PASSED IcmpParsingTest : PASSED IcmpCreationTest : PASSED IcmpEditTest : PASSED GreParsingTest : PASSED GreCreationTest : PASSED GreEditTest : PASSED SSLClientHelloParsingTest : PASSED SSLExtensionWithZeroSizeTest : PASSED SSLAppDataParsingTest : PASSED SSLAlertParsingTest : PASSED SSLMultipleRecordParsingTest : PASSED SSLMultipleRecordParsing2Test : PASSED SSLMultipleRecordParsing3Test : PASSED SSLMultipleRecordParsing4Test : PASSED SSLMultipleRecordParsing5Test : PASSED SSLPartialCertificateParseTest : PASSED SSLNewSessionTicketParseTest : PASSED SSLMalformedPacketParsing : PASSED TLS1_3ParsingTest : PASSED TLSCipherSuiteTest : PASSED ClientHelloTLSFingerprintTest : PASSED ServerHelloTLSFingerprintTest : PASSED SllPacketParsingTest : PASSED SllPacketCreationTest : PASSED NullLoopbackTest : PASSED Sll2PacketParsingTest : PASSED Sll2PacketCreationTest : PASSED NflogPacketParsingTest : PASSED DhcpParsingTest : PASSED DhcpCreationTest : PASSED DhcpEditTest : PASSED IgmpParsingTest : PASSED IgmpCreateAndEditTest : PASSED Igmpv3ParsingTest : PASSED Igmpv3QueryCreateAndEditTest : PASSED Igmpv3ReportCreateAndEditTest : PASSED SipRequestParseMethodTest : PASSED SipRequestLayerParsingTest : PASSED SipRequestLayerCreationTest : PASSED SipRequestLayerEditTest : PASSED SipResponseParseStatusCodeTest : PASSED SipResponseParseVersionCodeTest : PASSED SipResponseLayerParsingTest : PASSED SipResponseLayerCreationTest : PASSED SipResponseLayerEditTest : PASSED SipNotSdpLayerParsingTest : PASSED SdpLayerParsingTest : PASSED SdpLayerCreationTest : PASSED SdpLayerEditTest : PASSED RadiusLayerParsingTest : PASSED RadiusLayerCreationTest : PASSED RadiusLayerEditTest : PASSED GtpV1LayerParsingTest : PASSED GtpV1LayerCreationTest : PASSED GtpV1LayerEditTest : PASSED GtpV2LayerParsingTest : PASSED GtpV2LayerCreationTest : PASSED GtpV2LayerEditTest : PASSED BgpLayerParsingTest : PASSED BgpLayerCreationTest : PASSED BgpLayerEditTest : PASSED SSHParsingTest : PASSED SSHMalformedParsingTest : PASSED IPSecParsingTest : PASSED DhcpV6ParsingTest : PASSED DhcpV6CreationTest : PASSED DhcpV6EditTest : PASSED NtpMethodsTests : PASSED NtpParsingV3Tests : PASSED NtpParsingV4Tests : PASSED NtpCreationTests : PASSED TelnetCommandParsingTests : PASSED TelnetDataParsingTests : PASSED TpktLayerTest : PASSED IcmpV6ParsingTest : PASSED IcmpV6CreationTest : PASSED IcmpV6EditTest : PASSED FtpParsingTests : PASSED FtpCreationTests : PASSED FtpEditTests : PASSED LLCParsingTests : PASSED LLCCreationTests : PASSED StpConfigurationParsingTests : PASSED StpConfigurationCreationTests : PASSED StpConfigurationEditTests : PASSED StpTopologyChangeParsingTests : PASSED StpTopologyChangeCreationTests : PASSED StpTopologyChangeEditTests : PASSED RapidStpParsingTests : PASSED RapidStpCreationTests : PASSED RapidStpEditTests : PASSED MultipleStpParsingTests : PASSED MultipleStpCreationTests : PASSED MultipleStpEditTests : PASSED SomeIpPortTest : PASSED SomeIpParsingTest : PASSED SomeIpCreationTest : PASSED SomeIpTpParsingTest : PASSED SomeIpTpCreationTest : PASSED SomeIpTpEditTest : PASSED SomeIpSdParsingTest : PASSED SomeIpSdCreationTest : PASSED WakeOnLanParsingTests : PASSED WakeOnLanCreationTests : PASSED WakeOnLanEditTests : PASSED VrrpParsingTest : PASSED CotpLayerTest : PASSED S7CommLayerParsingTest : PASSED S7CommLayerCreationTest : PASSED SmtpParsingTests : PASSED SmtpCreationTests : PASSED SmtpEditTests : PASSED Asn1DecodingTest : PASSED Asn1EncodingTest : PASSED Asn1ObjectIdentifierTest : PASSED LdapParsingTest : PASSED LdapCreationTest : PASSED WireGuardHandshakeInitParsingTest : PASSED WireGuardHandshakeRespParsingTest : PASSED WireGuardCookieReplyParsingTest : PASSED WireGuardTransportDataParsingTest : PASSED WireGuardCreationTest : PASSED WireGuardEditTest : PASSED CiscoHdlcParsingTest : PASSED CiscoHdlcLayerCreationTest : PASSED CiscoHdlcLayerEditTest : PASSED ALL TESTS PASSED!! Test cases: 193, Passed: 192, Failed: 0, Skipped: 1 === Pcap++Test (no networking) === Running only tests that don't require network connection Disabling memory leak check in MSVC Release builds due to caching logic in stream objects that looks like a memory leak: cpputest/cpputest#786 (comment) Skipping memory leak check for all test cases PcapPlusPlus version: v25.05+ (non-official release) Built: Jul 17 2025 06:03:15 Git info: Git branch 'master', commit '824ea14' Using ip: Debug mode: off Start running tests... TestIPAddress : PASSED TestLRUList : PASSED TestGeneralUtils : PASSED TestIPv4Network : PASSED TestIPv6Network : PASSED TestIPNetwork : PASSED TestObjectPool : PASSED [DEBUG: LoggerTests.cpp: invokeDebugLog:16 ] debug log [ERROR: LoggerTests.cpp: invokeErrorLog:21 ] error log TestLogger : PASSED TestLoggerMultiThread : PASSED TestPcapFileReadWrite : PASSED TestPcapFilePrecision : PASSED TestPcapSllFileReadWrite : PASSED TestPcapSll2FileReadWrite : PASSED TestPcapRawIPFileReadWrite : PASSED TestPcapFileAppend : PASSED TestPcapNgFileReadWrite : PASSED TestPcapNgFileReadWriteAdv : PASSED TestPcapNgFileTooManyInterfaces : PASSED TestPcapNgFilePrecision : PASSED TestPcapFileReadLinkTypeIPv6 : PASSED TestPcapFileReadLinkTypeIPv4 : PASSED TestSolarisSnoopFileRead : PASSED TestPcapFileWriterDeviceDestructor : PASSED TestPcapFilters_MatchStatic : PASSED TestPcapFilters_General_BPFStr : PASSED TestPcapFiltersOffline : PASSED TestPcapFilters_LinkLayer : PASSED TestHttpRequestParsing : PASSED TestHttpResponseParsing : PASSED TestPrintPacketAndLayers : PASSED TestDnsParsing : PASSED TestTcpReassemblySanity : PASSED TestTcpReassemblyOutOfOrder : PASSED TestTcpReassemblyOOOWithManualClose: PASSED TestTcpReassemblyWithFIN_RST : PASSED TestTcpReassemblyMalformedPkts : PASSED TestTcpReassemblyMultipleConns : PASSED TestTcpReassemblyIPv6 : PASSED TestTcpReassemblyIPv6MultConns : PASSED TestTcpReassemblyIPv6_OOO : PASSED TestTcpReassemblyCleanup : PASSED TestTcpReassemblyMaxOOOFrags : PASSED TestTcpReassemblyMaxSeq : PASSED TestTcpReassemblyDisableOOOCleanup : PASSED TestTcpReassemblyTimeStamps : PASSED TestTcpReassemblyFinReset : PASSED TestTcpReassemblyHighPrecision : PASSED TestIPFragmentationSanity : PASSED TestIPFragOutOfOrder : PASSED TestIPFragPartialData : PASSED TestIPFragMultipleFrags : PASSED TestIPFragMapOverflow : PASSED TestIPFragRemove : PASSED TestIPFragWithPadding : PASSED TestIPv4MalformedFragment : PASSED TestSystemCoreUtils : PASSED ALL TESTS PASSED!! Test cases: 96, Passed: 56, Failed: 0, Skipped: 40 -------------------------------------------------------- Total time taken to replay tests: 157 ```
diff --git a/projects/pcapplusplus/Dockerfile b/projects/pcapplusplus/Dockerfile
@@ -25,4 +25,4 @@ RUN git clone --depth=1 https://github.com/the-tcpdump-group/libpcap.git libpcap
 
 WORKDIR PcapPlusPlus
 
-COPY build.sh $SRC
+COPY *.sh pcapplusplus_enable_tests.diff $SRC
diff --git a/projects/pcapplusplus/build.sh b/projects/pcapplusplus/build.sh
@@ -16,4 +16,7 @@
 #
 ################################################################################
 
+# TODO: Right now, we apply patch only if sanitizer is not 'memory'.
+# TODO: Upstream the patch to PcapPlusPlus repo.
+git -C "$SRC/PcapPlusPlus" apply "$SRC/pcapplusplus_enable_tests.diff"
 $SRC/PcapPlusPlus/Tests/Fuzzers/ossfuzz.sh
diff --git a/projects/pcapplusplus/pcapplusplus_enable_tests.diff b/projects/pcapplusplus/pcapplusplus_enable_tests.diff
@@ -0,0 +1,18 @@
+index 6d461ff6..c984c978 100755
+--- a/Tests/Fuzzers/ossfuzz.sh
++++ b/Tests/Fuzzers/ossfuzz.sh
+@@ -12,7 +12,13 @@ make -j$(nproc)
+ # Build PcapPlusPlus linking statically against the built libpcap
+ cd $SRC/PcapPlusPlus
+ LIBPCAP_PATH=$SRC/libpcap/
+-cmake -DPCAPPP_BUILD_FUZZERS=ON -DPCAPPP_BUILD_TESTS=OFF -DPCAPPP_BUILD_EXAMPLES=OFF -DPCAP_INCLUDE_DIR="${LIBPCAP_PATH}/" -DPCAP_LIBRARY="${LIBPCAP_PATH}/libpcap.a" -S . -B $TARGETS_DIR
++
++PCAPPP_BUILD_TESTS_VALUE="ON"
++if [ "${SANITIZER:-}" = "memory" ]; then
++    PCAPPP_BUILD_TESTS_VALUE="OFF"
++fi
++
++cmake -DPCAPPP_BUILD_FUZZERS=ON -DPCAPPP_BUILD_TESTS=$PCAPPP_BUILD_TESTS_VALUE -DPCAPPP_BUILD_EXAMPLES=OFF -DPCAP_INCLUDE_DIR="${LIBPCAP_PATH}/" -DPCAP_LIBRARY="${LIBPCAP_PATH}/libpcap.a" -S . -B $TARGETS_DIR
+ cmake --build $TARGETS_DIR -j
+ 
+ # Copy target and options
diff --git a/projects/pcapplusplus/run_tests.sh b/projects/pcapplusplus/run_tests.sh
@@ -0,0 +1,33 @@
+#!/bin/bash -eu
+# Copyright 2025 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+################################################################################
+
+export ASAN_OPTIONS=detect_stack_use_after_return=0:detect_leaks=0:abort_on_error=0:halt_on_error=0:exitcode=0
+ROOT="$SRC/PcapPlusPlus"
+
+echo "=== Packet++Test ==="
+cd "$ROOT/Tests/Packet++Test"
+# TODO: Skipping failing tests.
+./Bin/Packet++Test -x "VrrpCreateAndEditTest;TestMacAddress;TestTcpReassemblyRetran"
+
+echo "=== Pcap++Test (no networking) ==="
+cd "$ROOT/Tests/Pcap++Test"
+# TODO: Skipping failing tests. TestPcapLiveDeviceList and
+# TestPcapLiveDeviceNoNetworking fail because of network so we should keep
+# them disabled.
+./Bin/Pcap++Test \
+    -n -x \
+    "TestMacAddress;TestTcpReassemblyRetran;TestTcpReassemblyMissingData;TestPcapLiveDeviceList;TestPcapLiveDeviceNoNetworking"

Original file line number	Diff line number	Diff line change
`@@ -25,4 +25,4 @@ RUN git clone --depth=1 https://github.com/the-tcpdump-group/libpcap.git libpcap`
`25`	`25`
`26`	`26`	`WORKDIR PcapPlusPlus`
`27`	`27`
`28`		`-COPY build.sh $SRC`
	`28`	`+COPY *.sh pcapplusplus_enable_tests.diff $SRC`
Original file line number	Diff line number	Diff line change
`@@ -16,4 +16,7 @@`
`16`	`16`	`#`
`17`	`17`	`################################################################################`
`18`	`18`
	`19`	`+# TODO: Right now, we apply patch only if sanitizer is not 'memory'.`
	`20`	`+# TODO: Upstream the patch to PcapPlusPlus repo.`
	`21`	`+git -C "$SRC/PcapPlusPlus" apply "$SRC/pcapplusplus_enable_tests.diff"`
`19`	`22`	`$SRC/PcapPlusPlus/Tests/Fuzzers/ossfuzz.sh`