feat!: add support for basic icons

Author: RoloEdits

Cargo.lock

@@ -57,6 +57,10 @@ sonic-rs = "0.5"
 globset = "0.4"
 etcetera = "0.11"
 arc-swap = "1.9"
+ahash = "0.8"
+smartstring = { version = "1.0.1", features = ["serde"]}
+arrayvec =  { version =  "0.7", features = ["serde"] }
+serde  = { version = "1" }
 
 [workspace.package]
 version = "25.7.1"

Cargo.toml

@@ -22,7 +22,7 @@ helix-parsec = { path = "../helix-parsec" }
 
 ropey.workspace = true
 smallvec = "1.15"
-smartstring = "1.0.1"
+smartstring.workspace = true
 unicode-segmentation.workspace = true
 # unicode-width is changing width definitions
 # that both break our logic and disagree with common

helix-core/Cargo.toml

@@ -17,6 +17,7 @@ use std::mem::replace;
 #[cfg(test)]
 mod test;
 
+use helix_stdx::string::StackString;
 use unicode_segmentation::{Graphemes, UnicodeSegmentation};
 
 use helix_stdx::rope::{RopeGraphemes, RopeSliceExt};
@@ -147,7 +148,7 @@ pub struct TextFormat {
     pub tab_width: u16,
     pub max_wrap: u16,
     pub max_indent_retain: u16,
-    pub wrap_indicator: Box<str>,
+    pub wrap_indicator: StackString,
     pub wrap_indicator_highlight: Option<Highlight>,
     pub viewport_width: u16,
     pub soft_wrap_at_text_width: bool,
@@ -161,7 +162,7 @@ impl Default for TextFormat {
             tab_width: 4,
             max_wrap: 3,
             max_indent_retain: 4,
-            wrap_indicator: Box::from(" "),
+            wrap_indicator: StackString::from(" "),
             viewport_width: 17,
             wrap_indicator_highlight: None,
             soft_wrap_at_text_width: false,

helix-core/src/doc_formatter.rs

@@ -1,3 +1,5 @@
+use helix_stdx::string::StackString;
+
 use crate::doc_formatter::{DocumentFormatter, TextFormat};
 use crate::text_annotations::{InlineAnnotation, Overlay, TextAnnotations};
 
@@ -8,7 +10,7 @@ impl TextFormat {
             tab_width: 2,
             max_wrap: 3,
             max_indent_retain: 4,
-            wrap_indicator: ".".into(),
+            wrap_indicator: StackString::from("."),
             wrap_indicator_highlight: None,
             // use a prime number to allow lining up too often with repeat
             viewport_width: 17,

helix-core/src/doc_formatter/test.rs

@@ -1,7 +1,7 @@
 use serde::{Deserialize, Serialize};
 
 use crate::{
-    Command, Documentation, MarkupKind, PartialResultParams, TagSupport,
+    Command, Documentation, MarkupKind, PartialResultParams, SymbolKind, TagSupport,
     TextDocumentPositionParams, TextDocumentRegistrationOptions, TextEdit, WorkDoneProgressOptions,
     WorkDoneProgressParams,
 };
@@ -55,6 +55,41 @@ impl CompletionItemKind {
 }
 }
 
+impl CompletionItemKind {
+    #[inline]
+    #[must_use]
+    pub const fn as_str(self) -> Option<&'static str> {
+        match self {
+            Self::TEXT => Some("text"),
+            Self::METHOD => SymbolKind::METHOD.as_str(),
+            Self::FUNCTION => SymbolKind::FUNCTION.as_str(),
+            Self::CONSTRUCTOR => SymbolKind::CONSTRUCTOR.as_str(),
+            Self::FIELD => SymbolKind::FIELD.as_str(),
+            Self::VARIABLE => SymbolKind::VARIABLE.as_str(),
+            Self::CLASS => SymbolKind::CLASS.as_str(),
+            Self::INTERFACE => SymbolKind::INTERFACE.as_str(),
+            Self::MODULE => SymbolKind::MODULE.as_str(),
+            Self::PROPERTY => SymbolKind::PROPERTY.as_str(),
+            Self::UNIT => Some("unit"),
+            Self::VALUE => Some("value"),
+            Self::ENUM => SymbolKind::ENUM.as_str(),
+            Self::KEYWORD => Some("keyword"),
+            Self::SNIPPET => Some("snippet"),
+            Self::COLOR => Some("color"),
+            Self::FILE => SymbolKind::FILE.as_str(),
+            Self::REFERENCE => Some("reference"),
+            Self::FOLDER => Some("folder"),
+            Self::ENUM_MEMBER => SymbolKind::ENUM_MEMBER.as_str(),
+            Self::CONSTANT => SymbolKind::CONSTANT.as_str(),
+            Self::STRUCT => SymbolKind::STRUCT.as_str(),
+            Self::EVENT => SymbolKind::EVENT.as_str(),
+            Self::OPERATOR => SymbolKind::OPERATOR.as_str(),
+            Self::TYPE_PARAMETER => SymbolKind::TYPE_PARAMETER.as_str(),
+            _ => None,
+        }
+    }
+}
+
 #[derive(Debug, Eq, PartialEq, Clone, Default, Deserialize, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct CompletionItemCapability {

helix-lsp-types/src/completion.rs

@@ -1279,6 +1279,42 @@ impl SymbolKind {
     }
 }
 
+impl SymbolKind {
+    #[inline]
+    #[must_use]
+    pub const fn as_str(self) -> Option<&'static str> {
+        match self {
+            Self::FILE => Some("file"),
+            Self::MODULE => Some("module"),
+            Self::NAMESPACE => Some("namespace"),
+            Self::PACKAGE => Some("package"),
+            Self::CLASS => Some("class"),
+            Self::METHOD => Some("method"),
+            Self::PROPERTY => Some("property"),
+            Self::FIELD => Some("field"),
+            Self::CONSTRUCTOR => Some("construct"),
+            Self::ENUM => Some("enum"),
+            Self::INTERFACE => Some("interface"),
+            Self::FUNCTION => Some("function"),
+            Self::VARIABLE => Some("variable"),
+            Self::CONSTANT => Some("constant"),
+            Self::STRING => Some("string"),
+            Self::NUMBER => Some("number"),
+            Self::BOOLEAN => Some("boolean"),
+            Self::ARRAY => Some("array"),
+            Self::OBJECT => Some("object"),
+            Self::KEY => Some("key"),
+            Self::NULL => Some("null"),
+            Self::ENUM_MEMBER => Some("enum_member"),
+            Self::STRUCT => Some("struct"),
+            Self::EVENT => Some("event"),
+            Self::OPERATOR => Some("operator"),
+            Self::TYPE_PARAMETER => Some("type_param"),
+            _ => None,
+        }
+    }
+}
+
 /// Specific capabilities for the `SymbolKind` in the `workspace/symbol` request.
 #[derive(Debug, Eq, PartialEq, Clone, Default, Deserialize, Serialize)]
 #[serde(rename_all = "camelCase")]

helix-lsp-types/src/lib.rs

@@ -220,7 +220,7 @@ fn path_component_regex(windows: bool) -> String {
 
 /// Regex for delimited environment captures like `${HOME}`.
 fn braced_env_regex(windows: bool) -> String {
-    r"\$\{(?:".to_owned() + &path_component_regex(windows) + r"|[/:=])+\}"
+    r"\$\{(?:".to_owned() + path_component_regex(windows).as_str() + r"|[/:=])+\}"
 }
 
 fn compile_path_regex(

helix-stdx/src/path.rs

@@ -496,7 +496,7 @@ impl Application {
                     })
             })
             .unwrap_or_else(|| editor.theme_loader.default_theme(true_color));
-        let _ = editor.set_theme(theme);
+        let _ = editor.set_theme(Arc::from(theme));
     }
 
     #[cfg(windows)]