Skip to content

netboot: restore TinyGo build by migrating the DHCPv4 path from client4 to nclient4 #595

Description

@thc1006

u-root's fbnetboot stopped compiling under TinyGo after we updated this module.

The dependency path is:

netboot.RequestNetbootv4
  -> client4.Client.Exchange
  -> dhcpv4.NewDiscoveryForInterface

client4 is deprecated, and NewDiscoveryForInterface lives in dhcpv4.go, which is excluded by the tinygo build tag since #564.

Would it make sense to migrate RequestNetbootv4 to nclient4? That would restore the TinyGo package closure and drop netboot's remaining dependency on the deprecated raw DHCPv4 client. Happy to send a PR if that direction sounds right.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions