Add extra test to make sure stop works right

Author: znorman-harris

apps/client-e2e/src/tests/notebooks/_notebook-runner.ts

@@ -210,7 +210,7 @@ NOTEBOOK_RUNNER.addTest({
 });
 
 NOTEBOOK_RUNNER.addTest({
-  name: 'Replace cell paths for stops',
+  name: 'Replace cell paths for stops and make sure stop always works',
   fn: NotebooksReplaceCellPathsOnStop,
 });
 

apps/client-e2e/src/tests/notebooks/notebooks-replace-cell-paths-on-stop.ts

@@ -7,8 +7,21 @@ import * as vscode from 'vscode';
 
 import { CLIENT_E2E_CONFIG } from '../client-e2e-config.interface';
 import { RunnerFunction } from '../runner.interface';
+import { CompareCellOutputs } from './helpers/compare-cells';
+import { ICompareCellOutputs } from './helpers/compare-cells.interface';
 import { CompareNotebookJSONOutputs } from './helpers/compare-notebook-json-outputs';
 
+/**
+ * Types of outputs from cells that we expect to have
+ */
+export const CELL_OUTPUT: ICompareCellOutputs[] = [
+  {
+    idx: 0,
+    success: false,
+    mimeTypes: ['text/plain'],
+  },
+];
+
 /**
  * Verifies we replace paths when we stop
  */
@@ -36,6 +49,34 @@ export const NotebooksReplaceCellPathsOnStop: RunnerFunction = async (init) => {
   // wait
   await Sleep(CLIENT_E2E_CONFIG.DELAYS.PROBLEMS_NOTEBOOK);
 
+  // compare cells
+  await CompareCellOutputs(nb, CELL_OUTPUT);
+
+  /**
+   * ==================================================================
+   * Run all cells again and compare the outputs to make sure
+   * we catch stopping right
+   * ==================================================================
+   */
+
+  // run all cells
+  await vscode.commands.executeCommand(VSCODE_COMMANDS.NOTEBOOK_RUN_ALL);
+
+  // save to disk
+  await nb.save();
+
+  // wait
+  await Sleep(CLIENT_E2E_CONFIG.DELAYS.PROBLEMS_NOTEBOOK);
+
+  // compare cells
+  await CompareCellOutputs(nb, CELL_OUTPUT);
+
+  /**
+   * ==================================================================
+   * Make sure JSON paths match
+   * ==================================================================
+   */
+
   // compare outputs
   await CompareNotebookJSONOutputs(expectedUri, nbUri);