-
-
Notifications
You must be signed in to change notification settings - Fork 92
Expand file tree
/
Copy pathparser.test.ts
More file actions
378 lines (364 loc) · 8.67 KB
/
parser.test.ts
File metadata and controls
378 lines (364 loc) · 8.67 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
import { describe, expect, it } from "vitest";
import { ParsingError, parseQuery, type QueryWarning } from "@/query/parser";
import { GroupVariant, type Query, ShowMetadataVariant, SortingVariant } from "@/query/query";
describe("parseQuery - rejections", () => {
type Testcase = {
description: string;
input: unknown;
};
const testcases: Testcase[] = [
{
description: "name must be a string",
input: {
name: 1,
filter: "foo",
},
},
{
description: "filter is required",
input: {
name: "foo",
},
},
{
description: "filter must be a string",
input: {
name: "foo",
filter: 1,
},
},
{
description: "autorefresh must be a number",
input: {
name: "foo",
filter: "bar",
autorefresh: "foobar",
},
},
{
description: "autorefresh must be a positive number",
input: {
name: "foo",
filter: "bar",
autorefresh: -1,
},
},
{
description: "sorting must be an array",
input: {
name: "foo",
filter: "bar",
sorting: "not an array",
},
},
{
description: "sorting must an array of strings",
input: {
name: "foo",
filter: "bar",
sorting: [1, 2, 3],
},
},
{
description: "sorting must be valid options",
input: {
name: "foo",
filter: "bar",
sorting: ["foo", "bar"],
},
},
{
description: "groupBy must be a string",
input: {
filter: "foobar",
groupBy: 1,
},
},
{
description: "groupBy must be a valid option",
input: {
filter: "foobar",
groupBy: "something else",
},
},
{
description: "show must be an array of strings",
input: {
name: "foo",
filter: "bar",
show: [1, 2, 3],
},
},
{
description: "show must be valid options",
input: {
name: "foo",
filter: "bar",
show: ["foo", "bar"],
},
},
{
description: "show must be 'none' literal",
input: {
name: "foo",
filter: "bar",
show: "nonee",
},
},
];
for (const tc of testcases) {
it(tc.description, () => {
expect(() => {
parseQuery(JSON.stringify(tc.input));
}).toThrowError(ParsingError);
});
}
});
function makeQuery(opts?: Partial<Query>): Query {
return {
name: opts?.name ?? "",
filter: opts?.filter ?? "",
autorefresh: opts?.autorefresh ?? 0,
sorting: opts?.sorting ?? [SortingVariant.Order],
show:
opts?.show ??
new Set([
ShowMetadataVariant.Due,
ShowMetadataVariant.Description,
ShowMetadataVariant.Project,
ShowMetadataVariant.Labels,
ShowMetadataVariant.Deadline,
]),
groupBy: opts?.groupBy ?? GroupVariant.None,
};
}
describe("parseQuery", () => {
type Testcase = {
description: string;
input: unknown;
expectedOutput: Query;
};
const testcases: Testcase[] = [
{
description: "only filter",
input: {
filter: "bar",
},
expectedOutput: makeQuery({
filter: "bar",
}),
},
{
description: "with name",
input: {
name: "foo",
filter: "bar",
},
expectedOutput: makeQuery({
name: "foo",
filter: "bar",
}),
},
{
description: "with autorefresh",
input: {
filter: "bar",
autorefresh: 120,
},
expectedOutput: makeQuery({
filter: "bar",
autorefresh: 120,
}),
},
{
description: "with group",
input: {
filter: "bar",
groupBy: "section",
},
expectedOutput: makeQuery({
filter: "bar",
groupBy: GroupVariant.Section,
}),
},
{
description: "with sorting",
input: {
filter: "bar",
sorting: ["date"],
},
expectedOutput: makeQuery({
filter: "bar",
sorting: [SortingVariant.Date],
}),
},
{
description: "with show",
input: {
filter: "bar",
show: ["due", "project"],
},
expectedOutput: makeQuery({
filter: "bar",
show: new Set([ShowMetadataVariant.Due, ShowMetadataVariant.Project]),
}),
},
{
description: "with show including deadline",
input: {
filter: "bar",
show: ["due", "deadline", "project"],
},
expectedOutput: makeQuery({
filter: "bar",
show: new Set([
ShowMetadataVariant.Due,
ShowMetadataVariant.Deadline,
ShowMetadataVariant.Project,
]),
}),
},
{
description: "with show = none",
input: {
filter: "bar",
show: "none",
},
expectedOutput: makeQuery({
filter: "bar",
show: new Set(),
}),
},
];
for (const tc of testcases) {
it(tc.description, () => {
const [output, _] = parseQuery(JSON.stringify(tc.input));
expect(output).toStrictEqual(tc.expectedOutput);
});
}
});
describe("parseQuery - warnings", () => {
type Testcase = {
description: string;
input: unknown;
expectedWarnings: QueryWarning[];
};
const testcases: Testcase[] = [
{
description: "JSON input format",
input: {
name: "foo",
filter: "bar",
},
expectedWarnings: [
"This query is written using JSON. This is deprecated and will be removed in a future version. Please use YAML instead.",
],
},
{
description: "Unknown query key",
input: {
namee: "foo",
filter: "bar",
},
expectedWarnings: [
"This query is written using JSON. This is deprecated and will be removed in a future version. Please use YAML instead.",
"Found unexpected query key 'namee'. Is this a typo?",
],
},
];
for (const tc of testcases) {
it(tc.description, () => {
const [_, warnings] = parseQuery(JSON.stringify(tc.input));
expect(warnings).toStrictEqual(tc.expectedWarnings);
});
}
});
describe("parseQuery - error message snapshots", () => {
type ErrorTestCase = {
description: string;
input: string;
};
const testcases: ErrorTestCase[] = [
{
description: "invalid JSON - missing quotes",
input: "{name: foo}",
},
{
description: "invalid JSON - unclosed brace",
input: '{"filter": "bar"',
},
{
description: "invalid YAML - incorrect indentation",
input: "filter: bar\n name: foo\n name: baz",
},
{
description: "neither valid JSON nor YAML",
input: "this is not valid at all {{",
},
{
description: "missing required filter field",
input: '{"name": "foo"}',
},
{
description: "name must be a string",
input: '{"name": 123, "filter": "bar"}',
},
{
description: "filter must be a string",
input: '{"filter": 123}',
},
{
description: "autorefresh must be a number",
input: '{"filter": "bar", "autorefresh": "not a number"}',
},
{
description: "autorefresh must be non-negative",
input: '{"filter": "bar", "autorefresh": -5}',
},
{
description: "sorting must be an array",
input: '{"filter": "bar", "sorting": "not an array"}',
},
{
description: "sorting array must contain strings",
input: '{"filter": "bar", "sorting": [1, 2, 3]}',
},
{
description: "sorting must have valid enum values",
input: '{"filter": "bar", "sorting": ["invalid", "values"]}',
},
{
description: "groupBy must be a string",
input: '{"filter": "bar", "groupBy": 123}',
},
{
description: "groupBy must have valid enum value",
input: '{"filter": "bar", "groupBy": "invalid"}',
},
{
description: "show array must contain strings",
input: '{"filter": "bar", "show": [1, 2, 3]}',
},
{
description: "show must have valid enum values",
input: '{"filter": "bar", "show": ["invalid", "values"]}',
},
{
description: "show field - invalid literal (not 'none')",
input: '{"filter": "bar", "show": "nonee"}',
},
{
description: "multiple validation errors",
input: '{"name": 123, "autorefresh": -1, "sorting": "invalid"}',
},
{
description: "array with mixed valid and invalid enum values",
input: '{"filter": "bar", "sorting": ["date", "invalid", "priority"]}',
},
];
for (const tc of testcases) {
it(tc.description, () => {
expect(() => parseQuery(tc.input)).toThrowErrorMatchingSnapshot();
});
}
});