fix: Fixed vscode extension install

Author: jbadeau

lib/shell.lua

@@ -12,8 +12,9 @@ end
 -- Try to execute shell command, return success status and result
 function M.try_exec(fmt, ...)
   local args = {...}
+  local unpack = table.unpack or unpack  -- Compatibility with Lua 5.1/5.2
   local ok, result = pcall(function() 
-    return M.exec(fmt, table.unpack(args))
+    return M.exec(fmt, unpack(args))
   end)
   return ok, result
 end

lib/vscode.lua

@@ -40,28 +40,167 @@ end
 
 -- VSIX installation (for VSCode recognition)
 function M.install_via_vsix(vsix_path)
-  local ok, output = shell.try_exec('code --install-extension "%s"', vsix_path)
+  local ok, output = shell.try_exec('code --install-extension "%s" 2>&1', vsix_path)
 
-  if not ok then
+  -- VSCode might return non-zero exit code even on success, so check output content
+  if output and (output:match("successfully installed") or output:match("Extension.*installed")) then
+    logger.done("VSCode extension installed via VSIX")
+    -- Print the success message
+    for line in output:gmatch("[^\n]+") do
+      if line:match("successfully installed") or line:match("Extension.*installed") then
+        print("   " .. line)
+      end
+    end
+    return true, "installed"
+  elseif output and output:match("is already installed") then
+    logger.info("VSCode extension already installed")
+    return true, "already_installed"
+  else
+    -- If we get here, there was likely a real failure
     logger.fail("VSCode VSIX installation failed")
+    if output and output ~= "" then
+      print("   Error: " .. output)
+    end
     return false, output
   end
+end
+
+-- Create required VSIX manifest files
+function M.create_vsix_manifest(temp_dir, ext_id, ext_path)
+  -- Read package.json to extract extension metadata
+  local package_json_path = ext_path .. "/package.json"
+  local package_json_content = ""
+  local ok, result = shell.try_exec('cat "%s"', package_json_path)
+  if ok then
+    package_json_content = result
+  end
+  local package_data = {}
 
-  if output and output:match("is already installed") then
-    logger.info("VSCode extension already installed")
-    return true, "already_installed"
+  if package_json_content then
+    -- Simple JSON parsing for the fields we need
+    package_data.name = package_json_content:match('"name"%s*:%s*"([^"]+)"') or ext_id
+    package_data.displayName = package_json_content:match('"displayName"%s*:%s*"([^"]+)"') or package_data.name
+    package_data.description = package_json_content:match('"description"%s*:%s*"([^"]+)"') or ""
+    package_data.version = package_json_content:match('"version"%s*:%s*"([^"]+)"') or "1.0.0"
+    package_data.publisher = package_json_content:match('"publisher"%s*:%s*"([^"]+)"') or "unknown"
+    package_data.categories = package_json_content:match('"categories"%s*:%s*%[([^%]]+)%]') or ""
+    package_data.keywords = package_json_content:match('"keywords"%s*:%s*%[([^%]]+)%]') or ""
+    package_data.icon = package_json_content:match('"icon"%s*:%s*"([^"]+)"') or ""
+    package_data.license = package_json_content:match('"license"%s*:%s*"([^"]+)"') or ""
+    
+    -- Parse engine version
+    local engines = package_json_content:match('"engines"%s*:%s*{([^}]+)}')
+    if engines then
+      package_data.engine = engines:match('"vscode"%s*:%s*"([^"]+)"') or "^1.74.0"
+    else
+      package_data.engine = "^1.74.0"
+    end
   else
-    logger.done("VSCode extension installed via VSIX")
-    if output and output ~= "" then
-      -- Print relevant success messages from VSCode
-      for line in output:gmatch("[^\n]+") do
-        if line:match("successfully installed") or line:match("Extension.*installed") then
-          print("   " .. line)
-        end
+    package_data.name = ext_id
+    package_data.displayName = ext_id
+    package_data.description = ""
+    package_data.version = "1.0.0"
+    package_data.publisher = "unknown"
+    package_data.categories = ""
+    package_data.keywords = ""
+    package_data.icon = ""
+    package_data.license = ""
+    package_data.engine = "^1.74.0"
+  end
+  
+  -- Create [Content_Types].xml with common file types for VSCode extensions
+  local content_types = [[<?xml version="1.0" encoding="utf-8"?>
+<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types"><Default Extension=".json" ContentType="application/json"/><Default Extension=".vsixmanifest" ContentType="text/xml"/><Default Extension=".md" ContentType="text/markdown"/><Default Extension=".js" ContentType="application/javascript"/><Default Extension=".ts" ContentType="application/typescript"/><Default Extension=".html" ContentType="text/html"/><Default Extension=".css" ContentType="text/css"/><Default Extension=".scss" ContentType="text/css"/><Default Extension=".less" ContentType="text/css"/><Default Extension=".xml" ContentType="text/xml"/><Default Extension=".yaml" ContentType="text/yaml"/><Default Extension=".yml" ContentType="text/yaml"/><Default Extension=".txt" ContentType="text/plain"/><Default Extension=".log" ContentType="text/plain"/><Default Extension=".py" ContentType="text/plain"/><Default Extension=".go" ContentType="text/plain"/><Default Extension=".java" ContentType="text/plain"/><Default Extension=".c" ContentType="text/plain"/><Default Extension=".cpp" ContentType="text/plain"/><Default Extension=".h" ContentType="text/plain"/><Default Extension=".hpp" ContentType="text/plain"/><Default Extension=".rs" ContentType="text/plain"/><Default Extension=".php" ContentType="text/plain"/><Default Extension=".rb" ContentType="text/plain"/><Default Extension=".sh" ContentType="text/plain"/><Default Extension=".png" ContentType="image/png"/><Default Extension=".jpg" ContentType="image/jpeg"/><Default Extension=".jpeg" ContentType="image/jpeg"/><Default Extension=".gif" ContentType="image/gif"/><Default Extension=".svg" ContentType="image/svg+xml"/><Default Extension=".ico" ContentType="image/x-icon"/><Default Extension=".ttf" ContentType="font/ttf"/><Default Extension=".woff" ContentType="font/woff"/><Default Extension=".woff2" ContentType="font/woff2"/><Default Extension=".eot" ContentType="application/vnd.ms-fontobject"/></Types>]]
+  
+  shell.exec('cat > "%s/[Content_Types].xml" << \'EOF\'\n%sEOF', temp_dir, content_types)
+  
+  -- Determine icon and license paths
+  local icon_path = ""
+  local license_path = ""
+  
+  if package_data.icon ~= "" then
+    icon_path = "extension/" .. package_data.icon
+  else
+    -- Look for common icon files
+    local common_icons = {"icon.png", "images/icon.png", "media/icon.png", "assets/icon.png"}
+    for _, icon_file in ipairs(common_icons) do
+      local ok, _ = shell.try_exec('test -f "%s"', ext_path .. "/" .. icon_file)
+      if ok then
+        icon_path = "extension/" .. icon_file
+        break
       end
     end
-    return true, "installed"
   end
+  
+  -- Look for license files
+  local common_licenses = {"LICENSE", "LICENSE.txt", "LICENSE.md", "license", "license.txt", "license.md"}
+  for _, license_file in ipairs(common_licenses) do
+    local ok, _ = shell.try_exec('test -f "%s"', ext_path .. "/" .. license_file)
+    if ok then
+      license_path = "extension/" .. license_file
+      break
+    end
+  end
+
+  -- Clean up categories and keywords
+  local categories = package_data.categories:gsub('"', ''):gsub('%s*,%s*', ',')
+  local tags = package_data.keywords:gsub('"', ''):gsub('%s*,%s*', ',')
+  
+  -- Create extension.vsixmanifest
+  local vsix_manifest = string.format([[<?xml version="1.0" encoding="utf-8"?>
+	<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
+		<Metadata>
+			<Identity Language="en-US" Id="%s" Version="%s" Publisher="%s" />
+			<DisplayName>%s</DisplayName>
+			<Description xml:space="preserve">%s</Description>
+			<Tags>%s</Tags>
+			<Categories>%s</Categories>
+			<GalleryFlags>Public</GalleryFlags>
+			
+			<Properties>
+				<Property Id="Microsoft.VisualStudio.Code.Engine" Value="%s" />
+				<Property Id="Microsoft.VisualStudio.Code.ExtensionDependencies" Value="" />
+				<Property Id="Microsoft.VisualStudio.Code.ExtensionPack" Value="" />
+				<Property Id="Microsoft.VisualStudio.Code.ExtensionKind" Value="workspace" />
+				<Property Id="Microsoft.VisualStudio.Code.LocalizedLanguages" Value="" />
+				
+				<Property Id="Microsoft.VisualStudio.Services.Links.Source" Value="" />
+				<Property Id="Microsoft.VisualStudio.Services.Links.Getstarted" Value="" />
+				<Property Id="Microsoft.VisualStudio.Services.Links.GitHub" Value="" />
+				<Property Id="Microsoft.VisualStudio.Services.Links.Support" Value="" />
+				<Property Id="Microsoft.VisualStudio.Services.Links.Learn" Value="" />
+				<Property Id="Microsoft.VisualStudio.Services.Branding.Color" Value="#F2F2F2" />
+				<Property Id="Microsoft.VisualStudio.Services.Branding.Theme" Value="light" />
+				<Property Id="Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown" Value="true" />
+				<Property Id="Microsoft.VisualStudio.Services.Content.Pricing" Value="Free"/>
+
+				
+				
+			</Properties>%s%s
+		</Metadata>
+		<Installation>
+			<InstallationTarget Id="Microsoft.VisualStudio.Code"/>
+		</Installation>
+		<Dependencies/>
+		<Assets>
+			<Asset Type="Microsoft.VisualStudio.Code.Manifest" Path="extension/package.json" Addressable="true" />%s%s%s
+		</Assets>
+	</PackageManifest>]], 
+    package_data.name, package_data.version, package_data.publisher, package_data.displayName, package_data.description,
+    tags, categories, package_data.engine,
+    license_path ~= "" and string.format('\n\t\t\t<License>%s</License>', license_path) or "",
+    icon_path ~= "" and string.format('\n\t\t\t<Icon>%s</Icon>', icon_path) or "",
+    (function() local ok, _ = shell.try_exec('test -f "%s"', ext_path .. "/README.md"); return ok end)() and '\n\t\t\t<Asset Type="Microsoft.VisualStudio.Services.Content.Details" Path="extension/README.md" Addressable="true" />' or "",
+    (function() local ok, _ = shell.try_exec('test -f "%s"', ext_path .. "/CHANGELOG.md"); return ok end)() and '\n\t\t\t<Asset Type="Microsoft.VisualStudio.Services.Content.Changelog" Path="extension/CHANGELOG.md" Addressable="true" />' or "",
+    license_path ~= "" and string.format('\n\t\t\t<Asset Type="Microsoft.VisualStudio.Services.Content.License" Path="%s" Addressable="true" />', license_path) or ""
+  )
+  
+  -- Add icon asset if found
+  if icon_path ~= "" then
+    vsix_manifest = vsix_manifest:gsub("</Assets>", string.format('\t\t\t<Asset Type="Microsoft.VisualStudio.Services.Icons.Default" Path="%s" Addressable="true" />\n\t\t</Assets>', icon_path))
+  end
+  
+  shell.exec('cat > "%s/extension.vsixmanifest" << \'EOF\'\n%sEOF', temp_dir, vsix_manifest)
 end
 
 -- VSIX file creation and installation
@@ -71,9 +210,20 @@ function M.create_and_install_vsix(ext_id, nix_store_path, install_dir, tool_nam
   local vsix_name = (tool_name or ext_id):gsub("%.", "-") .. ".vsix"
   local vsix_path = install_dir .. "/" .. vsix_name
 
-  -- Create VSIX file
+  -- Create VSIX file with proper structure
   local zip_ok = pcall(function()
-    shell.exec('cd "%s" && zip -r "%s" * -x "*.DS_Store"', ext_path, vsix_path)
+    -- Create temp directory for proper VSIX structure
+    local temp_dir = install_dir .. "/vsix_temp"
+    shell.exec('mkdir -p "%s/extension"', temp_dir)
+    shell.exec('cp -r "%s"/. "%s/extension/"', ext_path, temp_dir)
+    -- Fix permissions on copied files so they can be deleted
+    shell.exec('chmod -R u+w "%s"', temp_dir)
+    
+    -- Create required VSIX manifest files
+    M.create_vsix_manifest(temp_dir, ext_id, ext_path)
+    
+    shell.exec('cd "%s" && zip -r "%s" . -x "*.DS_Store"', temp_dir, vsix_path)
+    shell.exec('rm -rf "%s"', temp_dir)
   end)
 
   if not zip_ok then

metadata.lua

@@ -1,6 +1,6 @@
 PLUGIN = {
   name = "mise-nix",
-  version = "0.11.0",
+  version = "0.11.1",
   description = "A backend plugin for Mise that allows you to install and manage packages using Nix with VSCode extension support",
   author = "jbadeau"
 }