issue-1469: warning for no matches of file_rules (#1470)

Co-authored-by: Jakob Marten <github@jfmarten.de>

Author: JFMarten

tests/vsg/config_file_rules_w_globbing_no_match.yaml

@@ -0,0 +1,28 @@
+---
+rule:
+  entity_008:
+    disable : True
+  entity_012:
+    disable : True
+  port_010:
+    disable : True
+  architecture_011:
+    disable : True
+  architecture_013:
+    disable : True
+  architecture_014:
+    disable : True
+file_rules:
+  - tests/**/entity1.vhd :
+      rule:
+         port_007:
+            disable : True
+  - tests/**/*2.vhd :
+      rule:
+         port_008:
+            disable : True
+  - tests/**/nomatch.vhd :
+      rule:
+         port_008:
+            disable : True
+...

tests/vsg/test_vsg.py

@@ -580,6 +580,33 @@ def test_configuration_with_globbing_in_file_rules(self):
 
         self.assertEqual(lActual, lExpected)
 
+    def test_configuration_with_globbing_in_file_rules_and_no_match(self):
+        lExpected = ["WARNING: Could not find file tests/**/nomatch.vhd in configuration file tests/vsg/config_file_rules_w_globbing_no_match.yaml"]
+
+        lActual = []
+
+        try:
+            lActual = (
+                subprocess.check_output(
+                    [
+                        *utils.vsg_exec(),
+                        "--configuration",
+                        "tests/vsg/config_file_rules_w_globbing_no_match.yaml",
+                        "-f",
+                        "tests/vsg/*.vhd",
+                        "--output_format",
+                        "syntastic",
+                    ],
+                )
+                .decode("utf-8")
+                .splitlines()
+            )
+        except subprocess.CalledProcessError as e:
+            lActual = str(e.output.decode("utf-8")).splitlines()
+            iExitStatus = e.returncode
+
+        self.assertEqual(lActual, lExpected)
+
     def test_file_as_stdin(self):
         with open("tests/vsg/entity1.vhd") as file1:
             lExpected = []

vsg/config.py

@@ -48,16 +48,19 @@ def open_configuration_file(sFileName, sJUnitFileName=None):
         sys.exit(1)
 
 
-def validate_file_exists(sFilename, sConfigName):
+def validate_file_exists(sFilename, sConfigName, errorWhenEmpty):
     """Validates a file exist while using the glob function to expand filenames."""
     if isinstance(sFilename, dict):
         sExpandedFilename = list(sFilename.keys())[0]
     else:
         sExpandedFilename = sFilename
     lFileNames = glob_filenames(sExpandedFilename)
     if len(lFileNames) == 0:
-        print("ERROR: Could not find file " + sExpandedFilename + " in configuration file " + sConfigName)
-        sys.exit(1)
+        if errorWhenEmpty:
+            print("ERROR: Could not find file " + sExpandedFilename + " in configuration file " + sConfigName)
+            sys.exit(1)
+        else:
+            print("WARNING: Could not find file " + sExpandedFilename + " in configuration file " + sConfigName)
 
 
 def read_configuration_files(dStyle, commandLineArguments):
@@ -137,7 +140,7 @@ def process_file_list_key(dConfig, tempConfiguration, sKey, sConfigFilename):
     if sKey not in dConfig:
         dReturn[sKey] = []
     for iIndex, sFilename in enumerate(tempConfiguration[sKey]):
-        validate_file_exists(sFilename, sConfigFilename)
+        validate_file_exists(sFilename, sConfigFilename, sKey == "file_list")
         try:
             for sGlobbedFilename in glob_filenames_clean(sFilename):
                 dReturn[sKey].append(sGlobbedFilename)