Skip to content

Commit d75437c

Browse files
committed
Issue#1489: Updated tests to check new behaviour.
1 parent d48d2cb commit d75437c

File tree

3 files changed

+53
-6
lines changed

3 files changed

+53
-6
lines changed
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
2+
architecture RTL of FIFO is
3+
4+
signal sig1 : std_logic_vector(31 downto 0);
5+
signal sig2 : std_logic_vector(3 downto 0);
6+
signal sig3 : std_logic_vector(c_width downto 0);
7+
8+
-- Violations
9+
10+
signal sig1 : std_logic_vector(31 downto 0);
11+
signal sig2 : std_logic_vector(3 downto 0);
12+
signal sig3 : std_logic_vector(c_width downto 0);
13+
14+
begin
15+
16+
end architecture RTL;

tests/whitespace/rule_005_test_input.fixed.vhd renamed to tests/whitespace/rule_005_test_input.fixed_ignore_spaces_before_numbers_true.vhd

File renamed without changes.

tests/whitespace/test_rule_005.py

Lines changed: 37 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,35 @@
1010
sTestDir = os.path.dirname(__file__)
1111

1212
lFile, eError = vhdlFile.utils.read_vhdlfile(os.path.join(sTestDir, "rule_005_test_input.vhd"))
13-
lExpected = []
14-
lExpected.append("")
15-
utils.read_file(os.path.join(sTestDir, "rule_005_test_input.fixed.vhd"), lExpected)
13+
14+
lExpected_ignore_spaces_before_numbers_false = []
15+
lExpected_ignore_spaces_before_numbers_false.append("")
16+
utils.read_file(os.path.join(sTestDir, "rule_005_test_input.fixed_ignore_spaces_before_numbers_false.vhd"), lExpected_ignore_spaces_before_numbers_false)
17+
18+
lExpected_ignore_spaces_before_numbers_true = []
19+
lExpected_ignore_spaces_before_numbers_true.append("")
20+
utils.read_file(os.path.join(sTestDir, "rule_005_test_input.fixed_ignore_spaces_before_numbers_true.vhd"), lExpected_ignore_spaces_before_numbers_true)
1621

1722

1823
class test_whitespace_rule(unittest.TestCase):
1924
def setUp(self):
2025
self.oFile = vhdlFile.vhdlFile(lFile)
2126
self.assertIsNone(eError)
2227

23-
def test_rule_005(self):
28+
def test_rule_005_ignore_spaces_before_numbers_false(self):
29+
oRule = whitespace.rule_005()
30+
oRule.ignore_spaces_before_numbers = False
31+
self.assertTrue(oRule)
32+
self.assertEqual(oRule.name, "whitespace")
33+
self.assertEqual(oRule.identifier, "005")
34+
self.assertEqual(oRule.groups, ["whitespace"])
35+
36+
lExpected = [5, 10, 12]
37+
38+
oRule.analyze(self.oFile)
39+
self.assertEqual(lExpected, utils.extract_violation_lines_from_violation_object(oRule.violations))
40+
41+
def test_rule_005_ignore_spaces_before_numbers_true(self):
2442
oRule = whitespace.rule_005()
2543
self.assertTrue(oRule)
2644
self.assertEqual(oRule.name, "whitespace")
@@ -32,14 +50,27 @@ def test_rule_005(self):
3250
oRule.analyze(self.oFile)
3351
self.assertEqual(lExpected, utils.extract_violation_lines_from_violation_object(oRule.violations))
3452

35-
def test_fix_rule_005(self):
53+
def test_fix_rule_005_ignore_spaces_before_numbers_false(self):
54+
oRule = whitespace.rule_005()
55+
oRule.ignore_spaces_before_numbers = False
56+
57+
oRule.fix(self.oFile)
58+
59+
lActual = self.oFile.get_lines()
60+
61+
self.assertEqual(lExpected_ignore_spaces_before_numbers_false, lActual)
62+
63+
oRule.analyze(self.oFile)
64+
self.assertEqual(oRule.violations, [])
65+
66+
def test_fix_rule_005_ignore_spaces_before_numbers_true(self):
3667
oRule = whitespace.rule_005()
3768

3869
oRule.fix(self.oFile)
3970

4071
lActual = self.oFile.get_lines()
4172

42-
self.assertEqual(lExpected, lActual)
73+
self.assertEqual(lExpected_ignore_spaces_before_numbers_true, lActual)
4374

4475
oRule.analyze(self.oFile)
4576
self.assertEqual(oRule.violations, [])

0 commit comments

Comments
 (0)