Issue#1407: Timestamp preserved for unmodified files.

Author: jeremiah-c-leary

tests/vsg/file_timestamp/__init__.py

@@ -0,0 +1,2 @@
+
+library     ieee;

tests/vsg/file_timestamp/failing_file.vhd

@@ -0,0 +1,2 @@
+
+library ieee;

tests/vsg/file_timestamp/passing_file.vhd

@@ -0,0 +1,58 @@
+# -*- coding: utf-8 -*-
+import os
+import shutil
+import sys
+import unittest
+from unittest import mock
+
+from vsg import __main__
+
+
+class testMain(unittest.TestCase):
+    def setUp(self):
+        if os.path.exists("deleteme.vhd"):
+            os.remove("deleteme.vhd")
+
+    def tearDown(self):
+        if os.path.exists("deleteme.vhd"):
+            os.remove("deleteme.vhd")
+
+    @mock.patch("sys.stdout")
+    def test_passing_file(self, mock_stdout):
+        shutil.copy("tests/vsg/file_timestamp/passing_file.vhd", "deleteme.vhd")
+        expected = os.path.getmtime("deleteme.vhd")
+
+        sys.argv = ["vsg"]
+        sys.argv.extend(["-f", "deleteme.vhd"])
+        sys.argv.extend(["--output_format", "syntastic"])
+        sys.argv.extend(["-p 1"])
+        sys.argv.extend(["--fix"])
+
+        try:
+            __main__.main()
+        except SystemExit:
+            pass
+
+        actual = os.path.getmtime("deleteme.vhd")
+
+        self.assertEqual(actual, expected)
+
+    @mock.patch("sys.stdout")
+    def test_failing_file(self, mock_stdout):
+        shutil.copy("tests/vsg/file_timestamp/failing_file.vhd", "deleteme.vhd")
+        expected = os.path.getmtime("deleteme.vhd")
+
+        sys.argv = ["vsg"]
+        sys.argv.extend(["-f", "deleteme.vhd"])
+        sys.argv.extend(["--output_format", "syntastic"])
+        sys.argv.extend(["-p 1"])
+        sys.argv.extend(["--fix"])
+
+        try:
+            __main__.main()
+        except SystemExit:
+            pass
+
+        actual = os.path.getmtime("deleteme.vhd")
+
+        self.assertNotEqual(actual, expected)

tests/vsg/file_timestamp/test_timestamp.py

@@ -118,7 +118,9 @@ def apply_rules(commandLineArguments, oConfig, tIndexFileName):
         if commandLineArguments.backup:
             create_backup_file(sFileName)
         oRules.fix(commandLineArguments.fix_phase, commandLineArguments.skip_phase, fix_only)
-        write_vhdl_file(oVhdlFile, oConfig.dConfig)
+        print(oRules.had_violations)
+        if oRules.had_violations:
+            write_vhdl_file(oVhdlFile, oConfig.dConfig)
 
     oRules.clear_violations()
     oRules.check_rules(

vsg/apply_rules.py

@@ -11,6 +11,7 @@ def __init__(self):
         self.unique_id = str(self.name) + "_" + str(self.identifier)
         self.solution = None
         self.violations = []
+        self.had_violations = False
         self.indent_style = "spaces"
         self.indent_size = 2
         self.phase = None
@@ -108,6 +109,7 @@ def fix(self, oFile, dFixOnly=None):
             self._filter_out_fix_only_violations(dFixOnly)
             for oViolation in self.violations[::-1]:
                 self._fix_violation(oViolation)
+                self.had_violations = True
             oFile.update(self.violations, self.remap)
             self.clear_violations()
 

vsg/rule.py

@@ -121,6 +121,7 @@ def __init__(self, oVhdlFile, oSeverityList, sLocalRulesDirectory=None):
         self.oVhdlFile = oVhdlFile
         self.maximumPhase = maximum_phase(self.rules)
         self.violations = False
+        self.had_violations = False
         self.oSeverityList = oSeverityList
 
     def fix(self, iFixPhase=7, lSkipPhase=None, dFixOnly=None):
@@ -156,6 +157,8 @@ def fix(self, iFixPhase=7, lSkipPhase=None, dFixOnly=None):
                     # print(oRule.unique_id)
                     if oRule.severity.type == severity.error_type:
                         oRule.fix(self.oVhdlFile, dFixOnly)
+                        if oRule.had_violations:
+                            self.had_violations = True
                     else:
                         oRule.analyze(self.oVhdlFile)