-
Notifications
You must be signed in to change notification settings - Fork 60
bit_string_literal_500 & 501 not detected in some places #1449
Copy link
Copy link
Open
Labels
Description
After applying the two rules on our code base, these three cases were not fixed:
- When the literal is an argument to a procedure call inside a procedure.
- When the literal is a port map assignment
- When the literal is a case/when value
library ieee;
use ieee.std_logic_1164.all;
use ieee.numeric_std.all;
entity b is
port (
a : in std_logic_vector(7 downto 0);
b : out std_logic_vector(7 downto 0)
);
end entity b;
architecture a of b is
procedure foo (
a : std_logic_vector;
b : boolean
) is
begin
end procedure foo;
procedure bar (
signal a : std_logic_vector
) is
begin
foo(X"5a", a = X"5a"); -- 1
end procedure bar;
component my_component is
port (
c : in std_logic_vector(7 downto 0)
);
end component my_component;
begin
inst : component my_component
port map (
c => X"5a" -- 2
);
proc : process is
begin
case a is
when X"5a" => -- 3
null;
when others =>
null;
end case;
end process proc;
end architecture a;This file is the result after applying the fixes with the default configuration, the expected literal being x"5A" and not X"5a".
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Projects
Status
No status