test-driver: Remove sudo fallbacks and improve reload robustness

The test driver was silently falling back to sudo for privileged
commands, masking permission issues and producing inconsistent results
depending on the caller's sudo configuration. Additionally, the module
reload sequence used a fixed sleep that was too short for firmware
initialisation, causing subsequent interface-dependent checks to fail
or produce misleading output when run immediately after reload.

Remove the sudo fallback from all dmesg and iw invocations so that
permission failures are surfaced explicitly and handled via the
existing skip mechanism. Extend the reload wait logic to poll for the
WiFi interface and then wait for NetworkManager reconnection, replacing
the fixed three-second delay with bounded polling loops. Add progress
messages throughout the main check sequence so the operator can follow
long-running stages without assuming the script has hung.

Signed-off-by: Javier Tia <floss@jetm.me>

Author: jetm

test-driver.sh

@@ -157,7 +157,7 @@ check_module_source() {
 # ---------------------------------------------------------------------------
 check_firmware() {
 	local dmesg_out=""
-	dmesg_out="$(dmesg 2>/dev/null || sudo dmesg 2>/dev/null || true)"
+dmesg_out="$(dmesg 2>/dev/null || true)"
 
 	if [[ -z "$dmesg_out" ]]; then
 		skip "dmesg not accessible (try with sudo)"
@@ -192,7 +192,7 @@ check_firmware() {
 # ---------------------------------------------------------------------------
 check_aspm() {
 	local dmesg_out=""
-	dmesg_out="$(dmesg 2>/dev/null || sudo dmesg 2>/dev/null || true)"
+dmesg_out="$(dmesg 2>/dev/null || true)"
 
 	if [[ -z "$dmesg_out" ]]; then
 		skip "dmesg not accessible"
@@ -250,7 +250,7 @@ check_bt_usb() {
 # ---------------------------------------------------------------------------
 check_bt_firmware() {
 	local dmesg_out=""
-	dmesg_out="$(dmesg 2>/dev/null || sudo dmesg 2>/dev/null || true)"
+dmesg_out="$(dmesg 2>/dev/null || true)"
 
 	if [[ -z "$dmesg_out" ]]; then
 		skip "dmesg not accessible"
@@ -515,10 +515,10 @@ check_scan() {
 	fi
 
 	local scan_out=""
-	scan_out="$(iw dev "$iface" scan 2>/dev/null || sudo iw dev "$iface" scan 2>/dev/null || true)"
+	scan_out="$(iw dev "$iface" scan 2>&1 || true)"
 
-	if [[ -z "$scan_out" ]]; then
-		skip "scan failed (interface down or needs sudo)"
+	if [[ -z "$scan_out" ]] || echo "$scan_out" | has_match "Operation not permitted\|command failed"; then
+		skip "scan failed (interface down or driver busy)"
 		return
 	fi
 
@@ -663,7 +663,7 @@ check_data_path() {
 # ---------------------------------------------------------------------------
 check_errors() {
 	local dmesg_out=""
-	dmesg_out="$(dmesg 2>/dev/null || sudo dmesg 2>/dev/null || true)"
+dmesg_out="$(dmesg 2>/dev/null || true)"
 
 	if [[ -z "$dmesg_out" ]]; then
 		skip "dmesg not accessible"
@@ -717,20 +717,52 @@ check_errors() {
 # Module reload (ensures we test installed DKMS build, not boot-time modules)
 # ---------------------------------------------------------------------------
 reload_modules() {
-	# WiFi modules (order matters: leaf drivers first)
 	local wifi_mods=(mt7925e mt7921e mt7925_common mt7921_common mt792x_lib mt76_connac_lib mt76)
 	local bt_mods=(btusb btmtk)
 
+	echo "Reloading modules..."
 	modprobe -r "${wifi_mods[@]}" 2>/dev/null || true
 	modprobe -r "${bt_mods[@]}" 2>/dev/null || true
 
-	# Reload - kernel resolves DKMS vs built-in automatically
 	modprobe mt7925e 2>/dev/null || true
 	modprobe mt7921e 2>/dev/null || true
 	modprobe btusb 2>/dev/null || true
 
-	# Let firmware init complete
-	sleep 3
+	echo "Waiting for firmware init..."
+	sleep 5
+
+	# Wait for WiFi interface to appear (up to 10s)
+	local iface="" waited=0
+	while ((waited < 10)); do
+		for dev_path in /sys/bus/pci/drivers/mt7925e/*/net/*; do
+			if [[ -d "$dev_path" ]]; then
+				iface="$(basename "$dev_path")"
+				break 2
+			fi
+		done
+		sleep 1
+		waited=$((waited + 1))
+	done
+
+	if [[ -z "$iface" ]]; then
+		echo "  WiFi interface not detected after ${waited}s"
+		return
+	fi
+
+	echo "  WiFi interface: $iface"
+
+	# Wait for NetworkManager to reconnect (up to 30s)
+	echo "Waiting for network reconnection..."
+	waited=0
+	while ((waited < 30)); do
+		if iw dev "$iface" link 2>/dev/null | grep -q "Connected"; then
+			echo "  Connected after ${waited}s"
+			return
+		fi
+		sleep 1
+		waited=$((waited + 1))
+	done
+	echo "  Not reconnected after ${waited}s (scan/connection checks may skip)"
 }
 
 # ---------------------------------------------------------------------------
@@ -753,32 +785,49 @@ main() {
 		iface="$(detect_interface)"
 	fi
 
+	echo ""
+	echo "Running checks..."
+
 	local pkg_ver kernel_ver pci_id
 	local modules dkms_status mod_source firmware aspm_status
 	local bt_usb bt_firmware bt_rfkill
 	local eht_caps device_ready regulatory
 	local scan_result conn_result data_result errors_result
 
-	# Gather results
+	echo "  Package and kernel..."
 	pkg_ver="$(get_package_version)"
 	kernel_ver="$(get_kernel_version)"
 	pci_id="$(get_pci_id)"
+
+	echo "  Modules and DKMS..."
 	modules="$(check_modules)"
 	dkms_status="$(check_dkms)"
 	mod_source="$(check_module_source)"
+
+	echo "  WiFi firmware and ASPM..."
 	firmware="$(check_firmware)"
 	aspm_status="$(check_aspm)"
+
+	echo "  Bluetooth..."
 	bt_usb="$(check_bt_usb)"
 	bt_firmware="$(check_bt_firmware)"
 	bt_rfkill="$(check_bt_rfkill)"
+
+	echo "  WiFi capabilities..."
 	eht_caps="$(check_eht_caps "$iface")"
 	device_ready="$(check_device_ready "$iface")"
 	regulatory="$(check_regulatory "$iface")"
+
+	echo "  Scan, connection, data path..."
 	scan_result="$(check_scan "$iface")"
 	conn_result="$(check_connection "$iface")"
 	data_result="$(check_data_path "$iface")"
+
+	echo "  Checking dmesg for errors..."
 	errors_result="$(check_errors)"
 
+	echo ""
+
 	# Count failures from output (FAIL_COUNT doesn't propagate from subshells)
 	local report
 	report=$(