[finfuns]: Tweaking workflow - fix warnings

jh0x · jh0x · commit 2bb96cfba314 · 2025-07-18T14:04:11.000+01:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,4 +1,4 @@
-HeaderFilterRegex: '^.*/(include)/.*(h|hpp)$'
+HeaderFilterRegex: '^(?!.*extern/).*/(include|src|test)/.*'
 
 Checks: [
   '*',
@@ -125,7 +125,6 @@ CheckOptions:
   readability-identifier-naming.EnumCase: CamelCase
   readability-identifier-naming.LocalVariableCase: lower_case
   readability-identifier-naming.StaticConstantCase: aNy_CasE
-  readability-identifier-naming.MemberCase: lower_case
   readability-identifier-naming.PrivateMemberPrefix: ''
   readability-identifier-naming.ProtectedMemberPrefix: ''
   readability-identifier-naming.PublicMemberCase: lower_case
@@ -146,4 +145,3 @@ CheckOptions:
   cppcoreguidelines-avoid-do-while.IgnoreMacros: true
   readability-identifier-naming.MemberCase: lower_case
   readability-identifier-naming.MemberPrefix: '_'
-  
diff --git a/CMakePresets.json b/CMakePresets.json
@@ -34,7 +34,7 @@
       "name": "clang-tidy",
       "hidden": true,
       "cacheVariables": {
-        "CMAKE_CXX_CLANG_TIDY": "clang-tidy;--header-filter=^(${sourceDir}|${sourceDir}/../extern/expected)"
+        "CMAKE_CXX_CLANG_TIDY": "clang-tidy;--config-file=${sourceDir}/.clang-tidy;--system-headers=false"
       }
     },
     {
diff --git a/include/finfuns/day_count.hpp b/include/finfuns/day_count.hpp
@@ -25,7 +25,7 @@ enum class DayCountConvention : int32_t
     ACT_365_25,
 };
 
-inline constexpr std::string_view day_count_to_string(DayCountConvention dcc)
+constexpr std::string_view day_count_to_string(DayCountConvention dcc)
 {
     switch (dcc)
     {
@@ -40,18 +40,18 @@ inline constexpr std::string_view day_count_to_string(DayCountConvention dcc)
 
 
 template <ChronoDayType D>
-inline constexpr auto days_between_act(D d1, D d2)
+constexpr auto days_between_act(D d1, D d2)
 {
     return (d2 - d1).count();
 }
 
-inline constexpr int days_between_act(int d1, int d2)
+constexpr int days_between_act(int d1, int d2)
 {
     return d2 - d1;
 }
 
 template <DayCountConvention dcc, typename D>
-inline constexpr double year_fraction(D d1, D d2)
+constexpr double year_fraction(D d1, D d2)
 {
     if constexpr (dcc == DayCountConvention::ACT_365F)
         return static_cast<double>(days_between_act(d1, d2)) / 365.0;
diff --git a/include/finfuns/irr.hpp b/include/finfuns/irr.hpp
@@ -26,7 +26,7 @@ enum class IRRErrorCode : int32_t
 
 using IRRError = std::variant<IRRErrorCode, SolverErrorCode>;
 
-inline constexpr std::string_view error_to_sv(IRRErrorCode error)
+constexpr std::string_view error_to_sv(IRRErrorCode error)
 {
     switch (error)
     {
@@ -39,7 +39,7 @@ inline constexpr std::string_view error_to_sv(IRRErrorCode error)
     }
 }
 
-inline constexpr std::string_view error_to_sv(const IRRError & error)
+constexpr std::string_view error_to_sv(const IRRError & error)
 {
     return std::visit([](const auto & e) { return error_to_sv(e); }, error);
 }
diff --git a/include/finfuns/npv.hpp b/include/finfuns/npv.hpp
@@ -23,7 +23,7 @@ enum class NPVError : int32_t
     EmptyCashflows, //!< cashflows.empty()
 };
 
-inline constexpr std::string_view error_to_sv(NPVError error)
+constexpr std::string_view error_to_sv(NPVError error)
 {
     switch (error)
     {
diff --git a/include/finfuns/rate_solver.hpp b/include/finfuns/rate_solver.hpp
@@ -27,7 +27,7 @@ enum class SolverErrorCode
     OTHER_ERROR
 };
 
-inline constexpr std::string_view error_to_sv(SolverErrorCode error)
+constexpr std::string_view error_to_sv(SolverErrorCode error)
 {
     switch (error)
     {
@@ -52,7 +52,7 @@ struct CachedFunction
     double _last_rate = std::numeric_limits<double>::quiet_NaN();
     std::pair<double, double> _last_result;
 
-    CachedFunction(Calculator & c)
+    explicit CachedFunction(Calculator & c)
         : _calculator{c}
     {
     }
diff --git a/include/finfuns/xirr.hpp b/include/finfuns/xirr.hpp
@@ -28,7 +28,7 @@ enum class XIRRErrorCode : int32_t
 
 using XIRRError = std::variant<XIRRErrorCode, SolverErrorCode>;
 
-inline constexpr std::string_view error_to_sv(XIRRErrorCode error)
+constexpr std::string_view error_to_sv(XIRRErrorCode error)
 {
     switch (error)
     {
@@ -45,7 +45,7 @@ inline constexpr std::string_view error_to_sv(XIRRErrorCode error)
     }
 }
 
-inline constexpr std::string_view error_to_sv(const XIRRError & error)
+constexpr std::string_view error_to_sv(const XIRRError & error)
 {
     return std::visit([](const auto & e) { return error_to_sv(e); }, error);
 }
diff --git a/include/finfuns/xnpv.hpp b/include/finfuns/xnpv.hpp
@@ -26,7 +26,7 @@ enum class XNPVError : int32_t
     UnsupportedDayCountConvention, //!< unsupported day count convention
 };
 
-inline constexpr std::string_view error_to_sv(XNPVError error)
+constexpr std::string_view error_to_sv(XNPVError error)
 {
     switch (error)
     {
diff --git a/lib/finfunslib/finfunslib.h b/lib/finfunslib/finfunslib.h
@@ -85,6 +85,7 @@ FINFUNSLIB_EXPORT double finfuns_fv_due_end(double rate, uint32_t periods, doubl
  */
 FINFUNSLIB_EXPORT double finfuns_fv_due_begin(double rate, uint32_t periods, double pmt, double present_value) noexcept;
 
+// NOLINTBEGIN
 /**
  * @brief Error codes for finfuns calculations
  *
@@ -113,7 +114,7 @@ typedef enum
     // Unexpected error
     FINFUNS_CODE_UNEXPECTED_ERROR = 999,
 } FinFunsCode;
-
+// NOLINTEND
 
 /**
  * @brief Calculates Internal Rate of Return (IRR)
@@ -130,8 +131,9 @@ typedef enum
  * @warning The first cashflow should typically be negative (initial investment).
  */
 FINFUNSLIB_EXPORT [[nodiscard]] FinFunsCode
-finfuns_irr(const double * cashflows, int num_cashflows, double guess, double * out_result) noexcept;
+finfuns_irr(const double * cashflows, unsigned num_cashflows, double guess, double * out_result) noexcept;
 
+// NOLINTBEGIN
 /**
  * @brief Time period indexing convention
  */
@@ -140,6 +142,7 @@ typedef enum
     FINFUNS_ZERO_BASED, ///< First period is index 0 (standard financial convention)
     FINFUNS_ONE_BASED ///< First period is index 1 (alternative convention)
 } FinFunsIndexMode;
+// NOLINTEND
 
 /**
  * @brief Calculate Net Present Value (NPV)
@@ -156,9 +159,10 @@ typedef enum
  *       For OneBased mode, all cashflows are discounted (first occurs at t=1).
  */
 FINFUNSLIB_EXPORT [[nodiscard]] FinFunsCode
-finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashflows, int num_cashflows, double * out_result) noexcept;
+finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashflows, unsigned num_cashflows, double * out_result) noexcept;
 
 
+// NOLINTBEGIN
 /**
  * @brief Day count conventions
  */
@@ -167,6 +171,7 @@ typedef enum
     FINFUNS_ACT_365F, ///< Actual days / 365-day year (ISDA)
     FINFUNS_ACT_365_25, ///< Actual days / 365.25-day year (ISDA)
 } FinFunsDayCount;
+// NOLINTEND
 
 /**
  * @brief Calculates XNPV with dates as days since epoch (1970-01-01). Could also jus use relative days if the given date convention supports it.
@@ -183,7 +188,12 @@ typedef enum
  * @warning First cashflow (typically the investment) should be negative
  */
 FINFUNSLIB_EXPORT [[nodiscard]] FinFunsCode finfuns_xnpv(
-    FinFunsDayCount day_count, double rate, const double * cashflows, const int * dates, int num_cashflows, double * out_result) noexcept;
+    FinFunsDayCount day_count,
+    double rate,
+    const double * cashflows,
+    const int * dates,
+    unsigned num_cashflows,
+    double * out_result) noexcept;
 
 /**
  * @brief Calculates XIRR with dates as days since epoch (1970-01-01). Could also jus use relative days if the given date convention supports it.
@@ -201,7 +211,12 @@ FINFUNSLIB_EXPORT [[nodiscard]] FinFunsCode finfuns_xnpv(
  * @warning First cashflow should typically be negative (initial investment)
  */
 FINFUNSLIB_EXPORT [[nodiscard]] FinFunsCode finfuns_xirr(
-    FinFunsDayCount day_count, const double * cashflows, const int * dates, int num_cashflows, double guess, double * out_result) noexcept;
+    FinFunsDayCount day_count,
+    const double * cashflows,
+    const int * dates,
+    unsigned num_cashflows,
+    double guess,
+    double * out_result) noexcept;
 
 
 #ifdef __cplusplus
diff --git a/lib/finfunslib/src/finfunslib.cpp b/lib/finfunslib/src/finfunslib.cpp
@@ -119,7 +119,7 @@ double finfuns_fv_due_begin(double rate, uint32_t periods, double pmt, double pr
     return fv<PaymentDueType::BeginningOfPeriod>(rate, periods, pmt, present_value);
 }
 
-FinFunsCode finfuns_irr(const double * cashflows, int num_cashflows, double guess, double * out_result) noexcept
+FinFunsCode finfuns_irr(const double * cashflows, unsigned num_cashflows, double guess, double * out_result) noexcept
 {
     const auto cf_span = std::span<const double>(cashflows, num_cashflows);
     auto result = irr(cf_span, guess);
@@ -133,7 +133,7 @@ FinFunsCode finfuns_irr(const double * cashflows, int num_cashflows, double gues
     return error_code;
 }
 
-FinFunsCode finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashflows, int num_cashflows, double * out_result) noexcept
+FinFunsCode finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashflows, unsigned num_cashflows, double * out_result) noexcept
 {
     const auto cf_span = std::span{cashflows, static_cast<size_t>(num_cashflows)};
     auto result = (mode == FINFUNS_ZERO_BASED) ? npv<IndexMode::ZeroBased>(rate, cf_span) : npv<IndexMode::OneBased>(rate, cf_span);
@@ -147,7 +147,12 @@ FinFunsCode finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashf
 }
 
 FINFUNSLIB_EXPORT FinFunsCode finfuns_xnpv(
-    FinFunsDayCount day_count, double rate, const double * cashflows, const int * dates, int num_cashflows, double * out_result) noexcept
+    FinFunsDayCount day_count,
+    double rate,
+    const double * cashflows,
+    const int * dates,
+    unsigned num_cashflows,
+    double * out_result) noexcept
 {
     const auto cf_span = std::span(cashflows, num_cashflows);
     const auto date_span = std::span(dates, num_cashflows);
@@ -173,7 +178,12 @@ FINFUNSLIB_EXPORT FinFunsCode finfuns_xnpv(
 }
 
 FINFUNSLIB_EXPORT FinFunsCode finfuns_xirr(
-    FinFunsDayCount day_count, const double * cashflows, const int * dates, int num_cashflows, double guess, double * out_result) noexcept
+    FinFunsDayCount day_count,
+    const double * cashflows,
+    const int * dates,
+    unsigned num_cashflows,
+    double guess,
+    double * out_result) noexcept
 {
     const auto cf_span = std::span(cashflows, num_cashflows);
     const auto date_span = std::span(dates, num_cashflows);
diff --git a/test/finfuns/CMakeLists.txt b/test/finfuns/CMakeLists.txt
@@ -9,6 +9,12 @@ add_executable(
     xnpv_test.cpp
 )
 
-target_link_libraries(finfuns_tests PRIVATE finfuns::headers doctest::doctest)
+target_link_libraries(finfuns_tests PRIVATE finfuns::headers)
+
+target_include_directories(
+    finfuns_tests
+    SYSTEM
+    PRIVATE $<TARGET_PROPERTY:doctest::doctest,INTERFACE_INCLUDE_DIRECTORIES>
+)
 
 add_test(NAME finfuns_tests COMMAND finfuns_tests)
diff --git a/test/finfunslib/CMakeLists.txt b/test/finfunslib/CMakeLists.txt
@@ -5,4 +5,10 @@ target_link_libraries(finfunslib_tests PRIVATE finfuns::lib doctest::doctest)
 # We reuse some of the test data - which needs some headers
 target_link_libraries(finfunslib_tests PRIVATE finfuns::headers)
 
+target_include_directories(
+    finfunslib_tests
+    SYSTEM
+    PRIVATE $<TARGET_PROPERTY:doctest::doctest,INTERFACE_INCLUDE_DIRECTORIES>
+)
+
 add_test(NAME finfunslib_tests COMMAND finfunslib_tests)
diff --git a/test/finfunslib/main.cpp b/test/finfunslib/main.cpp
@@ -5,6 +5,7 @@
 //  1.0. (See accompanying file LICENSE_1_0.txt or copy at
 //  http://www.boost.org/LICENSE_1_0.txt)
 
+// NOLINTBEGIN(clang-analyzer-cplusplus.NewDeleteLeaks)
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include <doctest/doctest.h>
 
@@ -54,9 +55,18 @@ TEST_CASE("npv_lib")
         CAPTURE(test.id);
         std::span<const double> cashflows = test.cashflows;
         double value;
-        const auto rc = (test.mode == IndexMode::ZeroBased)
-            ? finfuns_npv(FinFunsIndexMode::FINFUNS_ZERO_BASED, test.rate, test.cashflows.data(), test.cashflows.size(), &value)
-            : finfuns_npv(FinFunsIndexMode::FINFUNS_ONE_BASED, test.rate, test.cashflows.data(), test.cashflows.size(), &value);
+        const auto rc = (test.mode == IndexMode::ZeroBased) ? finfuns_npv(
+                                                                  FinFunsIndexMode::FINFUNS_ZERO_BASED,
+                                                                  test.rate,
+                                                                  test.cashflows.data(),
+                                                                  static_cast<unsigned>(test.cashflows.size()),
+                                                                  &value)
+                                                            : finfuns_npv(
+                                                                  FinFunsIndexMode::FINFUNS_ONE_BASED,
+                                                                  test.rate,
+                                                                  test.cashflows.data(),
+                                                                  static_cast<unsigned>(test.cashflows.size()),
+                                                                  &value);
 
         if (test.expected_result.has_value())
         {
@@ -82,7 +92,7 @@ TEST_CASE("irr_lib")
         CAPTURE(test.id);
         std::span<const double> cashflows = test.cashflows;
         double value;
-        const auto rc = finfuns_irr(cashflows.data(), cashflows.size(), test.guess.value_or(0.1), &value);
+        const auto rc = finfuns_irr(cashflows.data(), static_cast<unsigned>(cashflows.size()), test.guess.value_or(0.1), &value);
 
         if (test.expected_result.has_value())
         {
@@ -120,10 +130,20 @@ TEST_CASE("xnpv_lib")
                 {
                     case DayCountConvention::ACT_365F:
                         return finfuns_xnpv(
-                            FinFunsDayCount::FINFUNS_ACT_365F, rate, cashflows.data(), dates.data(), cashflows.size(), &value);
+                            FinFunsDayCount::FINFUNS_ACT_365F,
+                            rate,
+                            cashflows.data(),
+                            dates.data(),
+                            static_cast<unsigned>(cashflows.size()),
+                            &value);
                     case DayCountConvention::ACT_365_25:
                         return finfuns_xnpv(
-                            FinFunsDayCount::FINFUNS_ACT_365_25, rate, cashflows.data(), dates.data(), cashflows.size(), &value);
+                            FinFunsDayCount::FINFUNS_ACT_365_25,
+                            rate,
+                            cashflows.data(),
+                            dates.data(),
+                            static_cast<unsigned>(cashflows.size()),
+                            &value);
                 }
                 REQUIRE(false);
                 throw std::logic_error("Unexpected day count");
@@ -146,7 +166,8 @@ TEST_CASE("xnpv_lib")
         std::span<const int> dates = int_dates;
         const auto rate = test.rate;
         double value;
-        const auto rc = finfuns_xnpv(FinFunsDayCount::FINFUNS_ACT_365F, rate, cashflows.data(), dates.data(), cashflows.size(), &value);
+        const auto rc = finfuns_xnpv(
+            FinFunsDayCount::FINFUNS_ACT_365F, rate, cashflows.data(), dates.data(), static_cast<unsigned>(cashflows.size()), &value);
 
         REQUIRE(rc != FinFunsCode::FINFUNS_CODE_SUCCESS);
         // TODO: Check codes
@@ -175,10 +196,20 @@ TEST_CASE("xirr_lib")
                 {
                     case DayCountConvention::ACT_365F:
                         return finfuns_xirr(
-                            FinFunsDayCount::FINFUNS_ACT_365F, cashflows.data(), dates.data(), cashflows.size(), 0.1, &value);
+                            FinFunsDayCount::FINFUNS_ACT_365F,
+                            cashflows.data(),
+                            dates.data(),
+                            static_cast<unsigned>(cashflows.size()),
+                            0.1,
+                            &value);
                     case DayCountConvention::ACT_365_25:
                         return finfuns_xirr(
-                            FinFunsDayCount::FINFUNS_ACT_365_25, cashflows.data(), dates.data(), cashflows.size(), 0.1, &value);
+                            FinFunsDayCount::FINFUNS_ACT_365_25,
+                            cashflows.data(),
+                            dates.data(),
+                            static_cast<unsigned>(cashflows.size()),
+                            0.1,
+                            &value);
                 }
                 REQUIRE(false);
                 throw std::logic_error("Unexpected day count");
@@ -200,9 +231,11 @@ TEST_CASE("xirr_lib")
         auto int_dates = IntDates::process(test.dates);
         std::span<const int> dates = int_dates;
         double value;
-        const auto rc = finfuns_xirr(FinFunsDayCount::FINFUNS_ACT_365F, cashflows.data(), dates.data(), cashflows.size(), 0.1, &value);
+        const auto rc = finfuns_xirr(
+            FinFunsDayCount::FINFUNS_ACT_365F, cashflows.data(), dates.data(), static_cast<unsigned>(cashflows.size()), 0.1, &value);
 
         REQUIRE(rc != FinFunsCode::FINFUNS_CODE_SUCCESS);
         // TODO: Check codes
     }
 }
+// NOLINTEND(clang-analyzer-cplusplus.NewDeleteLeaks)
diff --git a/test/test_data.hpp b/test/test_data.hpp

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`"name": "clang-tidy",`
`35`	`35`	`"hidden": true,`
`36`	`36`	`"cacheVariables": {`
`37`		`- "CMAKE_CXX_CLANG_TIDY": "clang-tidy;--header-filter=^(${sourceDir}\|${sourceDir}/../extern/expected)"`
	`37`	`+ "CMAKE_CXX_CLANG_TIDY": "clang-tidy;--config-file=${sourceDir}/.clang-tidy;--system-headers=false"`
`38`	`38`	`}`
`39`	`39`	`},`
`40`	`40`	`{`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ enum class DayCountConvention : int32_t`
`25`	`25`	`ACT_365_25,`
`26`	`26`	`};`
`27`	`27`
`28`		`-inline constexpr std::string_view day_count_to_string(DayCountConvention dcc)`
	`28`	`+constexpr std::string_view day_count_to_string(DayCountConvention dcc)`
`29`	`29`	`{`
`30`	`30`	`switch (dcc)`
`31`	`31`	`{`
`@@ -40,18 +40,18 @@ inline constexpr std::string_view day_count_to_string(DayCountConvention dcc)`
`40`	`40`
`41`	`41`
`42`	`42`	`template <ChronoDayType D>`
`43`		`-inline constexpr auto days_between_act(D d1, D d2)`
	`43`	`+constexpr auto days_between_act(D d1, D d2)`
`44`	`44`	`{`
`45`	`45`	`return (d2 - d1).count();`
`46`	`46`	`}`
`47`	`47`
`48`		`-inline constexpr int days_between_act(int d1, int d2)`
	`48`	`+constexpr int days_between_act(int d1, int d2)`
`49`	`49`	`{`
`50`	`50`	`return d2 - d1;`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`template <DayCountConvention dcc, typename D>`
`54`		`-inline constexpr double year_fraction(D d1, D d2)`
	`54`	`+constexpr double year_fraction(D d1, D d2)`
`55`	`55`	`{`
`56`	`56`	`if constexpr (dcc == DayCountConvention::ACT_365F)`
`57`	`57`	`return static_cast<double>(days_between_act(d1, d2)) / 365.0;`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ enum class IRRErrorCode : int32_t`
`26`	`26`
`27`	`27`	`using IRRError = std::variant<IRRErrorCode, SolverErrorCode>;`
`28`	`28`
`29`		`-inline constexpr std::string_view error_to_sv(IRRErrorCode error)`
	`29`	`+constexpr std::string_view error_to_sv(IRRErrorCode error)`
`30`	`30`	`{`
`31`	`31`	`switch (error)`
`32`	`32`	`{`
`@@ -39,7 +39,7 @@ inline constexpr std::string_view error_to_sv(IRRErrorCode error)`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`
`42`		`-inline constexpr std::string_view error_to_sv(const IRRError & error)`
	`42`	`+constexpr std::string_view error_to_sv(const IRRError & error)`
`43`	`43`	`{`
`44`	`44`	`return std::visit([](const auto & e) { return error_to_sv(e); }, error);`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ enum class NPVError : int32_t`
`23`	`23`	`EmptyCashflows, //!< cashflows.empty()`
`24`	`24`	`};`
`25`	`25`
`26`		`-inline constexpr std::string_view error_to_sv(NPVError error)`
	`26`	`+constexpr std::string_view error_to_sv(NPVError error)`
`27`	`27`	`{`
`28`	`28`	`switch (error)`
`29`	`29`	`{`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ enum class SolverErrorCode`
`27`	`27`	`OTHER_ERROR`
`28`	`28`	`};`
`29`	`29`
`30`		`-inline constexpr std::string_view error_to_sv(SolverErrorCode error)`
	`30`	`+constexpr std::string_view error_to_sv(SolverErrorCode error)`
`31`	`31`	`{`
`32`	`32`	`switch (error)`
`33`	`33`	`{`
`@@ -52,7 +52,7 @@ struct CachedFunction`
`52`	`52`	`double _last_rate = std::numeric_limits<double>::quiet_NaN();`
`53`	`53`	`std::pair<double, double> _last_result;`
`54`	`54`
`55`		`- CachedFunction(Calculator & c)`
	`55`	`+ explicit CachedFunction(Calculator & c)`
`56`	`56`	`: _calculator{c}`
`57`	`57`	`{`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ enum class XIRRErrorCode : int32_t`
`28`	`28`
`29`	`29`	`using XIRRError = std::variant<XIRRErrorCode, SolverErrorCode>;`
`30`	`30`
`31`		`-inline constexpr std::string_view error_to_sv(XIRRErrorCode error)`
	`31`	`+constexpr std::string_view error_to_sv(XIRRErrorCode error)`
`32`	`32`	`{`
`33`	`33`	`switch (error)`
`34`	`34`	`{`
`@@ -45,7 +45,7 @@ inline constexpr std::string_view error_to_sv(XIRRErrorCode error)`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`48`		`-inline constexpr std::string_view error_to_sv(const XIRRError & error)`
	`48`	`+constexpr std::string_view error_to_sv(const XIRRError & error)`
`49`	`49`	`{`
`50`	`50`	`return std::visit([](const auto & e) { return error_to_sv(e); }, error);`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ enum class XNPVError : int32_t`
`26`	`26`	`UnsupportedDayCountConvention, //!< unsupported day count convention`
`27`	`27`	`};`
`28`	`28`
`29`		`-inline constexpr std::string_view error_to_sv(XNPVError error)`
	`29`	`+constexpr std::string_view error_to_sv(XNPVError error)`
`30`	`30`	`{`
`31`	`31`	`switch (error)`
`32`	`32`	`{`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ double finfuns_fv_due_begin(double rate, uint32_t periods, double pmt, double pr`
`119`	`119`	`return fv<PaymentDueType::BeginningOfPeriod>(rate, periods, pmt, present_value);`
`120`	`120`	`}`
`121`	`121`
`122`		`-FinFunsCode finfuns_irr(const double * cashflows, int num_cashflows, double guess, double * out_result) noexcept`
	`122`	`+FinFunsCode finfuns_irr(const double * cashflows, unsigned num_cashflows, double guess, double * out_result) noexcept`
`123`	`123`	`{`
`124`	`124`	`const auto cf_span = std::span<const double>(cashflows, num_cashflows);`
`125`	`125`	`auto result = irr(cf_span, guess);`
`@@ -133,7 +133,7 @@ FinFunsCode finfuns_irr(const double * cashflows, int num_cashflows, double gues`
`133`	`133`	`return error_code;`
`134`	`134`	`}`
`135`	`135`
`136`		`-FinFunsCode finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashflows, int num_cashflows, double * out_result) noexcept`
	`136`	`+FinFunsCode finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashflows, unsigned num_cashflows, double * out_result) noexcept`
`137`	`137`	`{`
`138`	`138`	`const auto cf_span = std::span{cashflows, static_cast<size_t>(num_cashflows)};`
`139`	`139`	`auto result = (mode == FINFUNS_ZERO_BASED) ? npv<IndexMode::ZeroBased>(rate, cf_span) : npv<IndexMode::OneBased>(rate, cf_span);`
`@@ -147,7 +147,12 @@ FinFunsCode finfuns_npv(FinFunsIndexMode mode, double rate, const double * cashf`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`FINFUNSLIB_EXPORT FinFunsCode finfuns_xnpv(`
`150`		`- FinFunsDayCount day_count, double rate, const double * cashflows, const int * dates, int num_cashflows, double * out_result) noexcept`
	`150`	`+ FinFunsDayCount day_count,`
	`151`	`+ double rate,`
	`152`	`+ const double * cashflows,`
	`153`	`+ const int * dates,`
	`154`	`+ unsigned num_cashflows,`
	`155`	`+ double * out_result) noexcept`
`151`	`156`	`{`
`152`	`157`	`const auto cf_span = std::span(cashflows, num_cashflows);`
`153`	`158`	`const auto date_span = std::span(dates, num_cashflows);`
`@@ -173,7 +178,12 @@ FINFUNSLIB_EXPORT FinFunsCode finfuns_xnpv(`
`173`	`178`	`}`
`174`	`179`
`175`	`180`	`FINFUNSLIB_EXPORT FinFunsCode finfuns_xirr(`
`176`		`- FinFunsDayCount day_count, const double * cashflows, const int * dates, int num_cashflows, double guess, double * out_result) noexcept`
	`181`	`+ FinFunsDayCount day_count,`
	`182`	`+ const double * cashflows,`
	`183`	`+ const int * dates,`
	`184`	`+ unsigned num_cashflows,`
	`185`	`+ double guess,`
	`186`	`+ double * out_result) noexcept`
`177`	`187`	`{`
`178`	`188`	`const auto cf_span = std::span(cashflows, num_cashflows);`
`179`	`189`	`const auto date_span = std::span(dates, num_cashflows);`