Create a tiny Test Framework.

[MaxTymchii]

After the introduction of the import feature, creating new features became easier. I want to help from my side to make the code on the wrench more testable and stable. To do that, I started implementing a set of functions that can help from my point of view.

Here is what I have at this moment.

function assertEqual(actual, expected, comment) {
  var message = "";
  if (actual == expected) {
    str::sprintf(message, "PASS: %s", comment);
  } else {
    str::sprintf(message, "FAIL: %s", comment);
  }

  println(message);
}

A set of tests:

var a = 1;
var b = 1;

assertEqual(a, b, "1 and 1 are equal");

var c = 1;
var d = 2;

assertEqual(c, d, "1 and 2 are NOT equal");


var e = 2;
var f = 4;

assertEqual(e, f, "2 and 4 are NOT equal");

var af = 1.0;
var bf = 1.0;

assertEqual(af, bf, "1.0 and 1.0 are equal");

var cf = 1.0;
var df = 2.0;

assertEqual(cf, df, "1.0 and 2.0 are NOT equal");

var ef = 2.0;
var ff = 4.0;

assertEqual(ef, ff, "2.0 and 4.0 are NOT equal");

var aff = 1.0;
var bff = 1;

assertEqual(aff, bff, "1.0 and 1 are NOT equal");

var cff = 1.0;
var dff = 2;

assertEqual(cff, dff, "1.0 and 2 are NOT equal");

var eff = 2.0;
var fff = 4;

assertEqual(eff, fff, "2.0 and 4 are NOT equal");

var ag = 1;
var bg = 1.1;

assertEqual(ag, bg, "1 and 1.1 are NOT equal");

var cg = 1;
var dg = 2.001;

assertEqual(cg, dg, "1 and 2.001 are NOT equal");

var eg = 2;
var fg = 4.000001;

assertEqual(eg, fg, "2 and 4.000001 are NOT equal");

var g = 3;
var h = "o";

assertEqual(g, h, "3 and o are NOT equal");

var i = "Word";
var j = "Word";

assertEqual(i, j, "Word and Word are equal");

var k[] = {1, 2, 3, 4};
var l[] = {1, 2, 3, 4};

assertEqual(k, l, "[1, 2, 3, 4] and [1, 2, 3, 4] Arrays are equal");

var m[] = {1, 2, 3, 4};
var n[] = {1, 2, 3, 5};

assertEqual(m, n, "[1, 2, 3, 4] and [1, 2, 3, 5] Arrays are NOT equal");

var o = {"a" : 1, "b" : 2, "c" : 3};
var p = {"a" : 1, "b" : 2, "c" : 3};

assertEqual(o, p, "{a: 1, b: 2, c: 3} and {a: 1, b: 2, c: 3} Hash Tables are equal");

var q = {"a" : 1, "b" : 2, "c" : 3};
var r = {"a" : 1, "b" : 2, "c" : 4};

assertEqual(q, r, "{a: 1, b: 2, c: 3} and {a: 1, b: 2, c: 4} Hash Tables are NOT equal");

var s = {"a" : 1, "b" : 2, "c" : 3};
var t = {"a" : 1, "b" : 2, "c" : 3, "d" : 4};

assertEqual(s, t, "{a: 1, b: 2, c: 3} and {a: 1, b: 2, c: 3, d: 4} Hash Tables are NOT equal");

var u = {"a" : 1, "b" : 2, "c" : 3};
var v = {"a" : 1, "b" : "two", "c" : 3};

assertEqual(u, v, "{a: 1, b: 2, c: 3} and {a: 1, b: two, c: 4} Hash Tables are NOT equal");

var string1 = "Hello";
var string2 = "Hello";

assertEqual(string1, string2, "Hello and Hello are equal");

var string3 = "Hello";
var string4 = "World";

assertEqual(string3, string4, "Hello and World are NOT equal");

var string5 = "Hello";
var string6 = "Hello World";

assertEqual(string5, string6, "Hello and Hello World are NOT equal");

Results:

PASS: 1 and 1 are equal
FAIL: 1 and 2 are NOT equal
FAIL: 2 and 4 are NOT equal
PASS: 1.0 and 1.0 are equal
FAIL: 1.0 and 2.0 are NOT equal
FAIL: 2.0 and 4.0 are NOT equal
FAIL: 1.0 and 1 are NOT equal
FAIL: 1.0 and 2 are NOT equal
FAIL: 2.0 and 4 are NOT equal
FAIL: 1 and 1.1 are NOT equal
FAIL: 1 and 2.001 are NOT equal
FAIL: 2 and 4.000001 are NOT equal
FAIL: 3 and o are NOT equal
PASS: Word and Word are equal
PASS: [1, 2, 3, 4] and [1, 2, 3, 4] Arrays are equal
PASS: [1, 2, 3, 4] and [1, 2, 3, 5] Arrays are NOT equal
PASS: {a: 1, b: 2, c: 3} and {a: 1, b: 2, c: 3} Hash Tables are equal
PASS: {a: 1, b: 2, c: 3} and {a: 1, b: 2, c: 4} Hash Tables are NOT equal
PASS: {a: 1, b: 2, c: 3} and {a: 1, b: 2, c: 3, d: 4} Hash Tables are NOT equal
PASS: {a: 1, b: 2, c: 3} and {a: 1, b: two, c: 4} Hash Tables are NOT equal
PASS: Hello and Hello are equal
FAIL: Hello and World are NOT equal
FAIL: Hello and Hello World are NOT equal

As you can see there are some problems at a "Wrench Kingdom".
One of the solutions that I can propose is to compare types. For example check is it an array or hash for example:

Here is what I try to test:

var intValue = 1;
println("Int value: ");
println(a.isInt());
println(a.asInt());

println("Float value: ");
var floatValue = 1.0;
println(floatValue.isFloat());
println(floatValue.asFloat());

println("String value: ");
var stringValue = "Hello";
println(stringValue.isString());
println(stringValue.asString());

println("Array value: ");
var arrayValue[] = {1, 2, 3, 4};
println(arrayValue.isArray());
println(arrayValue.asArray());
println(arrayValue.array());
println(arrayValue[0].asInt());

println("Hash value: ");
var hashValue = {"a" : 1, "b" : 2, "c" : 3};
println(hashValue.isHash());
println(hashValue.asHash());

My results:

Int value: 
0
0
Float value: 
0
0
String value: 
0
0
Array value: 
0
0
0
0
Hash value: 
0
0

As you can see I can't detect anything... Maybe you can propose some other way...

Regards,
Max.

[MaxTymchii]

Tiny update.

println("Array value: ");
var arrayValue[] = {1, 2, 3, 4};
println(arrayValue.isRawArray());
println(arrayValue.isWrenchArray());


println("Hash value: ");
var hashValue = {"a" : 1, "b" : 2, "c" : 3};
println(hashValue.isHash());
println(hashValue.asHash());
println(hashValue.isHashTable());

I tried like this but it also didn't work for me...

Array value: 
0
0
Hash value: 
0
0
0

[jingoro2112]

Great thx for adding unit tests and finding problems this is exactly what I want help with. I will add this to the regression testing after making sure they all pass

…

On Sun, Jun 9, 2024 at 3:04 PM Max ***@***.***> wrote: Tiny update. println("Array value: "); var arrayValue[] = {1, 2, 3, 4}; println(arrayValue.isRawArray()); println(arrayValue.isWrenchArray()); println("Hash value: "); var hashValue = {"a" : 1, "b" : 2, "c" : 3}; println(hashValue.isHash()); println(hashValue.asHash()); println(hashValue.isHashTable()); I tried like this but it also didn't work for me... Array value: 0 0 Hash value: 0 0 0 — Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALIKAZJOPDEJ3GVCUQV7EDZGSRKBAVCNFSM6AAAAABJBDO42WVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TOMRQGYZDI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[MaxTymchii]

Ok, I will wait for updates.

[jingoro2112]

wow, you're killing me :) Okay so there is a lot of hash/array functionality I never added because no one needed it, in particular comparing them as a whole. So I fixed that and added all that functionality in. I also set the stage for the next thing coming. This doesn't work: var intValue = 1; println("Int value: "); println(a.isInt()); println(a.asInt()); because .asInt() and all the rest are not in wrench space, it's only in c++ space, so the compiler treats it as a null-hashed value and returns zero since it wasn't set. However I imagine a world where this would work: var a = 10; a.isInt(); // syntactic sugar for TypeOf<a>::isInt( a ) a.isInt(1,2); // syntactic sugar for TypeOf<a>::doSomething( a, 1, 2 ) And then you could define the TypeOf<a> functions.. most obviously like this: function TypeOf<a>::isInt( a ) { // definition } or of course: struct A { function memberFunc( a ) { } } That way I could include a library that would define them all, iff the developer didn't mind the extra space they would occupy in ROM. I am still chewing this over, and in any case will require a major overhaul to the compiler, though very little change (if any!) to the VM. 5.0.2 has your code in as tests/unit_test1.c which must pass for release (note I also use/test the import function in it) and has all the issues with it fixed. The other code you sent with the _size problem is something I am working on now, hash tables never knew their size, "10" is just twice "5" which is the mod for the table :P I am brainstorming how to properly fix it up and will most likely have a solution shortly.

…

-Curt

On Sun, Jun 9, 2024 at 3:44 PM Max ***@***.***> wrote: Ok, I will wait for updates. — Reply to this email directly, view it on GitHub <#27 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALIKAZE4AG3LOHLETNOZXTZGSWC5AVCNFSM6AAAAABJBDO42WVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TOMRQHAZTO> . You are receiving this because you commented.Message ID: ***@***.***>

[MaxTymchii]

Big-big thanks! All my tests also passed. awesome fix!

P.S: I have a bonus for you)))))) equality of structs.

struct S {
    var a;
    var b;
    var c;
};

struct V {
    var a;
    var b;
    var c;
};

var s1 = S(1, 2, 3);
var s2 = S(1, 2, 3);

assertEqual(s1, s2, "S(1, 2, 3) and S(1, 2, 3) Structs are equal");

var s3 = S(1, 2, 3);
var s4 = S(1, 2, 4);

assertNotEqual(s3, s4, "S(1, 2, 3) and S(1, 2, 4) Structs are equal");

var v1 = V(1, 2, 3);

assertNotEqual(s1, v1, "S(1, 2, 3) and V(1, 2, 3) Structs are equal");

var y1 = {"a" : 1, "b" : 2, "c" : 3};
var array = {1, 2, 3};
assertNotEqual(v1, y, "V(1, 2, 3) and {a: 1, b: 2, c: {d, e}} Struct and HashTable are equal");
assertNotEqual(y1, v1, "{a: 1, b: 2, c: 3} and V(1, 2, 3) HashTable and Struct are equal");
assertNotEqual(array, v1, "{1, 2, 3} and V(1, 2, 3) Array and Struct are equal");

Results:

PASS
FAIL: S(1, 2, 3) and S(1, 2, 4) Structs are equal
FAIL: S(1, 2, 3) and V(1, 2, 3) Structs are equal
PASS
PASS
PASS

[jingoro2112]

the concatenation is a rough one, it has to do with an optimization I made in the addition parser.. since addition can be in any order.. but strings.. well it MATTERS.. it's going to be a rough fix. Struct equality? You're killin' me, smalls. No problem I'll add that.

…

-Curt

On Mon, Jun 10, 2024 at 5:21 PM Max ***@***.***> wrote: Big-big thanks! All my tests also passed. awesome fix! P.S: I have a bonus for you)))))) equality of structs. struct S { var a; var b; var c; }; struct V { var a; var b; var c; }; var s1 = S(1, 2, 3); var s2 = S(1, 2, 3); assertEqual(s1, s2, "S(1, 2, 3) and S(1, 2, 3) Structs are equal"); var s3 = S(1, 2, 3); var s4 = S(1, 2, 4); assertNotEqual(s3, s4, "S(1, 2, 3) and S(1, 2, 4) Structs are equal"); var v1 = V(1, 2, 3); assertNotEqual(s1, v1, "S(1, 2, 3) and V(1, 2, 3) Structs are equal"); var y1 = {"a" : 1, "b" : 2, "c" : 3}; var array = {1, 2, 3}; assertNotEqual(v1, y, "V(1, 2, 3) and {a: 1, b: 2, c: {d, e}} Struct and HashTable are equal"); assertNotEqual(y1, v1, "{a: 1, b: 2, c: 3} and V(1, 2, 3) HashTable and Struct are equal"); assertNotEqual(array, v1, "{1, 2, 3} and V(1, 2, 3) Array and Struct are equal"); Results: PASS FAIL: S(1, 2, 3) and S(1, 2, 4) Structs are equal FAIL: S(1, 2, 3) and V(1, 2, 3) Structs are equal PASS PASS PASS — Reply to this email directly, view it on GitHub <#27 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALIKAZ2GDU7HZQZZ3NPXF3ZGYKHNAVCNFSM6AAAAABJBDO42WVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TOMZRHA2TA> . You are receiving this because you commented.Message ID: ***@***.***>