In wrench.cpp strncasecmp remains activated in msvc #56
Closed
kinjalkishor
started this conversation in
General
Replies: 1 comment 1 reply
|
Thank you! Fix incoming
…On Sat, Dec 20, 2025, 1:58 PM Kinjal Kishor ***@***.***> wrote:
In wrench.cpp strncasecmp remains activated instead of _strnicmp in msvc,
due to msvc defining _WIN32 instead of WIN32 by default in project settings.
#ifdef _WIN32
bool isMatchCase( const char* buf ) const { return _strnicmp(buf, m_str,
m_len) == 0; }
#else
bool isMatchCase( const char* buf ) const { return strncasecmp(buf, m_str,
m_len) == 0; }
#endif
—
Reply to this email directly, view it on GitHub
<#56>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALIKAZ44V3XOJLNW7QVXGD4CWL7DAVCNFSM6AAAAACPUJ3D56VHI2DSMVQWIX3LMV43ERDJONRXK43TNFXW4OZZGI3DOMRXGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Under msvc visual studio 2026
In wrench.cpp strncasecmp remains activated instead of _strnicmp in msvc, due to msvc defining _WIN32 instead of WIN32 by default in project settings.
#ifdef _WIN32
bool isMatchCase( const char* buf ) const { return _strnicmp(buf, m_str, m_len) == 0; }
#else
bool isMatchCase( const char* buf ) const { return strncasecmp(buf, m_str, m_len) == 0; }
#endif
and one more error
both WIN32 & _WIN32 || gives error
#if arm || /* WIN32 || */ _WIN32 || linux || MINGW32 || APPLE || MINGW64 || clang
defining
WRENCH_WIN32_FILE_IO
needs to define
WRENCH_WIN32_TCP
also due to required io headers enabled by this macro only
All reactions