fix: Phase 1 - createMockApi accepts pluginConfigOverrides param + remove dead isExplicitRememberCommand guard (PR CortexReach#518 review fixes)

Author: jlin53882

index.ts

@@ -2746,18 +2746,10 @@ const memoryLanceDBProPlugin = {
 
           const priorRecentTexts = autoCaptureRecentTexts.get(sessionKey) || [];
           let texts = newTexts;
-          // [Fix #5] isExplicitRememberCommand: guard against empty pendingIngressTexts
-          const lastPending = pendingIngressTexts.length > 0
-            ? pendingIngressTexts[pendingIngressTexts.length - 1]
-            : (eligibleTexts.length === 1 ? eligibleTexts[0] : null);
-          if (
-            texts.length === 1 &&
-            lastPending !== null &&
-            isExplicitRememberCommand(lastPending) &&
-            priorRecentTexts.length > 0
-          ) {
-            texts = [...pendingIngressTexts, ...priorRecentTexts.slice(-1), ...eligibleTexts];
-          }
+          // [Fix #5 REMOVED] isExplicitRememberCommand guard: unreachable under REPLACE strategy.
+          // With REPLACE, texts = pendingIngressTexts (length typically > 1 in multi-turn),
+          // so texts.length === 1 guard can never trigger.
+          // This guard was designed for the old APPEND strategy and is obsolete.
           if (newTexts.length > 0) {
             const nextRecentTexts = [...priorRecentTexts, ...newTexts].slice(-6);
             autoCaptureRecentTexts.set(sessionKey, nextRecentTexts);

test/smart-extractor-branches.mjs

@@ -64,14 +64,15 @@ function createEmbeddingServer() {
   });
 }
 
-function createMockApi(dbPath, embeddingBaseURL, llmBaseURL, logs) {
+function createMockApi(dbPath, embeddingBaseURL, llmBaseURL, logs, pluginConfigOverrides = {}) {
   return {
     pluginConfig: {
       dbPath,
       autoCapture: true,
       autoRecall: false,
       smartExtraction: true,
       extractMinMessages: 2,
+      ...pluginConfigOverrides,
       embedding: {
         apiKey: "dummy",
         model: "qwen3-embedding-4b",