fix: defer reviewer provider lookup until needed

Author: Test User

scripts/night-watch-pr-reviewer-cron.sh

@@ -63,11 +63,6 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=night-watch-helpers.sh
 source "${SCRIPT_DIR}/night-watch-helpers.sh"
 
-# Ensure provider CLI is on PATH (nvm, fnm, volta, common bin dirs)
-if ! ensure_provider_on_path "${PROVIDER_CMD}"; then
-  echo "ERROR: Provider '${PROVIDER_CMD}' not found in PATH or common installation locations" >&2
-  exit 127
-fi
 PROJECT_RUNTIME_KEY=$(project_runtime_key "${PROJECT_DIR}")
 PROVIDER_MODEL_DISPLAY=$(resolve_provider_model_display "${PROVIDER_CMD}" "${PROVIDER_LABEL}")
 GLOBAL_LOCK_FILE="/tmp/night-watch-pr-reviewer-${PROJECT_RUNTIME_KEY}.lock"
@@ -93,6 +88,13 @@ emit_result() {
   fi
 }
 
+require_provider_on_path() {
+  if ! ensure_provider_on_path "${PROVIDER_CMD}"; then
+    echo "ERROR: Provider '${PROVIDER_CMD}' not found in PATH or common installation locations" >&2
+    exit 127
+  fi
+}
+
 extract_review_score_from_text() {
   local review_text="${1:-}"
   printf '%s' "${review_text}" \
@@ -853,6 +855,8 @@ if [ -z "${TARGET_PR}" ] && [ "${WORKER_MODE}" != "1" ] && [ "${PARALLEL_ENABLED
     exit 0
   fi
 
+  require_provider_on_path
+
   log "PARALLEL: Launching ${#PR_NUMBER_ARRAY[@]} reviewer worker(s)"
 
   declare -a WORKER_PIDS=()
@@ -1022,6 +1026,8 @@ if [ "${NW_DRY_RUN:-0}" = "1" ]; then
   exit 0
 fi
 
+require_provider_on_path
+
 if ! prepare_detached_worktree "${PROJECT_DIR}" "${REVIEW_WORKTREE_DIR}" "${DEFAULT_BRANCH}" "${LOG_FILE}"; then
   log "FAIL: Unable to create isolated reviewer worktree ${REVIEW_WORKTREE_DIR}"
   exit 1