Skip to content

Commit f108160

Browse files
authored
Merge pull request #8 from flying-sheep/patch-1
Fix event listener prop names in typings
2 parents d05df5b + 3c2eb56 commit f108160

3 files changed

Lines changed: 23 additions & 23 deletions

File tree

index.d.ts

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -19,27 +19,27 @@ export interface WebViewProps extends React.HTMLProps<Electron.WebViewElement> {
1919
disableblinkfeatures?: string
2020
guestinstance?: string
2121

22-
loadCommit?: EventListener
23-
didFinishLoad?: EventListener
24-
didFailLoad?: EventListener
25-
didFrameFinishLoad?: EventListener
26-
didStartLoading?: EventListener
27-
didStopLoading?: EventListener
28-
didGetResponseDetails?: EventListener
29-
didGetRedirectRequest?: EventListener
30-
domReady?: EventListener
31-
pageTitleSet?: EventListener
32-
pageFaviconUpdated?: EventListener
33-
enterHtmlFullScreen?: EventListener
34-
leaveHtmlFullScreen?: EventListener
35-
consoleMessage?: EventListener
36-
newWindow?: EventListener
37-
close?: EventListener
38-
ipcMessage?: EventListener
39-
crashed?: EventListener
40-
gpuCrashed?: EventListener
41-
pluginCrashed?: EventListener
42-
destroyed?: EventListener
22+
onLoadCommit?: EventListener
23+
onDidFinishLoad?: EventListener
24+
onDidFailLoad?: EventListener
25+
onDidFrameFinishLoad?: EventListener
26+
onDidStartLoading?: EventListener
27+
onDidStopLoading?: EventListener
28+
onDidGetResponseDetails?: EventListener
29+
onDidGetRedirectRequest?: EventListener
30+
onDomReady?: EventListener
31+
onPageTitleSet?: EventListener
32+
onPageFaviconUpdated?: EventListener
33+
onEnterHtmlFullScreen?: EventListener
34+
onLeaveHtmlFullScreen?: EventListener
35+
onConsoleMessage?: EventListener
36+
onNewWindow?: EventListener
37+
onClose?: EventListener
38+
onIpcMessage?: EventListener
39+
onCrashed?: EventListener
40+
onGpuCrashed?: EventListener
41+
onPluginCrashed?: EventListener
42+
onDestroyed?: EventListener
4343
}
4444
interface WebViewState {
4545
loaded: boolean

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,5 @@
5252
"semantic-release": "^4.3.5",
5353
"webpack": "^1.12.9"
5454
},
55-
"version": "2.0.0"
55+
"version": "2.0.1"
5656
}

src/webview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default class WebView extends React.Component {
5555
}
5656

5757
render() {
58-
const tagProps = filterKeys(this.props, propName => propName in tagPropTypes)
58+
const tagProps = filterKeys(this.props, propName => !(propName in eventPropTypes))
5959
return (<webview {...tagProps}></webview>);
6060
}
6161

0 commit comments

Comments
 (0)