Skip to content

Commit 6040ea0

Browse files
authored
Merge pull request #743 from keymanapp/fix/15957-embed-query
fix: use SameSite=None for embed cookie
2 parents 977e14c + b427326 commit 6040ea0

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

_content/keyboards/session.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@
3636
// Set a cookie header for subsequent requests so that we do not get a
3737
// locale redirect for embedded keyboard search for Keyman 14.0-18.0. See
3838
// /.htaccess for full discussion (line ~32)
39-
setcookie('embed_keyboards_no_locale_redirect', '1', 0, '/');
39+
//
40+
// Note: 'SameSite=None; secure' is required for embedding in Keyman
41+
// Configuration for Windows because that uses an iframe to embed the search
42+
setcookie('embed_keyboards_no_locale_redirect', '1', ["secure" => true, "samesite" => 'None', 'path' => '/']);
4043

4144
$session_query = http_build_query([
4245
'embed' => $embed,

0 commit comments

Comments
 (0)