fix: use entrypoint.sh in Dockerfile for startup validation#35
Merged
gordonmurray merged 1 commit intoApr 6, 2026
Merged
Conversation
The entrypoint script (docker/entrypoint.sh) validates that DATA_PATH exists and is readable before starting uvicorn, but the Dockerfile bypassed it with a direct CMD to uvicorn. When DATA_PATH was missing or unreadable, users got a Python traceback instead of a clear error. Changes: - COPY entrypoint.sh into the image and chmod +x - Replace CMD with ENTRYPOINT pointing to the script - The script uses exec so uvicorn replaces the shell process and receives signals (SIGTERM etc.) correctly on container shutdown Tested: - Missing DATA_PATH: clear "does not exist or is not mounted" error - Unreadable DATA_PATH: clear "is not readable" error - Valid DATA_PATH: uvicorn starts, /healthz returns 200 Fixes lance-format#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/entrypoint.shvalidates thatDATA_PATHexists and is readable before starting uvicorn, but the Dockerfile bypassed it with a directCMDDATA_PATHwas missing or unreadable, users got a Python traceback instead of a clear error messageexecso uvicorn replaces the shell process and receives signals (SIGTERM etc.) correctly on container shutdownChanges
One file changed:
docker/DockerfileCOPY docker/entrypoint.shinto the imagechmod +xthe scriptCMD ["python", "-m", "uvicorn", ...]withENTRYPOINT ["/app/entrypoint.sh"]Test
Fixes #21