fix: do not resolve to nondeterministic cache entry

Also fix the test by actually resolving the latest commit and ensuring
output is equal

Author: bycruz

packages/lde-core/src/global/init.lua

@@ -383,27 +383,13 @@ function global.repoNameFromUrl(url)
 	return url:match("([^/]+)%.git$") or url:match("([^/]+)$")
 end
 
---- Clones or retrieves a cached git repo directory. Always resolves to a specific commit.
---- Checks existing cache entries first to avoid network where possible.
+--- Clones or retrieves a cached git repo directory. Always resolves to the latest commit.
 ---@param repoName string
 ---@param cloneUrl string
 ---@param branch string?
 ---@return string repoDir
 ---@return string commit
 function global.getOrCloneRepo(repoName, cloneUrl, branch)
-	-- Check for any existing cache entry for this repo name
-	local prefix = sanitize(repoName) .. "-"
-	local cacheDir = global.getGitCacheDir()
-	if fs.isdir(cacheDir) then
-		for entry in fs.readdir(cacheDir) do
-			if entry.type == "dir" and entry.name:sub(1, #prefix) == prefix then
-				local commit = entry.name:sub(#prefix + 1)
-				return path.join(cacheDir, entry.name), commit
-			end
-		end
-	end
-
-	-- No cache hit, resolve and download
 	local ref = branch and ("refs/heads/" .. branch) or "HEAD"
 	local commit, err = git2.lsRemote(cloneUrl, ref)
 	if not commit then

packages/lde/tests/main.test.lua

@@ -4,24 +4,20 @@ local fs = require("fs")
 local env = require("env")
 local path = require("path")
 local json = require("json")
+local git2 = require("git2-sys")
 
 local lde = require("lde-core")
 
 local ldecli = require("tests.lib.ldecli")
 
 test.it("should not ignore --git in ldx", function()
-	-- Pre-populate the git cache so no real download happens.
-	-- Clean up any existing cache entries for this repo name first.
-	local cacheDir = lde.global.getGitCacheDir()
-	if fs.isdir(cacheDir) then
-		for entry in fs.readdir(cacheDir) do
-			if entry.name:match("^hood%-") then
-				fs.rmdir(path.join(cacheDir, entry.name))
-			end
-		end
-	end
-
-	local repoDir = lde.global.getGitRepoDir("hood", "abc1234567890abcdef1234567890abcdef123456")
+	local cloneUrl = "https://github.com/codebycruz/hood"
+
+	-- Resolve the real commit so the cache key matches what getOrCloneRepo expects.
+	local commit = assert(git2.lsRemote(cloneUrl, "HEAD"))
+
+	-- Pre-populate the cache with a fake repo that lacks a "triangle" package.
+	local repoDir = lde.global.getGitRepoDir("hood", commit)
 	fs.rmdir(repoDir)
 	fs.mkdir(repoDir)
 	fs.write(path.join(repoDir, "lde.json"), json.encode({
@@ -32,7 +28,7 @@ test.it("should not ignore --git in ldx", function()
 	fs.mkdir(path.join(repoDir, "src"))
 	fs.write(path.join(repoDir, "src", "init.lua"), "")
 
-	local _, out = ldecli { "x", "triangle", "--git", "https://github.com/codebycruz/hood" }
+	local _, out = ldecli { "x", "triangle", "--git", cloneUrl }
 	test.falsy(out:find("not found in lde registry"))
 	test.includes(out, "No package named 'triangle'")