Skip to content

Commit 817b8dd

Browse files
committed
tu/kgsl: drop strict KHR_display check during initialization
Currently, `tu_knl_kgsl_load` explicitly fails with `VK_ERROR_INITIALIZATION_FAILED` if the application enables the `VK_KHR_display` instance extension. This causes applications that blindly enable all available instance extensions (such as `vkcube` or WSI layers) to fail device enumeration completely in environments where KMS/DRM support is compiled alongside KGSL (i.e. when VK_USE_PLATFORM_DISPLAY_KHR is exposed). The proper WSI display fallback behavior (returning 0 displays when the DRM master fd is invalid/missing) is already correctly handled by `wsi_display_init_wsi` and `wsi_GetPhysicalDeviceDisplayPropertiesKHR`. Thus, it is safe and more compliant to drop this aggressive check, allowing Vulkan physical device enumeration to succeed even if the display extension was requested.
1 parent 73319d2 commit 817b8dd

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

src/freedreno/vulkan/tu_knl_kgsl.cc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1754,10 +1754,7 @@ tu_kgsl_get_raytracing(int fd)
17541754
VkResult
17551755
tu_knl_kgsl_load(struct tu_instance *instance, int fd)
17561756
{
1757-
if (instance->vk.enabled_extensions.KHR_display) {
1758-
return vk_errorf(instance, VK_ERROR_INITIALIZATION_FAILED,
1759-
"I can't KHR_display");
1760-
}
1757+
17611758

17621759
struct tu_physical_device *device = (struct tu_physical_device *)
17631760
vk_zalloc(&instance->vk.alloc, sizeof(*device), 8,

0 commit comments

Comments
 (0)